21 Mar
2022
21 Mar
'22
1:03 p.m.
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 6e24269549988be726564b5c45c91fd17ffb30e4
https://github.com/tribe29/checkmk/commit/6e24269549988be726564b5c45c91fd17…
Author: Óscar Nájera <oscar.najera(a)tribe29.com>
Date: 2022-03-21 (Mon, 21 Mar 2022)
Changed paths:
A .werks/13619
M cmk/gui/views/inventory.py
Log Message:
-----------
13619 FIX Fix crash due to dashboard's ill configured with software inventory object
restriction
If you configured a dashboard with the object restriction "show information of a
single software package", that setting produced a misconfiguration of the
dashboard specification. When updating to checkmk 2.1 your site is unusable and
you can only see a crash report with the message:
TypeError ('NoneType' object is not iterable)
This werk fixes the crash, yet we still recommend to remove dashboards that use
that restriction.
Fix method return type for dynamically created class
VisualInfo.single_spec(self) -> List[Tuple[str, ValueSpec]]
Thus the dynamically generated class, which we can't typecheck must
respect this return value.
This bug is similar to what is fixed with 3364. Yet instead of having an
if clause to deal with None in cmk.gui.visuals.info_params better
respect the VisualInfo.single_spec return type
CMK-10007
Change-Id: Ibe122571f4d00f4bff017eb2b1397e967780dc4d