[checkmk-commits] Check_MK Git: check_mk: Updated bug entries #0065, #0802, #0771, #0060, #0790

Module: check_mk Branch: master Commit: 5fac9c7ad6bddae12cedd1f513b05f741baed5d8 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5fac9c7ad6bdda… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Oct 9 15:00:30 2012 +0200 Updated bug entries #0065, #0802, #0771, #0060, #0790 --- .bugs/60 | 7 ++++++- .bugs/65 | 6 ++++++ .bugs/771 | 10 ++++------ .bugs/790 | 22 ++++++++++++++++++++++ .bugs/802 | 11 +++++------ 5 files changed, 43 insertions(+), 13 deletions(-) diff --git a/.bugs/60 b/.bugs/60 index 6633c82..2a3c554 100644 --- a/.bugs/60 +++ b/.bugs/60 @@ -1,4 +1,4 @@ -Title: Warnung im Logfile, wenn environment_macros an sind +Title: Livestatus-Warnung im Logfile, wenn environment_macros an sind Component: livestatus State: open Date: 2010-12-21 22:18:56 @@ -6,3 +6,8 @@ Class: feature Analog zu den broker options wäre das eine für die Stabilität wichtige Sache. + +Diese Variable kann man sicher irgendwie als globale Variable auslesen +und dann ins Nagios-Log schreiben (da wo auch die broker-Options +getestet werden). + diff --git a/.bugs/65 b/.bugs/65 index e08634d..0a8b0ed 100644 --- a/.bugs/65 +++ b/.bugs/65 @@ -7,3 +7,9 @@ Class: feature Ählich zu den expandierten notes_url. Damit könnte man sehen, welches Kommando wirklich ausgeführt wird. Und das zum rausschneiden und auf der Kommandozeile pasten. + +Dazu einen passenden Multisite-Painter, damit man das Kommando ansehen +kann. Diesen könnte man evtl. auch direkt in der Service-Details-View +anzeigen anstelle des jetzigen? + +Das gleiche dann natürlich auchbei den Host. diff --git a/.bugs/771 b/.bugs/771 index b342a7a..51c9dc1 100644 --- a/.bugs/771 +++ b/.bugs/771 @@ -5,9 +5,7 @@ Date: 2012-06-14 13:29:43 Targetversion: 1.2.0 Class: nastiness -When adding service columns to host tables the column -headers of those columns should be the service name, -not the title of the painter. The latter one is -for example "Perf-O-Meter". Better would be "CPU load". -(if this is not specified by the user in the first -place). +When adding service columns to host tables the column headers of those +columns should be the service name, not the title of the painter. The latter +one is for example "Perf-O-Meter". Better would be "CPU load". (if this is +not specified by the user in the first place). diff --git a/.bugs/790 b/.bugs/790 new file mode 100644 index 0000000..5e8b21f --- /dev/null +++ b/.bugs/790 @@ -0,0 +1,22 @@ +Title: Three Livecheck issues +Component: livecheck +State: open +Date: 2012-10-09 14:20:28 +Targetversion: 1.2.0 +Class: bug + +1. In livecheck.c:53, int bytes_read = read(fd[0], output, sizeof(output)); +does not guarantee a valid 0-byte terminated string. I propose a single +codeline after it: if (bytes_read > 0) output[bytes_read - 1] = 0; This +fixed an issue for me, where there was a lot of garbage behind output lines. + +2. In livecheck.c:190, check_type should always be 0. check_type determines +wether it is active(0) or passive(1), not host/service. Since livecheck is +always run actively on the host that it puts the checkfile. This doesn't +have to be variable. + +3. Somewhere before livecheck.c:188 the output charbuffer needs to be newline +escaped, there is a nagios function for this called escape_newlines. This +is necessary for long plugin output to be functional. + +Ticket #442 diff --git a/.bugs/802 b/.bugs/802 index 4098a21..1674986 100644 --- a/.bugs/802 +++ b/.bugs/802 @@ -5,9 +5,8 @@ Date: 2012-09-20 18:17:19 Targetversion: future Class: nastiness -If you add a simulated state for a given service (using foldable) -it will be reflected on the top-level, but not on the nodes. -So you see a lot of green items and but the main state stays as -configured to be simulated -it's very irritating, since the correct subaggrs and services -are in fact displayed, just not with their simulated states. +If you add a simulated state for a given service (using foldable) it will be +reflected on the top-level, but not on the nodes. So you see a lot of green +items and but the main state stays as configured to be simulated it's very +irritating, since the correct subaggrs and services are in fact displayed, +just not with their simulated states.