24 May
2017
24 May
'17
10 a.m.
Module: check_mk
Branch: master
Commit: 1a43b657879bc7639c7750976267efd58c64418e
URL:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1a43b657879bc7…
Author: Marcel Arentz <ma(a)mathias-kettner.de>
Date: Thu May 11 10:13:22 2017 +0200
4644 f5_bigip_mem: Improved Memory Check. Now also for TMM
As HR-MIB and UCD-MIB delivered incorrect information, F5 devices now have
their own checkplugin for memory. This includes also a separate Memory
Service for the TMM (Traffic Management Module). <b>Important</b>: This is
an incompatible change. You need to rediscover your services to remove the
hr_mem check and add the new f5_bigip_mem check.
Change-Id: Ibd85cf77202ae0739652be84a7c1e2b8639fac2b
---
.werks/4644 | 14 ++++++++
checkman/f5_bigip_mem | 13 +++++++
checkman/f5_bigip_mem.tmm | 14 ++++++++
checks/f5_bigip_mem | 90 +++++++++++++++++++++++++++++++++++++++++++++++
checks/ucd.include | 14 +++++---
5 files changed, 141 insertions(+), 4 deletions(-)
diff --git a/.werks/4644 b/.werks/4644
new file mode 100644
index 0000000..8f6828c
--- /dev/null
+++ b/.werks/4644
@@ -0,0 +1,14 @@
+Title: f5_bigip_mem: Improved Memory Check. Now also for TMM
+Level: 1
+Component: checks
+Compatible: incomp
+Edition: cre
+Version: 1.5.0i1
+Date: 1494490116
+Class: feature
+
+As HR-MIB and UCD-MIB delivered incorrect information, F5 devices now have
+their own checkplugin for memory. This includes also a separate Memory
+Service for the TTM (Traffic Management Module). <b>Important</b>: This is
+an incompatible change. You need to rediscover your services to remove the
+hr_mem check and add the new f5_bigip_mem check.
diff --git a/checkman/f5_bigip_mem b/checkman/f5_bigip_mem
new file mode 100644
index 0000000..55b5d12
--- /dev/null
+++ b/checkman/f5_bigip_mem
@@ -0,0 +1,13 @@
+title: F5 Big-IP: Usage of memory
+agents: snmp
+catalog: hw/network/f5
+license: GPL
+distribution: check_mk
+description:
+ This check measures the memory usage of F5 BIG-IP devices.
+
+ The logic used for monitoring is exactly the same as in the agent based
+ check {mem.used}. Please refer to the man page of that check for details.
+
+inventory:
+ One service for the target host will be created.
diff --git a/checkman/f5_bigip_mem.tmm b/checkman/f5_bigip_mem.tmm
new file mode 100644
index 0000000..91da2c7
--- /dev/null
+++ b/checkman/f5_bigip_mem.tmm
@@ -0,0 +1,14 @@
+title: F5 Big-IP: Usage of TMM memory
+agents: snmp
+catalog: hw/network/f5
+license: GPL
+distribution: check_mk
+description:
+ This check measures the memory usage of the TMM (Traffic Management Module)
+ in F5 BIG-IP devices.
+
+ The logic used for monitoring is exactly the same as in the agent based
+ check {mem.used}. Please refer to the man page of that check for details.
+
+inventory:
+ One service for the target host will be created.
diff --git a/checks/f5_bigip_mem b/checks/f5_bigip_mem
new file mode 100644
index 0000000..17fa5b8
--- /dev/null
+++ b/checks/f5_bigip_mem
@@ -0,0 +1,90 @@
+#!/usr/bin/python
+# -*- encoding: utf-8; py-indent-offset: 4 -*-
+# +------------------------------------------------------------------+
+# | ____ _ _ __ __ _ __ |
+# | / ___| |__ ___ ___| | __ | \/ | |/ / |
+# | | | | '_ \ / _ \/ __| |/ / | |\/| | ' / |
+# | | |___| | | | __/ (__| < | | | | . \ |
+# | \____|_| |_|\___|\___|_|\_\___|_| |_|_|\_\ |
+# | |
+# | Copyright Mathias Kettner 2015 mk(a)mathias-kettner.de |
+# +------------------------------------------------------------------+
+#
+# This file is part of Check_MK.
+# The official homepage is at http://mathias-kettner.de/check_mk.
+#
+# check_mk is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation in version 2. check_mk is distributed
+# in the hope that it will be useful, but WITHOUT ANY WARRANTY; with-
+# out even the implied warranty of MERCHANTABILITY or FITNESS FOR A
+# PARTICULAR PURPOSE. See the GNU General Public License for more de-
+# tails. You should have received a copy of the GNU General Public
+# License along with GNU Make; see the file COPYING. If not, write
+# to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor,
+# Boston, MA 02110-1301 USA.
+
+# Example output:
+# Overall memory
+# .1.3.6.1.4.1.3375.2.1.7.1.1.0 8396496896 sysHostMemoryTotal
+# .1.3.6.1.4.1.3375.2.1.7.1.2.0 1331092416 sysHostMemoryUsed
+#
+# TMM (Traffic Management Module) memory
+# .1.3.6.1.4.1.3375.2.1.1.2.1.44.0 0 sysStatMemoryTotal
+# .1.3.6.1.4.1.3375.2.1.1.2.1.45.0 0 sysStatMemoryUsed
+
+factory_settings["f5_bigip_mem_default_levels"] = {
+ "levels" : ("perc_used", (80.0, 90.0))
+}
+
+def parse_f5_bigip_mem(info):
+ parsed = {
+ "mem" : (info[0][0], info[0][1]),
+ "tmm" : (info[0][2], info[0][3]),
+ }
+ return parsed
+
+def inventory_f5_bigip_mem(parsed):
+ return [ ( "total", {} ) ]
+
+
+def check_f5_bigip_mem(item, params, parsed):
+ mem_total, mem_used = parsed["mem"]
+ return check_memory_simple(float(mem_used), float(mem_total), params)
+
+check_info['f5_bigip_mem'] = {
+ 'parse_function' : parse_f5_bigip_mem,
+ 'inventory_function' : inventory_f5_bigip_mem,
+ 'check_function' : check_f5_bigip_mem,
+ 'service_description' : 'Memory',
+ 'has_perfdata' : True,
+ 'snmp_info' : (".1.3.6.1.4.1.3375.2.1", [
+ "7.1.1", #
F5-BIGIP-SYSTEM-MIB::sysHostMemoryTotal
+ "7.1.2", #
F5-BIGIP-SYSTEM-MIB::sysHostMemoryUsed
+ "1.2.1.143", #
F5-BIGIP-SYSTEM-MIB::sysStatMemoryTotalKb
+ "1.2.1.144", #
F5-BIGIP-SYSTEM-MIB::sysStatMemoryUsedKb
+ ]),
+ 'snmp_scan_function' : lambda oid: ".1.3.6.1.4.1.3375" in
oid(".1.3.6.1.2.1.1.2.0"),
+ 'default_levels_variable' : 'f5_bigip_mem_default_levels',
+ 'group' : 'memory_simple',
+ 'includes' : [ "memory.include" ],
+}
+
+def inventory_f5_bigip_mem_tmm(parsed):
+ if not float(parsed["tmm"][0]) == 0:
+ return [ ( "TMM", {} ) ]
+
+
+def check_f5_bigip_mem_tmm(item, params, parsed):
+ mem_total, mem_used = parsed["tmm"]
+ return check_memory_simple(float(mem_used) * 1024, float(mem_total) * 1024, params)
+
+check_info['f5_bigip_mem.tmm'] = {
+ 'inventory_function' : inventory_f5_bigip_mem_tmm,
+ 'check_function' : check_f5_bigip_mem_tmm,
+ 'service_description' : 'Memory',
+ 'has_perfdata' : True,
+ 'default_levels_variable' : 'f5_bigip_mem_default_levels',
+ 'group' : 'memory_simple',
+ 'includes' : [ "memory.include" ],
+}
diff --git a/checks/ucd.include b/checks/ucd.include
index 7ec70db..cffa43d 100644
--- a/checks/ucd.include
+++ b/checks/ucd.include
@@ -56,11 +56,17 @@ def hr_mem_scan_function(oid):
# We prefer HOST-RESOURCES-MIB implementation but not in case
# of devices, which are known to report incorrect information
# about mem usage
- return not "pfsense" in oid(".1.3.6.1.2.1.1.1.0").lower() or \
- (oid(".1.3.6.1.2.1.25.1.1.0") and \
- not ucd_scan_function(oid))
+ return (not "pfsense" in oid(".1.3.6.1.2.1.1.1.0").lower() and \
+ ignore_ucd_and_hr(oid)) or \
+ (oid(".1.3.6.1.2.1.25.1.1.0") and \
+ not ucd_scan_function(oid))
def ucd_mem_scan_function(oid):
# Avoid inverting output of a function in a check plugin and be
# descriptive about what a function is actually doing
- return not hr_mem_scan_function(oid)
+ return not hr_mem_scan_function(oid) and \
+ ignore_ucd_and_hr(oid)
+
+def ignore_ucd_and_hr(oid):
+ # Some devices report incorrect data on both hr and ucd
+ return not
oid(".1.3.6.1.2.1.1.2.0").startswith(".1.3.6.1.4.1.3375") # F5 BigIP