[checkmk-commits] [tribe29/checkmk] d9aa6a: get_check_preview: rely on max_cachefile_age

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: d9aa6a28ac44c108c45982e05386a383c82638eb https://github.com/tribe29/checkmk/commit/d9aa6a28ac44c108c45982e05386a383c… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-02-11 (Thu, 11 Feb 2021) Changed paths: M cmk/base/config.py M cmk/base/discovery.py Log Message: ----------- get_check_preview: rely on max_cachefile_age We no longer choose Mode.DISCOVERY over Mode.CACHED_DISCOVERY, but instead rely on the fact that max_cachefile_age is set to zero if no caches should be used, (as we did for other datasources anyway). Change-Id: I43f29fb126731366b18a9062573da751b4b5d0ed Commit: 241cac119377c9c9972b8946196b8c5c742010fe https://github.com/tribe29/checkmk/commit/241cac119377c9c9972b8946196b8c5c7… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-02-11 (Thu, 11 Feb 2021) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/checkers/_abstract.py M cmk/base/discovery.py M tests/unit/cmk/base/checkers/test_cmd_caching.py Log Message: ----------- discovery: consolidate caching options The handling of the caching options is consolidated into the discovery module. The code in cmk.base.automations only passes flags along. The functions * `discover_on_host` used by the automation 'inventory' and the automatic service discovery and * `get_check_preview` used by the automation 'try-inventory' no longer accept the argument 'use_caches'. Instead, they are passed the arguments 'use_cached_snmp_data' and 'max_cachefile_age'. The flag 'use_caches' was aplied to both the TCP and the SNMP data sources. That is wrong: The TCP data sources could be sending some data only once, in which case information would be missed by the checks. TCP sources *must* use the caches. The cache file of the SNMP data source will only contain the sections detected when the data was fetched. The set of detected sections is expected to change rarely, so depending on the use case, using the SNMP caches may not be desired. In particular: When hitting the "Full scan" button on the discovery page, we expect new sections to be detected. Change-Id: I4b801a382e62ebdfa8d08788cdf28580a5ac5397 Commit: 0482468832f0c20228fcc2ec56ce53720425a046 https://github.com/tribe29/checkmk/commit/0482468832f0c20228fcc2ec56ce53720… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-02-11 (Thu, 11 Feb 2021) Changed paths: M cmk/base/discovery.py M cmk/fetchers/snmp.py M cmk/fetchers/type_defs.py M tests/unit/cmk/base/checkers/test_cmd_caching.py M tests/unit/cmk/fetchers/test_fetchers.py Log Message: ----------- fetchers: remove redundant Mode We have changed cache handling, s.t. the dedicated CACHED_DISCOVERY mode is not needed anymore. Change-Id: I59222800587523c001b628041db5dacc53d99680 Commit: 56b0d6e7a8f4eeb849bb81ff9b795f781f20e4ce https://github.com/tribe29/checkmk/commit/56b0d6e7a8f4eeb849bb81ff9b795f781… Author: Andreas Boesl <andreas.boesl(a)tribe29.com> Date: 2021-02-11 (Thu, 11 Feb 2021) Changed paths: M tests/integration/cmk/test_omd_version.py Log Message: ----------- fixed integration test: lru_cache related bug Change-Id: I1f0c495cd6a0d2547fd8cef6bdee699d65020195 Compare: https://github.com/tribe29/checkmk/compare/61a9a674c899...56b0d6e7a8f4