[checkmk-commits] Check_MK Git: check_mk: FIX Multisite context buttons: links in context buttons are no longer called twice

Module: check_mk Branch: master Commit: dde31d9ee70e08e5426988a4b6f940ac4305b675 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=dde31d9ee70e08… Author: Andreas Boesl &lt;ab(a)mathias-kettner.de&gt; Date: Thu Apr 24 14:52:19 2014 +0200 FIX Multisite context buttons: links in context buttons are no longer called twice The "onclick" attribute in the context button (buttons at the top of a page) additionally called the href link, which was already specified in the "href" attribute. This could lead to raise conditions where transactions (saving a formular) were not handled correctly. --- .werks/905 | 10 ++++++++++ ChangeLog | 1 + web/htdocs/htmllib.py | 2 +- 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/.werks/905 b/.werks/905 new file mode 100644 index 0000000..0e0d7e0 --- /dev/null +++ b/.werks/905 @@ -0,0 +1,10 @@ +Title: Multisite context buttons: links in context buttons are no longer called twice +Level: 1 +Component: multisite +Version: 1.2.5i3 +Date: 1398343626 +Class: fix + +The "onclick" attribute in the context button (buttons at the top of a page) additionally +called the href link, which was already specified in the "href" attribute. +This could lead to raise conditions where transactions (saving a formular) were not handled correctly. diff --git a/ChangeLog b/ChangeLog index 61b25d0..eeb39e7 100644 --- a/ChangeLog +++ b/ChangeLog @@ -58,6 +58,7 @@ Multisite: * 0779 Hostgroups (Summary): Empty hostgroups are no longer shown (can be re-enabled by filter) * 0887 Add new column painter "Host Notifications Enabled"... + * 0905 FIX: Multisite context buttons: links in context buttons are no longer called twice... WATO: * 0784 Improved security of WATO bulk inventory by using transaction ids diff --git a/web/htdocs/htmllib.py b/web/htdocs/htmllib.py index 488852f..8957a97 100644 --- a/web/htdocs/htmllib.py +++ b/web/htdocs/htmllib.py @@ -382,7 +382,7 @@ class html: if hover_title: self.write(' title="%s"' % self.attrencode(hover_title)) if bestof: - self.write(' onclick="count_context_button(this); document.location=this.href; " ') + self.write(' onclick="count_context_button(this); " ') if fkey and self.keybindings_enabled: title += '<div class=keysym>F%d</div>' % fkey self.add_keybinding([html.F1 + (fkey - 1)], "document.location='%s';" % self.attrencode(url))