[checkmk-commits] Removed the last import cycle in cmk_base.

Module: check_mk Branch: master Commit: 18bcaf516baf436d69f0703d1ec849760c41ceb3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=18bcaf516baf43… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Fri Jun 15 13:41:15 2018 +0200 Removed the last import cycle in cmk_base. This was done by merging cmk_base.{config,checks,rulesets} back into a single module again. The initial intention of splitting this rather big module up was well-intentioned, but the split simply did not reflect reality: Each of the three modules was heavily tied to the other two modules, resulting in 3 import cycles between them. So in effect, the split was wishful thinking, the module effectly stayed a single entity, only the source code was scattered around 3 different files. Import cycles are an absolute architectural no-no, and in addition they actually harm most kinds of tooling heavily. So having a larger module again is a very small price to pay... Change-Id: If62d400466eecbee76f38135946daa1c7863ec1a --- bin/check_mk | 3 +- cmk_base/autochecks.py | 5 +- cmk_base/automations/__init__.py | 3 +- cmk_base/automations/check_mk.py | 42 +- cmk_base/check_api.py | 23 +- cmk_base/check_table.py | 16 +- cmk_base/checking.py | 7 +- cmk_base/checks.py | 843 ------------ cmk_base/config.py | 1456 +++++++++++++++++++- cmk_base/core_config.py | 16 +- cmk_base/core_nagios.py | 49 +- cmk_base/crash_reporting.py | 1 - cmk_base/data_sources/__init__.py | 6 +- cmk_base/data_sources/abstract.py | 5 +- cmk_base/data_sources/host_sections.py | 13 +- cmk_base/data_sources/ipmi.py | 1 - cmk_base/data_sources/programs.py | 5 +- cmk_base/data_sources/snmp.py | 5 +- cmk_base/data_sources/tcp.py | 1 - cmk_base/default_config/base.py | 16 +- cmk_base/discovery.py | 26 +- cmk_base/donate.py | 3 +- cmk_base/dump_host.py | 3 +- cmk_base/events.py | 7 +- cmk_base/inventory.py | 8 +- cmk_base/inventory_plugins.py | 12 +- cmk_base/ip_lookup.py | 3 +- cmk_base/modes/__init__.py | 3 +- cmk_base/modes/check_mk.py | 12 +- cmk_base/notify.py | 3 +- cmk_base/parent_scan.py | 3 +- cmk_base/rulesets.py | 555 -------- cmk_base/snmp_scan.py | 16 +- tests/integration/cmk_base/test_check_variables.py | 27 +- tests/integration/cmk_base/test_data_sources.py | 3 +- tests/integration/cmk_base/test_mgmt_board.py | 3 +- tests/integration/core/test_active_checks.py | 6 +- tests/testlib/__init__.py | 18 +- tests/unit/checks/test_df_check.py | 6 +- tests/unit/cmk/test_man_pages.py | 8 +- tests/unit/cmk_base/test_checks.py | 32 +- tests/unit/cmk_base/test_config.py | 9 +- tests/unit/cmk_base/test_rulesets.py | 8 +- 43 files changed, 1583 insertions(+), 1707 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=18bcaf516b…