[checkmk-commits] [tribe29/checkmk] 484804: 15431 FIX rule: Return a 404 when a rule doesn't e...

Branch: refs/heads/2.2.0 Home: https://github.com/tribe29/checkmk Commit: 484804c64bd7433de0c17d5fb2654649d13d4416 https://github.com/tribe29/checkmk/commit/484804c64bd7433de0c17d5fb2654649d… Author: Gav <gavin.mcguigan(a)tribe29.com> Date: 2023-03-06 (Mon, 06 Mar 2023) Changed paths: A .werks/15431 M cmk/gui/plugins/openapi/endpoints/rule/__init__.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_rules.py Log Message: ----------- 15431 FIX rule: Return a 404 when a rule doesn't exist on the GET endpoint This werk is to fix an issue with the GET rule endpoint. Previously the response contained a bug report when the rule didn't exist. Now we conform to our other endpoints and return a 404 problem response. CMK-11900 Change-Id: I6c035e7c2f967a5858a5dc888d30742c78106809 Commit: 05a3899bcea34db46d02ad5ccca163e85b5346fd https://github.com/tribe29/checkmk/commit/05a3899bcea34db46d02ad5ccca163e85… Author: Gav <gavin.mcguigan(a)tribe29.com> Date: 2023-03-06 (Mon, 06 Mar 2023) Changed paths: A .werks/15379 M cmk/gui/plugins/openapi/endpoints/aux_tags/__init__.py M tests/testlib/rest_api_client.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_auxtags.py Log Message: ----------- 15379 FIX aux_tags: aux_tag_id must exist in order to update This werk fixes a bug in the aux_tag put endpoint. Previously when sending a put request with a non-existing aux_tag_id, it would result in a 500 internal server error. Now we conform to our other endpoints and return a 404 response. CMK-12320 Change-Id: I4063d61e1a827a978d76cbdde0ae8daf92c4b837 Commit: 3e9fc0ccd5334f4a5dc0b84371da90bc54aefae4 https://github.com/tribe29/checkmk/commit/3e9fc0ccd5334f4a5dc0b84371da90bc5… Author: Gav <gavin.mcguigan(a)tribe29.com> Date: 2023-03-06 (Mon, 06 Mar 2023) Changed paths: A .werks/15380 M cmk/gui/plugins/openapi/endpoints/activate_changes/__init__.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_activate_changes.py Log Message: ----------- 15380 FIX activate_changes: responses for non-existing activate_ids now include detail This werk fixes an issue with the problem response in the activate changes GET endpoint. Previously, it would return a 404 with a title attribute only. It now conforms to our other endpoints and returns a problem response with status code, title and detail attribute. Change-Id: I35775bad196ba6dbaad569874bb550879bb53443 Commit: d6d6b56b181862f0bd115d8f950a036b975c554f https://github.com/tribe29/checkmk/commit/d6d6b56b181862f0bd115d8f950a036b9… Author: Gav <gavin.mcguigan(a)tribe29.com> Date: 2023-03-06 (Mon, 06 Mar 2023) Changed paths: A .werks/15433 M cmk/gui/plugins/openapi/endpoints/service_discovery.py Log Message: ----------- 15433 FIX service_discovery: response for non-existing jobs now include detail This werk fixes an issue with the problem response in the service discovery GET endpoint. Previously, it would return a 404 with a title attribute only. It now conforms to our other endpoints and returns a problem response with status code, title and detail attribute. Change-Id: Ifba5314c92a7c576986642ece0a9830a4d32ea19 Commit: 9b5257e7f6228b87892713e1088906c606d2a05b https://github.com/tribe29/checkmk/commit/9b5257e7f6228b87892713e1088906c60… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2023-03-06 (Mon, 06 Mar 2023) Changed paths: M cmk/base/config.py M cmk/base/default_config/base.py Log Message: ----------- remove `checks` and `legacy_checks` from config A configuration that uses these variables can not have made it to 2.0... Change-Id: I5ee791c41b95764cd03b6bbaa0481e2b22a37cc6 Commit: b400bba15656255766f2cf45ce725111b74ad939 https://github.com/tribe29/checkmk/commit/b400bba15656255766f2cf45ce725111b… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2023-03-06 (Mon, 06 Mar 2023) Changed paths: M cmk/base/config.py Log Message: ----------- drop base config validation The base component no longer validates the variables found in .mk files. Previously we issued a warning or even failed upon an unknown variable. We now silently ignore them. Change-Id: Iae99402ae07d2f91faade02e08068367b1486341 Commit: 7444d5a0281c0558f9211c596036cb4f6e14f265 https://github.com/tribe29/checkmk/commit/7444d5a0281c0558f9211c596036cb4f6… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2023-03-06 (Mon, 06 Mar 2023) Changed paths: M cmk/gui/watolib/rulesets.py Log Message: ----------- keep all variables in rules.mk We no longer silently drop the rules, but keep them in a dedicated attribute. This way, we can not crash if any information is used that is not available for unknown rules (e.g. during rendering). Change-Id: Ib1e610a362c8ae82b83b4f685405e161dda5dd6f Compare: https://github.com/tribe29/checkmk/compare/8974211116ec...7444d5a0281c