9 Sep
2020
9 Sep
'20
12:42 p.m.
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 51f3e5bc73e5a829e7b15443bb82f4924295e3d3
https://github.com/tribe29/checkmk/commit/51f3e5bc73e5a829e7b15443bb82f4924…
Author: Joerg Herbel <joerg.herbel(a)tribe29.com>
Date: 2020-09-09 (Wed, 09 Sep 2020)
Changed paths:
A .werks/11366
M checkman/brocade_optical
R checks/brocade_optical
A cmk/base/plugins/agent_based/brocade_optical.py
M cmk/base/plugins/agent_based/utils/interfaces.py
R tests/unit/checks/generictests/datasets/brocade_optical_1_regression.py
R tests/unit/checks/generictests/datasets/brocade_optical_2_regression.py
M tests/unit/checks/test_generic_legacy_conversion.py
A tests/unit/cmk/base/plugins/agent_based/test_brocade_optical.py
Log Message:
-----------
11366 brocade_optical: Adjust to new discovery ruleset for network interfaces
The discovery of the services corresponding to the check
<tt>brocade_optical</tt>,
which monitors the signal quality of the optical ports of Brocade switches, is
configurable via the rule "Network Interface and Switch Port Discovery". As
announced
in werk #11361, this rule has been reworked.
With this werk, we adjust <tt>brocade_optical</tt> to the new version of the
discovery
ruleset for network interfaces. This check now uses the discovery ruleset for network
interfaces the same way as all other interface checks and is thus consistent with
werk #11361, which was not the case before. However, note that, as before,
<tt>brocade_optical</tt> does not implement all of the options offered by
this
discovery rule. The grouping of interfaces is not supported and the items are always
given by the port numbers, independently of the option chosen under "Appearance of
network interface". Furthermore, out of the six matching conditions offered by the
rule,
this check supports only the following three: the matching of the port type, the matching
of the port state and the matching of the interface description.
This werk is incompatible. Currently discovered services will continue to work, however,
upon re-discovery, some services might vanish or new services might be discovered. This
depends on the user-defined rules from the ruleset "Network Interface and Switch
Port
Discovery". In such cases, users have to adjust their rules. Note that the default
behavior of the check has not changed. Hence, this werk is compatible for users with no
corresponding user-defined rules.
This change also migrates brocade_optical to the new API.
CMK-5321
Change-Id: I1abf6d205825ef88c6bef26ead4f64dc6e97b70f