12 Aug
2021
12 Aug
'21
8:52 a.m.
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 95e63f2dfbfe109eee17a8e286d7ce911af1457e
https://github.com/tribe29/checkmk/commit/95e63f2dfbfe109eee17a8e286d7ce911…
Author: Joerg Herbel <joerg.herbel(a)tribe29.com>
Date: 2021-08-12 (Thu, 12 Aug 2021)
Changed paths:
R tests/unit/checks/generictests/datasets/raritan_pdu_plugs_regression.py
A tests/unit/checks/test_raritan_pdu_plugs.py
A tests/unit/checks/test_sentry_pdu.py
Log Message:
-----------
Add unit tests for legacy plugins sentry_pdu and raritan_pdu_plugs
SUP-7169
Change-Id: I2a4015b1cffe11291b0eeef9e647c06149544e7b
Commit: bf2fbdf25e05ba0490853fca1aec6090bde42de3
https://github.com/tribe29/checkmk/commit/bf2fbdf25e05ba0490853fca1aec6090b…
Author: Joerg Herbel <joerg.herbel(a)tribe29.com>
Date: 2021-08-12 (Thu, 12 Aug 2021)
Changed paths:
M checks/sentry_pdu
A cmk/base/plugins/agent_based/sentry_pdu.py
M tests/unit/checks/test_sentry_pdu.py
Log Message:
-----------
Implement section sentry_pdu in new API
This commit temporarily breaks the compatibility of the legacy plugin
sentry_pdu with integers as discovered params. The following commits
will fix this.
SUP-7169
Change-Id: I323d1194fe6a769fb63dd556d01fa8e49cd7ca56
Commit: 551d4770ea508727007147a96c152d12089e5b6d
https://github.com/tribe29/checkmk/commit/551d4770ea508727007147a96c152d120…
Author: Joerg Herbel <joerg.herbel(a)tribe29.com>
Date: 2021-08-12 (Thu, 12 Aug 2021)
Changed paths:
M checks/raritan_pdu_plugs
M checks/sentry_pdu
M tests/unit/checks/test_raritan_pdu_plugs.py
M tests/unit/checks/test_sentry_pdu.py
Log Message:
-----------
sentry_pdu, raritan_pdu_plugins: fix discovered params + unknown states
Both plugins now use type-safe dicts as discovered params and handle
unknown states properly.
SUP-7169
Change-Id: I097a1bbb43557a25147c312da54b8d7cf0021dc8
Commit: 0eebc6a9aa6e098cd5302d31909bc3b5c63f308e
https://github.com/tribe29/checkmk/commit/0eebc6a9aa6e098cd5302d31909bc3b5c…
Author: Joerg Herbel <joerg.herbel(a)tribe29.com>
Date: 2021-08-12 (Thu, 12 Aug 2021)
Changed paths:
M cmk/gui/plugins/wato/check_parameters/plugs.py
Log Message:
-----------
checks_parameters/plugs.py: Improve formatting and typing
SUP-7169
Change-Id: I2b578a0318a717d530c088992cc7aa998deebf77
Commit: 2b12881801cac3816f4040d890fce4dca5c40c57
https://github.com/tribe29/checkmk/commit/2b12881801cac3816f4040d890fce4dca…
Author: Joerg Herbel <joerg.herbel(a)tribe29.com>
Date: 2021-08-12 (Thu, 12 Aug 2021)
Changed paths:
M cmk/gui/plugins/wato/check_parameters/plugs.py
Log Message:
-----------
checks_parameters/plugs.py: Fix transform + typo in ignored_keys
SUP-7169
Change-Id: Iebe314ed55fba913bb6f988ddb3992431c33523b
Commit: 79c32641aa9e6f4ff9557c65bd05d7d20f904b91
https://github.com/tribe29/checkmk/commit/79c32641aa9e6f4ff9557c65bd05d7d20…
Author: Joerg Herbel <joerg.herbel(a)tribe29.com>
Date: 2021-08-12 (Thu, 12 Aug 2021)
Changed paths:
A .werks/13118
Log Message:
-----------
13118 FIX <tt>sentry_pdu, raritan_pdu_plugs</tt>: Fix parameter handling
The check plugins <tt>sentry_pdu</tt> and
<tt>raritan_pdu_plugs</tt> both
monitor the status of PDUs. In the discovery phase, both plugins store the
current states of the discovered PDUs. The subsequently computed check
results are based on a comparison of the discovered states with the current
states of the PDUs. Both plugins did not handle unknown states properly.
Furthermore, users have the option to explicitly configure target states for
the PDUs. In this case, the user-configured states are preferred over the
discovered states. This mechanism was broken for <tt>sentry_pdu</tt>.
Finally, when updating Checkmk from 1.6 to 2.0 and also during updates within
2.0, the states discovered by the plugin <tt>sentry_pdu</tt> were lost.
To fix these issues, users have to re-discover the corresponding services
"Plug ...". Note that for <tt>raritan_pdu_plugs</tt>, depending on
the
current configuration, a re-discovery might not be necessary, but we
recommend it preemptively.
SUP-7169
Change-Id: I94bca6f6e71e5e89b1f60376d8b9b2a3b251c295
Compare: https://github.com/tribe29/checkmk/compare/6328c44a4b87...79c32641aa9e