[checkmk-commits] Check_MK Git: check_mk: #1571 FIX check_mk_agent.linux: fix output of lnx_if on Ubuntu 8.04 (on older kernels), repairs tcp_conn_stats

Module: check_mk Branch: master Commit: f9fce9a6e88406a81c321f5c24ce5487d084e866 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f9fce9a6e88406… Author: Mathias Kettner &lt;mk(a)mathias-kettner.de&gt; Date: Wed Dec 3 18:40:23 2014 +0100 #1571 FIX check_mk_agent.linux: fix output of lnx_if on Ubuntu 8.04 (on older kernels), repairs tcp_conn_stats Problem on some older kernels is, that <tt>/sys/class/net/$eth/address</tt> does not contain a newline (or does not exist at all). We now always output an additional newline. This does not harm and fixes the problem. Without the fix the next section <tt>tcp_conn_stats</tt> is not correctly detected and is missing. --- .werks/1571 | 14 ++++++++++++++ ChangeLog | 3 ++- agents/check_mk_agent.linux | 2 +- 3 files changed, 17 insertions(+), 2 deletions(-) diff --git a/.werks/1571 b/.werks/1571 new file mode 100644 index 0000000..67eb6d8 --- /dev/null +++ b/.werks/1571 @@ -0,0 +1,14 @@ +Title: check_mk_agent.linux: fix output of lnx_if on Ubuntu 8.04 (on older kernels), repairs tcp_conn_stats +Level: 1 +Component: checks +Compatible: compat +Version: 1.2.5i7 +Date: 1417628312 +Class: fix + +Problem on some older kernels is, that <tt>/sys/class/net/$eth/address</tt> does +not contain a newline (or does not exist at all). We now always output an +additional newline. This does not harm and fixes the problem. + +Without the fix the next section <tt>tcp_conn_stats</tt> is not correctly +detected and is missing. diff --git a/ChangeLog b/ChangeLog index 29c21be..9c93ad7 100644 --- a/ChangeLog +++ b/ChangeLog @@ -38,8 +38,8 @@ * 1611 mssql.vbs: Supporting SQL-Server 2014 now * 1568 f5_bigip_cluster_v11: new check for F5 cluster status for firmware version 11 * 1450 checkpoint_connections, checkpoint_packets: new checks to monitor Checkpoint firewalls - * 1451 users: new check to monitor number of users logged in on a linux system... * 1569 check_mk_agent.openbsd: add sections for mem and lnx_if (memory and network interfaces)... + * 1451 users: new check to monitor number of users logged in on a linux system... * 1478 FIX: kernel.util, statgrab_cpu: fix computation of utilization... * 1480 FIX: brocade_vdx_status: disable check on some devices that do not support it... * 1485 FIX: dell_om_disks, dell_om_esmlog, dell_om_mem, dell_om_processors, dell_om_sensors: detect more devices... @@ -74,6 +74,7 @@ * 1609 FIX: zpool_status: fix problem when the zpool has a separate log or cache device... * 1566 FIX: 3ware_disks: consider VERIFYING state as OK now... * 1612 FIX: job: Fixed wrong reported start time for running jobs + * 1571 FIX: check_mk_agent.linux: fix output of lnx_if on Ubuntu 8.04 (on older kernels), repairs tcp_conn_stats... Multisite: * 1508 Allow input of plugin output and perfdata when faking check results... diff --git a/agents/check_mk_agent.linux b/agents/check_mk_agent.linux index 48d6847..b301727 100755 --- a/agents/check_mk_agent.linux +++ b/agents/check_mk_agent.linux @@ -217,7 +217,7 @@ then do echo "[$eth]" ethtool $eth | egrep '(Speed|Duplex|Link detected|Auto-negotiation):' - echo -en "\tAddress: " ; cat /sys/class/net/$eth/address + echo -en "\tAddress: " ; cat /sys/class/net/$eth/address ; echo done fi