[checkmk-commits] [tribe29/checkmk] 6e32e0: Refactor urlencode_vars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 6e32e06c03d19b1210961b0461a2783fb35e8838 https://github.com/tribe29/checkmk/commit/6e32e06c03d19b1210961b0461a2783fb… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2021-08-12 (Thu, 12 Aug 2021) Changed paths: M cmk/gui/utils/urls.py Log Message: ----------- Refactor urlencode_vars It also makes it a little bit more performant (~10-15%). It's not much but since we use it quite often (e.g. in the rule overview) it pays off. CMK-8035 Change-Id: Iaee009328df7cb8341a997f16a0ef40ee82a1e0c Commit: 34ff185efb756d24911bc94c44cb2df1ee988c03 https://github.com/tribe29/checkmk/commit/34ff185efb756d24911bc94c44cb2df1e… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2021-08-12 (Thu, 12 Aug 2021) Changed paths: M tests/unit/cmk/gui/test_escaping.py Log Message: ----------- Add tests for LazyString in test_escaping.py Change-Id: If0166ff7f9d5a8697efe0d1eeac2695c7dd07c11 Commit: b9b15f838426d3987b8a074c52d2c9f01ced9bde https://github.com/tribe29/checkmk/commit/b9b15f838426d3987b8a074c52d2c9f01… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2021-08-12 (Thu, 12 Aug 2021) Changed paths: M cmk/gui/utils/escaping.py M tests/unit/cmk/gui/test_escaping.py Log Message: ----------- Fix conditionals in escape_attribute Since type(value) was used in isinstance checks they always evaluated to False. I.e. for the common case str all conditionals were always evaluated. Now, isinstance is used on the value and the str and HTML cases are moved to the top. In tests this resulted in a 25 - 30% performance improvement. Furthermore, the case for bytes is removed and one for float and LazyString are added. If no conditional matches an exception is thrown. Any call sites that raise an exception in the future should be fixed. CMK-8035 Change-Id: I60e6f87caad1a0f4061f1ed2efb8b9e1205b53aa Commit: 30d35a68f256cc9facde56717faf54e4fccf9fe0 https://github.com/tribe29/checkmk/commit/30d35a68f256cc9facde56717faf54e4f… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2021-08-12 (Thu, 12 Aug 2021) Changed paths: M cmk/gui/wato/pages/rulesets.py Log Message: ----------- Use omit_update_header in the ruleset overview It generated one unnecessary javascript tag for every folder in the ruleset overview. CMK-8035 Change-Id: If74d395d8b559cc93452df55457e6df7f7d34a7e Commit: aa1ff8b445b85ea97956cbeeee6a16143eed89ea https://github.com/tribe29/checkmk/commit/aa1ff8b445b85ea97956cbeeee6a16143… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2021-08-12 (Thu, 12 Aug 2021) Changed paths: M cmk/gui/utils/urls.py Log Message: ----------- Add stripped-down versions of quote_plus and quote They fit exactly our needs and are 40-50% faster. CMK-8035 Change-Id: If6bfd6562b02d051f6bd941a6a27bca919850630 Compare: https://github.com/tribe29/checkmk/compare/9f81eb5541ab...aa1ff8b445b8