[checkmk-commits] [tribe29/checkmk] 65ab07: interface utils unit tests: improve typing and for...

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 65ab0773600aa280fdcf8f2ea53e59aff654c436 https://github.com/tribe29/checkmk/commit/65ab0773600aa280fdcf8f2ea53e59aff… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-08-16 (Mon, 16 Aug 2021) Changed paths: M tests/unit/cmk/base/plugins/agent_based/utils/test_interfaces.py Log Message: ----------- interface utils unit tests: improve typing and formatting Also remove unnecessary value store fixture (set anyway in tests/unit/../agent_based/conftest.py) Change-Id: I31dc65252d847e626fb9c97de64a416ca5c892d5 Commit: 5a101cd702776421edce68ee0b3873b77619bdc7 https://github.com/tribe29/checkmk/commit/5a101cd702776421edce68ee0b3873b77… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-08-16 (Mon, 16 Aug 2021) Changed paths: M tests/unit/cmk/base/plugins/agent_based/utils/test_interfaces.py Log Message: ----------- interface utils: add unit test for discovered params in cluster mode SUP-7244 Change-Id: I594b2ef91e09d34c1b3a29fad96080e2c19fa02b Commit: 6bfb43d2d031614eb9dceee66cce2f74d8e5997b https://github.com/tribe29/checkmk/commit/6bfb43d2d031614eb9dceee66cce2f74d… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-08-16 (Mon, 16 Aug 2021) Changed paths: A .werks/13119 M cmk/base/plugins/agent_based/utils/interfaces.py M tests/unit/cmk/base/plugins/agent_based/utils/test_interfaces.py Log Message: ----------- 13119 FIX Interface checks: Do not use discovered state and speed in cluster mode The interface checks compare the current state and speed of the interfaces to the values which were found during the discovery phase (unless the user explicitly configured a different behavior). However, in cluster mode, this comparison is not useful because the discovered values correspond to a single interface, whereas the the current values correspond to potentially multiple interfaces. Therefore, with this werk, this comparison is removed. Note that, as before, users still have the option to explicitly set the expected state and speed, also in cluster mode. SUP-7244 Change-Id: Id5956a93906c59250257cede50f332b86c55b2be Commit: d61ae70a3f7287dd4ad8ac2c02af047089f710ac https://github.com/tribe29/checkmk/commit/d61ae70a3f7287dd4ad8ac2c02af04708… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-08-16 (Mon, 16 Aug 2021) Changed paths: M tests/testlib/__init__.py M tests/unit/cmk/base/plugins/agent_based/test_aix_diskiod.py M tests/unit/cmk/base/plugins/agent_based/test_cadvisor_if.py M tests/unit/cmk/base/plugins/agent_based/test_diskstat.py M tests/unit/cmk/base/plugins/agent_based/test_lnx_if.py M tests/unit/cmk/base/plugins/agent_based/test_netapp_api_vf_stats.py M tests/unit/cmk/base/plugins/agent_based/test_smart.py M tests/unit/cmk/base/plugins/agent_based/test_winperf_if.py M tests/unit/cmk/base/plugins/agent_based/test_winperf_phydisk.py Log Message: ----------- Remove get_value_store_fixture from unit tests This now handled in tests/unit/../agent_based/conftest.py Change-Id: I67d222b28e21ae06d6d2652639cd0eb4d72297a8 Commit: 830e9076781198a810e34f32324b39061514b9af https://github.com/tribe29/checkmk/commit/830e9076781198a810e34f32324b39061… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-08-16 (Mon, 16 Aug 2021) Changed paths: M tests/unit/cmk/base/plugins/agent_based/utils/test_interfaces.py Log Message: ----------- Remove unused import from unit tests for interface utils Change-Id: I1467730865f369ed2e39513b0033bc38da55e71e Compare: https://github.com/tribe29/checkmk/compare/235f93078aec...830e90767811