29 Aug
2023
29 Aug
'23
3:03 p.m.
Branch: refs/heads/2.2.0
Home: https://github.com/Checkmk/checkmk
Commit: 262db605db15c339803257fb50dd88a8a916024d
https://github.com/Checkmk/checkmk/commit/262db605db15c339803257fb50dd88a8a…
Author: Gav <gavin.mcguigan(a)checkmk.com>
Date: 2023-08-29 (Tue, 29 Aug 2023)
Changed paths:
A .werks/15968
M cmk/gui/plugins/openapi/endpoints/host_config/__init__.py
M cmk/gui/plugins/openapi/endpoints/host_config/request_schemas.py
M tests/testlib/rest_api_client.py
M tests/unit/cmk/gui/plugins/openapi/test_openapi_host_config.py
Log Message:
-----------
15968 FIX host_config: update endpoint now only allows one of replace, update or delete
Previously when calling update host, you could pass any combination of
replace all attributes
update some attributes
delete some attributes
Some of these combinations didn't make much sense and could lead to
errors. This werk simplifies this by only allowing one of the options
when calling update host or bulk update host.
For update_host, previously you could to the following
C+:
{
"attributes": {"ipaddress": "192.168.9.123"},
"update_attributes" {"ipaddress": "192.168.0.123"},
"remove_attributes": ["tag_foobar],
}
C-:
This werk modifies this behaviour by forcing the client to select only
one action.
C+:
{
"attributes": {"ipaddress": "192.168.9.123"},
}
C-:
OR
C+:
{
"update_attributes": {"ipaddress": "192.168.9.124"},
}
C-:
OR
C+:
"remove_attributes": ["tag_foobar"],
C-:
CMK-14148
Change-Id: Ib1396985b830c6b4aefca5a351f1e6d19356fcdc
Commit: 3f85f8e7ce941857162710dcc42034e6789e71d6
https://github.com/Checkmk/checkmk/commit/3f85f8e7ce941857162710dcc42034e67…
Author: Gav <gavin.mcguigan(a)checkmk.com>
Date: 2023-08-29 (Tue, 29 Aug 2023)
Changed paths:
M cmk/gui/plugins/openapi/endpoints/host_config/__init__.py
Log Message:
-----------
host_config: code cleanup
Remove _verify_hostname() func and it's callers. The hostname is
already verified in the schemas for the endpoints modified.
Change-Id: I66014463caa5cb84d12690f290c187ccdbea7069
Commit: 62b08843061352c3ad239a3132353ec7cf3bacb2
https://github.com/Checkmk/checkmk/commit/62b08843061352c3ad239a3132353ec7c…
Author: Gav <gavin.mcguigan(a)checkmk.com>
Date: 2023-08-29 (Tue, 29 Aug 2023)
Changed paths:
M tests/testlib/rest_api_client.py
M tests/unit/cmk/gui/plugins/openapi/test_openapi_host_config.py
Log Message:
-----------
host_config: update remaining tests to use the HostConfig client
Change-Id: I7b64f7bf3a44886bdb3163bc3fb3b6fd0d108faa
Compare: https://github.com/Checkmk/checkmk/compare/3cd0d083f50e...62b088430613