[checkmk-commits] Disabled forms in views can not be opened anymore

Module: check_mk Branch: master Commit: 03413d2915f63a734058e573ff16a7a3da467379 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=03413d2915f63a… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jul 21 09:10:05 2017 +0200 Disabled forms in views can not be opened anymore Change-Id: Ia1c9337f60c143f2cb13edc008124f17961ab00f --- .bugs/2929 | 6 ++++-- web/htdocs/htmllib.py | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.bugs/2929 b/.bugs/2929 index beb1e0e..9540f1c 100644 --- a/.bugs/2929 +++ b/.bugs/2929 @@ -1,10 +1,12 @@ Title: Command box in views is openable even if the icon is disabled Component: multisite -State: open +Class: bug +State: done Date: 2017-07-18 11:29:49 Targetversion: 1.4.0 -Class: bug If you have a view with no services then the icon for the command box is diabled. But nevertheless you can open the box by clicking on it. This is not good. + +2017-07-21 09:10:18: changed state open -> done diff --git a/web/htdocs/htmllib.py b/web/htdocs/htmllib.py index 735347c..5dd2275 100644 --- a/web/htdocs/htmllib.py +++ b/web/htdocs/htmllib.py @@ -2128,7 +2128,7 @@ class html(HTMLGenerator, RequestHandler): if is_context_button: self.begin_context_buttons() # TODO: Check all calls. If done before, remove this! - if not onclick: + if not onclick and not disabled: onclick = "view_toggle_form(this.parentNode, '%s');" % id if disabled: