Module: check_mk
Branch: master
Commit: 52a86e76c8cf73446dd45e079283d7f1dc4497ec
URL:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=52a86e76c8cf73…
Author: Sven Panne <sp(a)mathias-kettner.de>
Date: Thu Jul 26 15:00:51 2018 +0200
Classify a a few warnings.
Change-Id: I2ed23f54444a167b2068bc24999cbeb64ecc96f9
---
tests/pylint/pylintrc | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/tests/pylint/pylintrc b/tests/pylint/pylintrc
index 601d132..577a98c 100644
--- a/tests/pylint/pylintrc
+++ b/tests/pylint/pylintrc
@@ -23,11 +23,6 @@ disable=
reimported,
relative-import,
ungrouped-imports,
- unused-argument,
- unused-wildcard-import,
- wildcard-import,
- wrong-import-order,
- wrong-import-position,
#---------------------------------------------------------------------------
# We should really enable this, there could be some real exceptions waiting
# to be thrown. But some work is needed first to sprinkle abc annotations
@@ -83,15 +78,29 @@ disable=
# when fixing these warnings!
len-as-condition,
#---------------------------------------------------------------------------
+ # We should really find out where wildcard imports are just laziness or
+ # where they are actually needed (and why).
+ unused-wildcard-import,
+ wildcard-import,
+ #---------------------------------------------------------------------------
# Enabling this would be nice, but not crucial. At the moment, we have quite
# a few violations, so we postpone fixing this. When we do it eventually, we
# probably want to use "include-naming-hint=yes" in the BASIC section.
invalid-name,
#---------------------------------------------------------------------------
+ # Enable these would improve readability, but currently there are quite a
+ # few places to fix.
+ wrong-import-position,
+ wrong-import-order,
+ #---------------------------------------------------------------------------
# Enabling this would be nice, but not crucial. At the moment, we have quite
# a few violations, so we postpone fixing this.
singleton-comparison,
#---------------------------------------------------------------------------
+ # Enabling this would be nice, but not crucial. At the moment, we have quite
+ # a few violations, so we postpone fixing this.
+ unused-argument,
+ #---------------------------------------------------------------------------
# Alas, these maintenance/security nightmares are still part of our base
# "technology"... :-/ Nevertheless, reducing their usage is a very worthy
# goal.