[checkmk-commits] [Checkmk/checkmk] 871dec: omd update (1): rollback skeleton files

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 871decba654b392e080830e8ef1f81b9149dc961 https://github.com/Checkmk/checkmk/commit/871decba654b392e080830e8ef1f81b91… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: M omd/packages/omd/omdlib/main.py A omd/packages/omd/omdlib/update.py A tests/unit/omdlib/test_update.py Log Message: ----------- omd update (1): rollback skeleton files The command `omd update` must abort, if the pre-update checks fail. Different update steps depend on each other, so reordering these steps is not trivial. Instead we make it possible to rollback changes, which have been made before the pre-update checks. An additional benefit is that if the user cancels the update (using the `abort` option or CTRL-C), then the site can be in a consistent state. Note that failures after the pre-update checks are beyond the scope of the 2.3.0. These type of failures are not covered by the rollback mechanism. This change allows rollbacks of any change done by iterating over the skeleton files. CMK-15866 Change-Id: Ib06fef303c5faa2125d07d7cf5bedd8ac88d364b Commit: 589d42921f195594c55488fb111c208658b6f2a0 https://github.com/Checkmk/checkmk/commit/589d42921f195594c55488fb111c20865… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: M omd/packages/omd/omdlib/main.py M omd/packages/omd/omdlib/update.py Log Message: ----------- omd update (2): rollback version link The command `omd update` needs to abort, if the pre-update checks fail. Different update steps depend on one another, so reordering these steps is not trivial. Instead we make it possible to rollback changes, which have been done before the pre-update checks. An additional benefit is that if the user aborts his update (using the `abort` option or CTRL-C), then the site can be in a consistent state. Note that failures after the pre-update checks are beyond the scope of the 2.3.0. These type of failures are not covered by the rollback mechanism. This change allows rollbacks of changes to the version link. CMK-15866 Change-Id: Ia08f06e0895a239453906498cfed82fbcd7ec9ef Commit: a22ae1ac3acbb27d3da439b59c0b8735a652925f https://github.com/Checkmk/checkmk/commit/a22ae1ac3acbb27d3da439b59c0b8735a… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: M omd/packages/omd/omdlib/main.py Log Message: ----------- omd update (3): manage more update steps The command `omd update` must abort, if the pre-update checks fail. Different update steps depend on each other, so reordering these steps is not trivial. Instead we make it possible to rollback changes, which have been made before the pre-update checks. An additional benefit is that if the user cancels the update (using the `abort` option or CTRL-C), then the site can be in a consistent state. Note that failures after the pre-update checks are beyond the scope of the 2.3.0. These type of failures are not covered by the rollback mechanism. The rollback mechanism is extended to three more update steps. None of these need a rollback: * `save_version_meta_data` is unaffected by a failed execution and does not concern user data. * `site.load_config` and `load_defaults` are state free. This was verified by checking all hooks in 2.3.0. * `legacy_agent_ca` is incorrectly symlinked. The new symlink is appropriate for 2.2.0 and 2.3.0. CMK-15866 Change-Id: I91830caaaf7e90ee8b2ecacf080cfb3208c926ed Commit: 5f6d75569738ceee5ee1adbe07dd6ff8d35d046d https://github.com/Checkmk/checkmk/commit/5f6d75569738ceee5ee1adbe07dd6ff8d… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: M omd/packages/mk-livestatus/LIVESTATUS_TCP M omd/packages/pnp4nagios/PNP4NAGIOS Log Message: ----------- omd update: remove some mkdir calls from hooks This is covered by the corresponding skel files, and does not belong here. CMK-15866 Change-Id: I15ee6af90479406ac1c685c46e671720100b7418 Commit: 3613f8b9618488cbf99dd19226d33e1527e5096a https://github.com/Checkmk/checkmk/commit/3613f8b9618488cbf99dd19226d33e152… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: M omd/packages/omd/omdlib/main.py M omd/packages/omd/omdlib/update.py Log Message: ----------- omd update (4): rollback calls to config hooks The command `omd update` must abort, if the pre-update checks fail. Different update steps depend on each other, so reordering these steps is not trivial. Instead we make it possible to rollback changes, which have been made before the pre-update checks. An additional benefit is that if the user cancels the update (using the `abort` option or CTRL-C), then the site can be in a consistent state. Note that failures after the pre-update checks are beyond the scope of the 2.3.0. These type of failures are not covered by the rollback mechanism. This change allows rollbacks update actions executed by the config hooks. These bash scripts contain update actions specific to the omd package. This mechanism is maintained by hand in 2.3.0, but having an appropriate solution here is needed in the future. CMK-15866 Change-Id: Ib66b2548c5504efadb18d0514155442f508db088 Commit: 6ea4ef35c58993337f6133d9e34679b44ba3175b https://github.com/Checkmk/checkmk/commit/6ea4ef35c58993337f6133d9e34679b44… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: M omd/packages/omd/omdlib/main.py M omd/packages/omd/omdlib/tmpfs.py Log Message: ----------- omd: change `prepare_tmpfs` params Change-Id: Ic43d3726bc2d30876176083dd2ba011e29fc7160 Commit: 8ec0ca35857c5ab269af479b4bdba63320050339 https://github.com/Checkmk/checkmk/commit/8ec0ca35857c5ab269af479b4bdba6332… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: M omd/packages/omd/omdlib/main.py M omd/packages/omd/omdlib/skel_permissions.py M omd/packages/omd/omdlib/utils.py Log Message: ----------- omd: move `chown_tree` CMK-15866 Change-Id: Ib07a59ab6d58dda2bee5b0b86df33fde148d8163 Commit: e29d94389b87d0c9758a1818a4be012d8f0952ab https://github.com/Checkmk/checkmk/commit/e29d94389b87d0c9758a1818a4be012d8… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: M omd/packages/omd/omdlib/main.py M omd/packages/omd/omdlib/tmpfs.py Log Message: ----------- omd: move `prepare_and_populate_tmpfs` CMK-15866 Change-Id: I765eaa5683f746003e67c94a155f524a98a55705 Commit: 65b13821edef884494f9542daff1a33ccd75f057 https://github.com/Checkmk/checkmk/commit/65b13821edef884494f9542daff1a33cc… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: M omd/packages/omd/omdlib/main.py M omd/packages/omd/omdlib/tmpfs.py M omd/packages/omd/omdlib/update.py M tests/unit/omdlib/test_update.py Log Message: ----------- omd update(5): umount `tmpfs` on failure The command `omd update` must abort, if the pre-update checks fail. Different update steps depend on each other, so reordering these steps is not trivial. Instead we make it possible to rollback changes, which have been made before the pre-update checks. An additional benefit is that if the user cancels the update (using the `abort` option or CTRL-C), then the site can be in a consistent state. Note that failures after the pre-update checks are beyond the scope of the 2.3.0. These type of failures are not covered by the rollback mechanism. `tmpfs` is unmounted if `omd update` is called. This even applies if the customer does not commit to the update. The rollback needs to umount `tmpfs` if it has been repopulated based on the new version. CMK-15866 Change-Id: I3f2be64c3a277ab57a1d3c07d803a13763757868 Commit: e130eb6f707fc3bfc15e445f9ee0e5cd2d927417 https://github.com/Checkmk/checkmk/commit/e130eb6f707fc3bfc15e445f9ee0e5cd2… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: M cmk/update_config/main.py Log Message: ----------- cmk update: split check_config from main CMK-15866 Change-Id: Ibfe24c900ef70c3e2c5296d92b00f6b8891e51f0 Commit: d09b95af8b49494a9b83d6bc47f5f119205c5aff https://github.com/Checkmk/checkmk/commit/d09b95af8b49494a9b83d6bc47f5f1192… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: M cmk/update_config/main.py Log Message: ----------- cmk update: add dry run mode CMK-15866 Change-Id: I23e73d97d3071c353ffa7b102b890424ad4b5666 Commit: 7e978f6336b6fec9fc3a2d6c07c35fe2ab160d2f https://github.com/Checkmk/checkmk/commit/7e978f6336b6fec9fc3a2d6c07c35fe2a… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: M omd/packages/omd/omdlib/main.py Log Message: ----------- omd update(6): allow restoring after pre-update The command `omd update` must abort, if the pre-update checks fail. Different update steps depend on each other, so reordering these steps is not trivial. Instead we make it possible to rollback changes, which have been made before the pre-update checks. An additional benefit is that if the user cancels the update (using the `abort` option or CTRL-C), then the site can be in a consistent state. Note that failures after the pre-update checks are beyond the scope of the 2.3.0. These type of failures are not covered by the rollback mechanism. We allow to rollback changes after a pre-update fails. CMK-15866 Change-Id: I4bd984afbc7fc6f7dfa45ae01b40664da3a3c3b5 Commit: 09e22e47e90a31654a359d627ac430e5c7ee6e1b https://github.com/Checkmk/checkmk/commit/09e22e47e90a31654a359d627ac430e5c… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: M cmk/update_config/main.py M cmk/update_config/plugins/pre_actions/rulesets.py Log Message: ----------- cmk update: don't suggest downgrade CMK-15866 Change-Id: Iedc365ad72bf20a557a3b2882e2b7dd0d45d3163 Compare: https://github.com/Checkmk/checkmk/compare/84f9063f1887...09e22e47e90a To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications