9 Apr
2024
9 Apr
'24
6:45 a.m.
Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: d7061b22d903770c44842a93ff00665e06ee8674
https://github.com/Checkmk/checkmk/commit/d7061b22d903770c44842a93ff00665e0…
Author: Moritz Kiemer <moritz.kiemer(a)checkmk.com>
Date: 2024-04-09 (Tue, 09 Apr 2024)
Changed paths:
M tests/unit/cmk/base/test_server_side_calls.py
Log Message:
-----------
temporarily disable test
Change-Id: Ic7fd14be667cf12546ad08afb4d487878e91bd3b
Commit: 922a1e879927b9e43a92351d141dc89da306e8e3
https://github.com/Checkmk/checkmk/commit/922a1e879927b9e43a92351d141dc89da…
Author: Moritz Kiemer <moritz.kiemer(a)checkmk.com>
Date: 2024-04-09 (Tue, 09 Apr 2024)
Changed paths:
R cmk/base/legacy_checks/check_tcp.py
A cmk/plugins/tcp/server_side_calls/check_tcp.py
R tests/unit/checks/test_check_tcp.py
A tests/unit/cmk/plugins/tcp/server_side_calls/test_check_tcp.py
Log Message:
-----------
PRO TIP: migrate check_tcp (1/2)
This change migrates the server side call (SSC) plugin of `check_tcp`
to the new API.
Note that you should always migrate both plugins at the same time,
to avoid incompatibilities (although sometimes you might not *have*
to).
In this change we only migrate the SSC plugin, to provide a better
overview.
Lets go through these changes one by one, starting at the top:
* File location: SSC plugins live in the folder
`cmk/plugins/<family>/server_side_calls/`.
The family is used to group plugins together that
are related to each other (for whatever reason).
* Required objects are imported with an absolute import
from the corresponding API. The API name is matching
the subfolder in the file location.
In `_make_service_description`:
* This function no longer has a special place in the API.
We happen to still call it from
`make_check_tcp_commands`, but we could refactor.
* The configured service description is processed using
the helper function `replace_macros`.
Without calling it, macros like "$HOSTNAME$" will no
longer be replaced.
In `make_check_tcp_commands`:
* This is the function that is used to create the instance
of the "ActiveCheckConfig" below.
* Note that this function is now called with the already
created `Parameters` instance.
We always get what the "parameter_parser" below returns.
* The second argument it the hosts configuration.
This argument replaces a lot of functions of the old API.
* Instead oh resorting to the "$HOSTNAME$" macro, we can
access the host configration, and directly use the hosts
primary IP address: `host_config.primary_ip_config.address`.
This will raise an exception in case the host does not
have an IP address at all.
* Yielding `ActiveCheckCommand`: This creates the service.
In the new API, you can create multiple services with one
configured rule. Most plugins, like this one, only create
one service.
Every service consist of a service description, and its
commandline arguments.
* Instanciating the `ActiveCheckConfig` object:
This creates the object that is picked up by the backend.
For it to be found its variable name MUST be prefixed with
"active_check_".
Change-Id: I686dbfd91b2ccceddebc5b7a0382636e9592da61
Commit: 4b3bd78f013a86cf8da710ec42ef1fc7eee06ba8
https://github.com/Checkmk/checkmk/commit/4b3bd78f013a86cf8da710ec42ef1fc7e…
Author: Moritz Kiemer <moritz.kiemer(a)checkmk.com>
Date: 2024-04-09 (Tue, 09 Apr 2024)
Changed paths:
R cmk/gui/plugins/wato/active_checks/tcp.py
A cmk/plugins/tcp/rulesets/active_check_tcp.py
M cmk/plugins/tcp/server_side_calls/check_tcp.py
M tests/unit/cmk/plugins/tcp/server_side_calls/test_check_tcp.py
Log Message:
-----------
PRO TIP: migrate check_tcp (2/2)
This change migrates the ruleset plugin of `check_tcp` to the
new API.
Note that you should always migrate both plugins at the same time,
to avoid incompatibilities (although sometimes you might not *have*
to).
In this change we only migrate the ruleset plugin, to provide a better
overview.
Lets go through these changes one by one, starting at the top of
`cmk/plugins/tcp/rulesets/active_check_tcp.py`:
* File location: Ruleset plugins live in the folder
`cmk/plugins/<family>/rulesets/`.
The family is used to group plugins together that
are related to each other (for whatever reason).
* Required objects are imported with an absolute import
from the corresponding API. The API name is matching
the subfolder in the file location.
* `_migrate_to_float`: The `TimeSpan` form spec stores
values as float, so we need to convert the previously
stored value from int to float.
Migration functions have to accept `object` as their
input argument, so that developers have to deal with
any nonsense a former configuration may provide
explicitly.
* `_make_parameter_form`: This function should return
the composed form spec. In many cases it MUST be a
`Dictionary`. You can find out in the docs.
* Instead of using the `_` function for localization,
We now have `Title`, `Help` and `Label`.
* The `elements` of the dictionary is a python builtin
dictionary. The keys are strings representing valid
python identifiers, the values are `DictElements`.
* `DictElement` is a wrapper for the nested form spec
and some meta information. In this case the first
element (the port) is required, all others are
optional (which is the default).
* `"port"`: The port is now specified using an `Integer`
form spec. We limit the choices to valid port numbers
by passing the custom validator `NetworkPort`.
Passing the validators as sequence of callables allowes
you to apply multiple validators, including custom
ones.
* `"response_time"`: The API no longer provides `Tuple`.
In most cases (like this) you can replace tuples by
the `(Simple)Levels` form spec.
In this case, we are using the `TimeSpan` form spec in
it, which stores the time in seconds, as a float.
The `(Simple)Levels` then wrap it in another data structure.
We must migrate the old configurations accordingly,
and adjust the consumer (`server_site_calls/check_tcp.py`).
* `InputHint` / `DefaultValue`: Many form specs require some
kind of `prefill` argument. This can be either an
`InputHint` or a `DefaultValue`. The latter will be part
of the stored configuration if the user does not change it.
* `"send_string"`: The approximate size of the `String` form
spec can be provided using the `field_size` argument.
A former value of 30 corresponds to `FieldSize.MEDIUM`,
which is the default, hence we ommit it here.
* Last paragraph: The actual `ActiveCheck` ruleset plugin is
instanciated.
This creates the object that is picked up by the backend.
For it to be found its variable name MUST be prefixed with
"rule_spec_".
Change-Id: I31c909ce5bea3b4138d8b73b9aec6f79c07389ee
Commit: 1b1b88368f651a6cdf02f04fa7a085a35b02460a
https://github.com/Checkmk/checkmk/commit/1b1b88368f651a6cdf02f04fa7a085a35…
Author: Alex Zurhake <alex.zurhake(a)checkmk.com>
Date: 2024-04-09 (Tue, 09 Apr 2024)
Changed paths:
M .bazelversion
Log Message:
-----------
Update bazel to 7.1.1
Change-Id: Iaa782b3e9ff0957117024705ef54e226d68c27df
Commit: 132fa033b04a0c9af6ee6e736ee4ab412853eeb4
https://github.com/Checkmk/checkmk/commit/132fa033b04a0c9af6ee6e736ee4ab412…
Author: Alex Zurhake <alex.zurhake(a)checkmk.com>
Date: 2024-04-09 (Tue, 09 Apr 2024)
Changed paths:
M omd/packages/perl-modules/BUILD
M omd/packages/perl-modules/perl-modules.make
Log Message:
-----------
Archive perl output to avoid 'dependency checking of directories is unsound'
Change-Id: I7f94eafb64d09880d393f6dd7af4e531f572b2eb
Commit: c7b59ca182d6d24f53a5fef2d5d3e55983fd6cf5
https://github.com/Checkmk/checkmk/commit/c7b59ca182d6d24f53a5fef2d5d3e5598…
Author: Timotheus Bachinger <timotheus.bachinger(a)checkmk.com>
Date: 2024-04-09 (Tue, 09 Apr 2024)
Changed paths:
R buildscripts/scripts/test-agent-controller.groovy
R buildscripts/scripts/test-cmc.groovy
R buildscripts/scripts/test-livestatus.groovy
R buildscripts/scripts/test-mk-sql.groovy
R buildscripts/scripts/test-neb.groovy
R buildscripts/scripts/test-package-check-cert.groovy
R buildscripts/scripts/test-package-check-http.groovy
R buildscripts/scripts/test-package-cmc.groovy
R buildscripts/scripts/test-package-cmk-agent-based.groovy
R buildscripts/scripts/test-package-cmk-agent-ctl.groovy
R buildscripts/scripts/test-package-cmk-agent-receiver.groovy
R buildscripts/scripts/test-package-cmk-graphing.groovy
R buildscripts/scripts/test-package-cmk-livestatus-client.groovy
R buildscripts/scripts/test-package-cmk-mkp-tool.groovy
R buildscripts/scripts/test-package-cmk-rulesets.groovy
R buildscripts/scripts/test-package-cmk-server-side-calls.groovy
R buildscripts/scripts/test-package-cmk-werks.groovy
R buildscripts/scripts/test-package-frontend_vue.groovy
R buildscripts/scripts/test-package-livestatus.groovy
R buildscripts/scripts/test-package-mk-sql.groovy
R buildscripts/scripts/test-package-neb.groovy
R buildscripts/scripts/test-package-unixcat.groovy
R buildscripts/scripts/test-werks-package.groovy
Log Message:
-----------
Purge now superfluous groovy files
... that things are now run in the generic job
Change-Id: Ia94efde73b70f51a9eefcc2fec0563c651394c79
Commit: 2651dfcbbba5c69c7997631dae177c8cf94fc667
https://github.com/Checkmk/checkmk/commit/2651dfcbbba5c69c7997631dae177c8cf…
Author: Ronny Bruska <ronny.bruska(a)checkmk.com>
Date: 2024-04-09 (Tue, 09 Apr 2024)
Changed paths:
M cmk/gui/watolib/rulesets.py
Log Message:
-----------
Fix folder from request on rule matching
CMK-16837
Change-Id: I949c8ed8a73d93ec26f7840404ffaf788ceca06e
Commit: 15cd7c75f4dcb5d49cded39bf421933ae76c540c
https://github.com/Checkmk/checkmk/commit/15cd7c75f4dcb5d49cded39bf421933ae…
Author: Lars Michelsen <lm(a)checkmk.com>
Date: 2024-04-09 (Tue, 09 Apr 2024)
Changed paths:
M cmk/gui/wato/pages/custom_attributes.py
Log Message:
-----------
Inline _default_topic method
Change-Id: I5ff8e0b8bced73558f29148fd61a15884d81ba74
Compare: https://github.com/Checkmk/checkmk/compare/ba00d83fdebe...15cd7c75f4dc
To unsubscribe from these emails, change your notification settings at
https://github.com/Checkmk/checkmk/settings/notifications