30 May
2023
30 May
'23
10:42 a.m.
Branch: refs/heads/2.2.0
Home: https://github.com/Checkmk/checkmk
Commit: cee56c6448215636d16802cc0348776ae8ff3c7a
https://github.com/Checkmk/checkmk/commit/cee56c6448215636d16802cc0348776ae…
Author: Joerg Herbel <joerg.herbel(a)checkmk.com>
Date: 2023-05-30 (Tue, 30 May 2023)
Changed paths:
M cmk/utils/prediction.py
M tests/unit/cmk/utils/test_prediction_commons.py
Log Message:
-----------
Implement TimeSeries.count
This is needed in order to apply our time series operators to TimeSeries
instances.
CMK-13561
Change-Id: I0cc32ee5984fa5bcc70fb8833933086465e3b8c4
Commit: 8efacb7ebbbd57d37b3f09be79892086f6ba4be5
https://github.com/Checkmk/checkmk/commit/8efacb7ebbbd57d37b3f09be79892086f…
Author: Joerg Herbel <joerg.herbel(a)checkmk.com>
Date: 2023-05-30 (Tue, 30 May 2023)
Changed paths:
M cmk/gui/plugins/metrics/rrd_fetch.py
M cmk/gui/views/data_source/livestatus.py
M cmk/gui/views/painter/v0/base.py
Log Message:
-----------
Add common base class for historic and forecast painters for metrics
This allows for typing the shared functionality.
CMK-13561
Change-Id: I504f3def08d6abbc98a73d310eaf3a6916d410a0
Commit: d50a4166c8c393f0c3b270d1de556cd36d902c8a
https://github.com/Checkmk/checkmk/commit/d50a4166c8c393f0c3b270d1de556cd36…
Author: Joerg Herbel <joerg.herbel(a)checkmk.com>
Date: 2023-05-30 (Tue, 30 May 2023)
Changed paths:
M cmk/gui/plugins/metrics/rrd_fetch.py
M cmk/gui/plugins/metrics/utils.py
M tests/unit/cmk/gui/plugins/metrics/test_metrics_utils.py
M tests/unit/cmk/gui/plugins/metrics/test_rrd_fetch.py
Log Message:
-----------
Re-work functionality for handling rrd data relevant for a single metric
The current implementation is conceptually wrong: Currently, we scale
the rrd data right when fetching it via livestatus. This is wrong
because we can only know if we should apply any scalings in the context
of a service (since our metric translations are check-plugin specific).
Example: Let's say we want historic values for the metric mem_total.
Outside the service context, we cannot know whether or not we should
scale this metric by 1024**2 (Windows: yes, Linux: no).
This issue affects certain painters and the single-metric dashlets.
(though most of the latter, namely the ones where the host and service
are fixed, could be re-implemented to completely avoid this issue, which
is however outside the scope of this change). Note that eg. service
graphs are not affected, because we are in the context of a service when
rendering them.
This change leads to some duplicated code, however, this simplifies the
review. In the following commit, we will switch from the old to the new
functionality and then remove the old code.
CMK-13561
Change-Id: I0e177242d58c4d39e268db37c4c42df37bfec9a9
Commit: dff821f32a1f75ad6b3f5aefaff65849c425d816
https://github.com/Checkmk/checkmk/commit/dff821f32a1f75ad6b3f5aefaff65849c…
Author: Joerg Herbel <joerg.herbel(a)checkmk.com>
Date: 2023-05-30 (Tue, 30 May 2023)
Changed paths:
A .werks/15854
Log Message:
-----------
15854 FIX Fix metric scaling issues in views and dashboards
CMK-13555
CMK-13561
Change-Id: I12e04ceec103b6d2c3b06c447ec0a5cffdae7be9
Commit: 254a3db36028d578f37c28982abbaf54e15eac53
https://github.com/Checkmk/checkmk/commit/254a3db36028d578f37c28982abbaf54e…
Author: Joerg Herbel <joerg.herbel(a)checkmk.com>
Date: 2023-05-30 (Tue, 30 May 2023)
Changed paths:
M cmk/gui/plugins/metrics/rrd_fetch.py
M cmk/gui/plugins/metrics/utils.py
M tests/unit/cmk/gui/plugins/metrics/test_metrics_utils.py
M tests/unit/cmk/gui/plugins/metrics/test_rrd_fetch.py
Log Message:
-----------
Remove now unused code
Change-Id: Id9670ca97b3408ee137eeda94398b63f17e5b2e1
Compare: https://github.com/Checkmk/checkmk/compare/e94c30aa8760...254a3db36028