25 Jul
2019
25 Jul
'19
9 a.m.
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 8707a4355c25a41821c53a9f2f028c680c836f22
https://github.com/tribe29/checkmk/commit/8707a4355c25a41821c53a9f2f028c680…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-07-25 (Thu, 25 Jul 2019)
Changed paths:
M cmk_base/autochecks.py
M tests/testlib/base.py
M tests/unit/cmk_base/test_autochecks.py
Log Message:
-----------
Fix AutochecksManager.discovered_labels_of
Skip computing unused effective check parameters for autochecks
in discovered_labels_of().
discovered_labels_of called _read_autochecks which was computing
the effective check parameter of all autochecks. To do this it is
necessary to process service rulesets which all could use service
label conditions. This ended up in an endless recursion.
To fix this _read_autochecks_of has now been split into two steps.
The raw autochecks produced by the first step are enough for
discovered_labels_of.
CMK-2402
Change-Id: I283caadac9b9642c140ebba5b7a9990b31c82a6d
Commit: 8f8dc87c564a5f8c9fe9b23dff948e38ae1b27fd
https://github.com/tribe29/checkmk/commit/8f8dc87c564a5f8c9fe9b23dff948e38a…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-07-25 (Thu, 25 Jul 2019)
Changed paths:
M cmk/utils/rulesets/ruleset_matcher.py
M cmk_base/config.py
M tests/unit/cmk/utils/rulesets/test_ruleset_matcher.py
M tests/unit/cmk_base/test_config.py
Log Message:
-----------
Service labels can now be used as service rule conditions
The matching logic is equal to the host label matching.
CMK-2402
Change-Id: Idb4d88e29a65e9b41d3b7cad10a176aeafe7c209
Commit: f70e566715af195d1dcbf017c201827428724ec9
https://github.com/tribe29/checkmk/commit/f70e566715af195d1dcbf017c20182742…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-07-25 (Thu, 25 Jul 2019)
Changed paths:
M cmk/gui/wato/pages/rulesets.py
M cmk/gui/watolib/rulesets.py
M cmk/utils/labels.py
Log Message:
-----------
Add service label matching to WATO GUI
The service labels can now be configured as conditions, just like the
host labels.
The rule matching analysis, which is implemented in
watolib.rulesets.Rule._get_mismatch_reasons_of_match_object is not
working yet will be fixed in one of the next commits.
CMK-2402
Change-Id: If283ed2a96ebe767946f6ae22d877cd0f50a5c64
Commit: b0110b551f52b620426de083e261ad4beec95885
https://github.com/tribe29/checkmk/commit/b0110b551f52b620426de083e261ad4be…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-07-25 (Thu, 25 Jul 2019)
Changed paths:
M cmk/gui/watolib/rulesets.py
M cmk/utils/rulesets/ruleset_matcher.py
M cmk_base/config.py
M tests/unit/cmk_base/test_config.py
Log Message:
-----------
Remove unused host attributes from RuleMatchObject
The host attributes (folder, labels, tags) are not used during matching
phase of the rule processing. They are already resolved by the ruleset
optimizer to a list of matching host names. For this reason the match
object only needs the host_name attribute for matching the host
conditions.
CMK-2402
Change-Id: Ib73a33fffeae894c8348f40a7934adc5d5517bbd
Commit: 304aa718a8b0e496267870be7ba5381b819a4cd1
https://github.com/tribe29/checkmk/commit/304aa718a8b0e496267870be7ba5381b8…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-07-25 (Thu, 25 Jul 2019)
Changed paths:
M cmk_base/autochecks.py
Log Message:
-----------
Cache labels of read autochecks for later use
CMK-2402
Change-Id: I06db8ff641ce026667eebc95b21a4e50d9b7356a
Commit: 15f4737b4aded62f05d433f549e0ba42ba2df299
https://github.com/tribe29/checkmk/commit/15f4737b4aded62f05d433f549e0ba42b…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-07-25 (Thu, 25 Jul 2019)
Changed paths:
M cmk/gui/watolib/rulesets.py
M cmk/utils/labels.py
A cmk_base/export.py
Log Message:
-----------
Make ruleset match analysis in WATO work - step 1
This is not possible without loading the whole Checkmk base
configuration to get the rulesets, labels and so on.
Using an automation, as we normally do would be a performance overkill.
The component cmk_base now has one module cmk_base.export which exposes
some functionality for other components, like the GUI. This is the same
approach as we use in cmk.ec.export.
We need some more steps to make the analysis really work, like
transporting the service description through several pages of WATO
instead of just the item.
CMK-2402
Change-Id: Iee59a6a3896f4080e227e365b0feaf00ac1da8a2
Commit: cb6090a8463d82291abfd6a8ad17f29b01921849
https://github.com/tribe29/checkmk/commit/cb6090a8463d82291abfd6a8ad17f29b0…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-07-25 (Thu, 25 Jul 2019)
Changed paths:
M cmk/gui/wato/pages/object_parameters.py
M cmk/gui/wato/pages/rulesets.py
M cmk/gui/wato/pages/services.py
M cmk/gui/watolib/rulesets.py
M cmk_base/config.py
M cmk_base/export.py
Log Message:
-----------
Make ruleset match analysis in WATO work - step 2
Care about special case of matching on checkgroup parameter rulesets.
These rulesets do not use the whole service_description as condition,
but only the check item name.
This was working transparently until we need the real service description to
gather the labels of a services for matching on rules that use service labels
as conditions. To make this work we now use a specific helper function
cmk_base.config.ruleset_match_object_for_checkgroup_parameters() to get a
ruleset match object that uses the item as service_description and the real
service_description to get service attributes like the service labels.
CMK-2402
Change-Id: I4ab5dea31ffb9b25783d929d9de281aaa6a751e0
Commit: a78fd5ad24454daaf570bcfd91863048e32fea0a
https://github.com/tribe29/checkmk/commit/a78fd5ad24454daaf570bcfd91863048e…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-07-25 (Thu, 25 Jul 2019)
Changed paths:
M cmk/gui/wato/pages/object_parameters.py
M cmk/gui/wato/pages/pattern_editor.py
M cmk/gui/wato/pages/rulesets.py
M cmk/gui/wato/pages/services.py
M cmk/gui/watolib/rulesets.py
M cmk_base/config.py
M cmk_base/export.py
Log Message:
-----------
Make ruleset match analysis in WATO work - step 3
Transport the real service description together with the check item
through several WATO pages to make both available to the rule analysis
logic of WATO.
With this step the rule analysis is now working again.
CMK-2402
Change-Id: Ie001f93c02a121f96b481144566eb7b6d4de3cb1
Commit: 53f483da2604f0fd20eecb88710b69157add571e
https://github.com/tribe29/checkmk/commit/53f483da2604f0fd20eecb88710b69157…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-07-25 (Thu, 25 Jul 2019)
Changed paths:
M cmk/gui/wato/pages/pattern_editor.py
M cmk/gui/watolib/rulesets.py
Log Message:
-----------
Remove odd logwatch pattern test: Logfile matching, but no host name given
Change-Id: I9aeaa558ea2f95aefcaa6971780fefff632bb898
Commit: 11cfcd2907df223c1c27983919b163c0e9bfcf4a
https://github.com/tribe29/checkmk/commit/11cfcd2907df223c1c27983919b163c0e…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-07-25 (Thu, 25 Jul 2019)
Changed paths:
A .werks/7965
M cmk/gui/wato/pages/tags.py
Log Message:
-----------
7965 FIX Fix updating hosts after editing tags
When adding new tag groups or aux tags to existing tag choices, these
tags were not immediately applied to the host configuration. The tags
were applied to the hosts only after editing the host configuration.
Change-Id: I2caa6f1d3772c6dd36d014f671f5c54b3e73ad2a
Commit: 63e63a03017a22b9d1ea5b69fbfb55f6f4d9d5c4
https://github.com/tribe29/checkmk/commit/63e63a03017a22b9d1ea5b69fbfb55f6f…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-07-25 (Thu, 25 Jul 2019)
Changed paths:
M cmk/gui/wato/pages/tags.py
M cmk/utils/tags.py
M tests/unit/cmk/utils/test_utils_tags.py
Log Message:
-----------
Cleanup: Module import violation and naming of tag group ID
* Remove cmk.gui import from cmk.utils.tags module. Importing a module
of the cmk.gui component is not allowed from cmk.utils.
* Improved naming of the tag group ID input field title
Change-Id: I7fd24fb6359a16e7f538ee22fcae3fe7f49d7a29
Commit: a95692a6f0a771a195c6582aaa39fbfba0ef4043
https://github.com/tribe29/checkmk/commit/a95692a6f0a771a195c6582aaa39fbfba…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-07-25 (Thu, 25 Jul 2019)
Changed paths:
A .werks/7986
Log Message:
-----------
7986 Service labels can be used as rule conditions
The service labels, that are introduced with Checkmk 1.6 can now be used as
conditions in service rulesets (Host & Service Parameters). These conditions
can be configured like the host labels.
The labels can not be used in the rulesets "Service labels", because that
could result in a hen egg problem.
Change-Id: If233dd91b5bdbc20484fcb62df0c2c068b75eff2
Compare: https://github.com/tribe29/checkmk/compare/bf02a00bbcec...a95692a6f0a7