28 Aug
2014
28 Aug
'14
10:12 a.m.
indentation error and oid to determine the interface state fixed
Message-ID: <53ff46f0.7+QXvjep19y393Q6%gg(a)mathias-kettner.de>
User-Agent: Heirloom mailx 12.4 7/29/08
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Module: check_mk
Branch: master
Commit: bd3d2e635c5ca57f9039771666e3d547f92b2804
URL:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=bd3d2e635c5ca5…
Author: Goetz Golla <gg(a)mathias-kettner.de>
Date: Thu Aug 28 17:12:39 2014 +0200
#0651 FIX f5_bigip_interfaces: indentation error and oid to determine the interface state
fixed
A major indentation errors has lead to interface throuputs identical for all ifs.
The oid for the determination of the if state was wrong
Both errors have been fixed.
Also the scan function was extended to detect more and newer f5 devices
---
.werks/651 | 15 +++++++++++++++
ChangeLog | 1 +
checks/f5_bigip_interfaces | 40 +++++++++++++++++++++-------------------
3 files changed, 37 insertions(+), 19 deletions(-)
diff --git a/.werks/651 b/.werks/651
new file mode 100644
index 0000000..7325efb
--- /dev/null
+++ b/.werks/651
@@ -0,0 +1,15 @@
+Title: f5_bigip_interfaces: indentation error and oid to determine the interface state
fixed
+Level: 1
+Component: checks
+Compatible: compat
+Version: 1.2.5i6
+Date: 1409238534
+Class: fix
+
+A major indentation errors has lead to interface throuputs identical for all ifs.
+The oid for the determination of the if state was wrong
+
+Both errors have been fixed.
+
+Also the scan function was extended to detect more and newer f5 devices
+
diff --git a/ChangeLog b/ChangeLog
index 5843001..88e2313 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -65,6 +65,7 @@
NOTE: Please refer to the migration notes!
* 1102 FIX: esx_vsphere_counters: no longer raise false alarms because of invalid
data from ESX Host...
* 1149 FIX: check_mk-ibm_svc_systemstats.diskio, check_mk-ibm_svc_systemstats.iops:
fix exception in Perf-O-Meter
+ * 0651 FIX: f5_bigip_interfaces: indentation error and oid to determine the interface
state fixed...
Multisite:
* 1066 Implemented Dashboard Designer...
diff --git a/checks/f5_bigip_interfaces b/checks/f5_bigip_interfaces
index 1cbec71..13025d5 100644
--- a/checks/f5_bigip_interfaces
+++ b/checks/f5_bigip_interfaces
@@ -25,7 +25,7 @@
# Boston, MA 02110-1301 USA.
# .1.3.6.1.4.1.3375.2.1.2.4.4.3.1.1. index for ifname
-# .1.3.6.1.4.1.3375.2.1.2.4.4.3.1.13. index for ifstate
+# .1.3.6.1.4.1.3375.2.1.2.4.1.2.1.17. index for ifstate
# .1.3.6.1.4.1.3375.2.1.2.4.4.3.1.3. index for OUT bytes
# .1.3.6.1.4.1.3375.2.1.2.4.4.3.1.5. index for IN bytes
@@ -34,25 +34,26 @@ def check_f5_bigip_interfaces(item, params, info):
if item == port:
if int(ifstate) != 0:
states = {
- 2 : "down (has no link and is initialized)",
- 3 : "disabled has been forced down)",
- 4 : "uninitialized (has not been initialized)",
- 5 : "loopback (in loopback mode)",
- 6 : "unpopulated (interface not physically populated)",
+ 1 : "down (has no link and is initialized)",
+ 2 : "disabled has been forced down)",
+ 3 : "uninitialized (has not been initialized)",
+ 4 : "loopback (in loopback mode)",
+ 5 : "unpopulated (interface not physically populated)",
}
- return(2, "State of %s is %s" % (states[ifstate], port))
- this_time = int(time.time())
- in_timedif, in_per_sec = get_counter("f5.interface.in.%s" % item,
this_time, saveint(inbytes))
- out_timedif, out_per_sec = get_counter("f5_interface.out.%s" % item,
this_time, saveint(outbytes))
+ return(2, "State of %s is %s" %
(states.get(ifstate,"unkown"), port))
+ this_time = int(time.time())
+ in_timedif, in_per_sec = get_counter("f5.interface.in.%s" % item,
this_time, saveint(inbytes))
+ out_timedif, out_per_sec = get_counter("f5_interface.out.%s" %
item, this_time, saveint(outbytes))
- inbytes_h = get_bytes_human_readable(in_per_sec)
- outbytes_h = get_bytes_human_readable(out_per_sec)
- perf = [
- ("bytes_in", in_per_sec),
- ("bytes_out", out_per_sec),
- ]
- return (0, "in bytes: %s/s, out bytes: %s/s" % (inbytes_h, outbytes_h),
perf)
+ inbytes_h = get_bytes_human_readable(in_per_sec)
+ outbytes_h = get_bytes_human_readable(out_per_sec)
+ perf = [
+ ("bytes_in", in_per_sec),
+ ("bytes_out", out_per_sec),
+ ]
+ return (0, "in bytes: %s/s, out bytes: %s/s" % (inbytes_h,
outbytes_h), perf)
+ return 3, "no such interface found in snmp data"
check_info["f5_bigip_interfaces"] = {
@@ -60,6 +61,7 @@ check_info["f5_bigip_interfaces"] = {
"inventory_function" : lambda info: [ (x[0], {'state': 0 } ) for
x in info if int(x[1]) == 0],
"service_description" : "f5 Interface %s",
"has_perfdata" : True,
- "snmp_scan_function" : lambda oid:
".1.3.6.1.4.1.3375.2.1.3.4.20" in oid(".1.3.6.1.2.1.1.2.0"),
- "snmp_info" : ( ".1.3.6.1.4.1.3375.2.1.2.4.4.3.1",
[1, 13, 3, 5]),
+ "snmp_scan_function" : lambda oid: oid(".1.3.6.1.2.1.1.2.0")
in \
+ [ ".1.3.6.1.4.1.3375.2.1.3.4.10",
".1.3.6.1.4.1.3375.2.1.3.4.20" ],
+ "snmp_info" : ( ".1.3.6.1.4.1.3375.2.1.2.4",
["4.3.1.1", "1.2.1.17", "4.3.1.3", "4.3.1.5"]),
}