[checkmk-commits] [tribe29/checkmk] 5ecbc3: Fix type of FileUpload content

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 5ecbc380b3f517e2b37303a10c9296b6c4a230ba https://github.com/tribe29/checkmk/commit/5ecbc380b3f517e2b37303a10c9296b6c… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2021-01-29 (Fri, 29 Jan 2021) Changed paths: M cmk/gui/valuespec.py Log Message: ----------- Fix type of FileUpload content The class was wrongly using `str` instead of `bytes`, where it was *really* handling bytes. We also fully type the class as well as the `ImageUpload` class. This means using the `UploadedFile` type defined in `cmk.gui.http`. This mostly comes from the Python 3 migration. CMK-6995 Change-Id: I5cd28acc1581a8d5cbeafc6f5045472a31a362e2 Commit: 387933e884666b280d993d4f1e7310354e51d566 https://github.com/tribe29/checkmk/commit/387933e884666b280d993d4f1e7310354… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2021-01-29 (Fri, 29 Jan 2021) Changed paths: M cmk/gui/valuespec.py Log Message: ----------- Fix uploading bytes where text is expected Before, the GUI would generate a huge crash report containing *the whole file* as bytes repr. Twice. Now, we display a decent error message to the user instead. Change-Id: Ia01d439c149607d3e2d704b6e7b0031a90de86f9 Compare: https://github.com/tribe29/checkmk/compare/524a4138ea58...387933e88466