[checkmk-commits] Refactored snapin groups to new snapin API

Module: check_mk Branch: master Commit: 5db5b3d477dfd313eb298e9276b66eb2f1d7801c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5db5b3d477dfd3… Author: Kenneth Okoh <ko(a)mathias-kettner.de> Date: Thu Nov 8 14:11:51 2018 +0100 Refactored snapin groups to new snapin API Change-Id: Icd13bac88169d0183f72864d399e4dda16b66216 --- cmk/gui/plugins/sidebar/groups.py | 81 ++++++++++++++++++++++++++++----------- 1 file changed, 58 insertions(+), 23 deletions(-) diff --git a/cmk/gui/plugins/sidebar/groups.py b/cmk/gui/plugins/sidebar/groups.py index 190cc54..e00446b 100644 --- a/cmk/gui/plugins/sidebar/groups.py +++ b/cmk/gui/plugins/sidebar/groups.py @@ -24,30 +24,65 @@ # to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, # Boston, MA 02110-1301 USA. +import abc import cmk.gui.sites as sites +from cmk.gui.plugins.sidebar import ( + SidebarSnapin, + snapin_registry, + bulletlink +) from cmk.gui.i18n import _ from cmk.gui.globals import html -from cmk.gui.plugins.sidebar import sidebar_snapins, bulletlink - -def render_groups(what): - html.open_ul() - for name, alias in sites.all_groups(what): - url = "view.py?view_name=%sgroup&%sgroup=%s" % (what, what, html.urlencode(name)) - bulletlink(alias or name, url) - html.close_ul() - -sidebar_snapins["hostgroups"] = { - "title" : _("Host Groups"), - "description" : _("Directs links to all host groups"), - "render" : lambda: render_groups("host"), - "restart": True, - "allowed" : [ "user", "admin", "guest" ] -} -sidebar_snapins["servicegroups"] = { - "title" : _("Service Groups"), - "description" : _("Direct links to all service groups"), - "render" : lambda: render_groups("service"), - "restart": True, - "allowed" : [ "user", "admin", "guest" ] -} +class GroupSnapin(SidebarSnapin): + __metaclass__ = abc.ABCMeta + + @abc.abstractmethod + def _group_type_ident(self): + raise NotImplementedError() + + def show(self): + group_type = self._group_type_ident() + html.open_ul() + for name, alias in sites.all_groups(group_type.replace("group", "")): + url = "view.py?view_name=%s&%s=%s" % (group_type, group_type, html.urlencode(name)) + bulletlink(alias or name, url) + html.close_ul() + + @classmethod + def refresh_on_restart(cls): + return True + +(a)snapin_registry.register +class HostGroups(GroupSnapin): + def _group_type_ident(self): + return "hostgroup" + + @staticmethod + def type_name(): + return "hostgroups" + + @classmethod + def title(cls): + return _("Host Groups") + + @classmethod + def description(cls): + return _("Directs links to all host groups") + +(a)snapin_registry.register +class ServiceGroups(GroupSnapin): + def _group_type_ident(self): + return "servicegroup" + + @staticmethod + def type_name(): + return "servicegroups" + + @classmethod + def title(cls): + return _("Service Groups") + + @classmethod + def description(cls): + return _("Direct links to all service groups")