[checkmk-commits] Improved bulk edit description

Module: check_mk Branch: master Commit: a23c9f10d80354b8abb4ec6be7e289138ef0f37c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a23c9f10d80354… Author: Lars Michelsen &lt;lm(a)mathias-kettner.de&gt; Date: Thu Feb 16 17:42:02 2017 +0100 Improved bulk edit description Change-Id: I78e4aad77a951dc6fe3d12501791e06d7db76a89 --- .bugs/2520 | 9 +++++++-- web/htdocs/wato.py | 13 ++++++++----- 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/.bugs/2520 b/.bugs/2520 index 15adeba..521ffb5 100644 --- a/.bugs/2520 +++ b/.bugs/2520 @@ -10,5 +10,10 @@ it will be not removed. The host tag is stiull assigned to the hosts. Inheritance of folder host tags does not work if you try to remove the host tags. -Workaround: -Please edit single hosts and remove the wrong host tag. This will remove the host tag from the host. +---- + +It is working as expected. What you need to know is that the "bulk edit" +dialog can not be used for removing set attributes. You need to use +the dialog "bulk cleanup" to remove attributes from hosts in bulk. + +I improved the description on top of the bulk edit page. diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index cce72d4..9783755 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -4220,11 +4220,14 @@ def mode_bulk_edit(phase): html.del_all_vars(prefix="attr_") html.del_all_vars(prefix="bulk_change_") - html.p("%s%s" % (_("You have selected <b>%d</b> hosts for bulk edit. You can now change " - "host attributes for all selected hosts at once. ") % len(hosts), - _("If a select is set to <i>don't change</i> then currenty not all selected " - "hosts share the same setting for this attribute. " - "If you leave that selection, all hosts will keep their individual settings."))) + html.p("%s%s %s" % ( + _("You have selected <b>%d</b> hosts for bulk edit. You can now change " + "host attributes for all selected hosts at once. ") % len(hosts), + _("If a select is set to <i>don't change</i> then currenty not all selected " + "hosts share the same setting for this attribute. " + "If you leave that selection, all hosts will keep their individual settings."), + _("In case you want to <i>unset</i> attributes on multiple hosts, you need to " + "use the <i>bulk cleanup</i> action instead of bulk edit."))) html.begin_form("edit_host", method = "POST") html.prevent_password_auto_completion()