[checkmk-commits] 5529 FIX Fixed accidentially cloning own visuals instead of builtin visuals

Module: check_mk Branch: master Commit: 60994a9097796a71d3cc3b47f42e5b2f14aa4239 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=60994a9097796a… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Nov 17 15:03:51 2017 +0100 5529 FIX Fixed accidentially cloning own visuals instead of builtin visuals It could happen that one wanted to clone a builtin visual (e.g. dashboard) but was cloning his own visual instead. This could happen if the user already has a visual with the exact name like the visual he tried to clone. Change-Id: I43fd406cf47e61d46c2fd5344b426f8289c5393a --- .werks/5529 | 15 +++++++++++++++ web/htdocs/visuals.py | 2 +- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/.werks/5529 b/.werks/5529 new file mode 100644 index 0000000..761ce8c --- /dev/null +++ b/.werks/5529 @@ -0,0 +1,15 @@ +Title: Fixed accidentially cloning own visuals instead of builtin visuals +Level: 1 +Component: multisite +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.5.0i1 +Date: 1510927292 + +It could happen that one wanted to clone a builtin visual (e.g. dashboard) +but was cloning his own visual instead. + +This could happen if the user already has a visual with the exact name like +the visual he tried to clone. diff --git a/web/htdocs/visuals.py b/web/htdocs/visuals.py index 1b01ed6..93ac934 100644 --- a/web/htdocs/visuals.py +++ b/web/htdocs/visuals.py @@ -645,7 +645,7 @@ def page_edit_visual(what, all_visuals, custom_field_handler = None, mode = html.var('mode', 'edit') if visualname: cloneuser = html.var("load_user") - if cloneuser: + if cloneuser is not None: mode = 'clone' visual = copy.deepcopy(all_visuals.get((cloneuser, visualname), None)) if not visual: