[checkmk-commits] [tribe29/checkmk] b2d5fa: Fix buggy valuespec calls

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: b2d5fa7d5eb3b94ab66ebc0e2bb5d531e7deb6c9 https://github.com/tribe29/checkmk/commit/b2d5fa7d5eb3b94ab66ebc0e2bb5d531e… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-10-01 (Tue, 01 Oct 2019) Changed paths: M cmk/gui/availability.py M cmk/gui/plugins/wato/active_checks.py M cmk/gui/plugins/wato/bi.py M cmk/gui/plugins/wato/check_mk_configuration.py M cmk/gui/plugins/wato/check_parameters/asm_diskgroup.py M cmk/gui/plugins/wato/check_parameters/aws.py M cmk/gui/plugins/wato/check_parameters/carbon_monoxide.py M cmk/gui/plugins/wato/check_parameters/db2_logsize.py M cmk/gui/plugins/wato/check_parameters/docker_node_containers.py M cmk/gui/plugins/wato/check_parameters/docker_node_disk_usage.py M cmk/gui/plugins/wato/check_parameters/graylog_failures.py M cmk/gui/plugins/wato/check_parameters/graylog_messages.py M cmk/gui/plugins/wato/check_parameters/heartbeat_crm.py M cmk/gui/plugins/wato/check_parameters/ipmi.py M cmk/gui/plugins/wato/check_parameters/jenkins_nodes.py M cmk/gui/plugins/wato/check_parameters/jvm_gc.py M cmk/gui/plugins/wato/check_parameters/jvm_tp.py M cmk/gui/plugins/wato/check_parameters/logwatch_ec.py M cmk/gui/plugins/wato/check_parameters/memory.py M cmk/gui/plugins/wato/check_parameters/msx_queues.py M cmk/gui/plugins/wato/check_parameters/mtr.py M cmk/gui/plugins/wato/check_parameters/netapp_disks.py M cmk/gui/plugins/wato/check_parameters/netapp_luns.py M cmk/gui/plugins/wato/check_parameters/netapp_volumes.py M cmk/gui/plugins/wato/check_parameters/netscaler_sslcerts.py M cmk/gui/plugins/wato/check_parameters/oracle_jobs.py M cmk/gui/plugins/wato/check_parameters/ps.py M cmk/gui/plugins/wato/check_parameters/temperature.py M cmk/gui/plugins/wato/check_parameters/threepar_capacity.py M cmk/gui/plugins/wato/check_parameters/unsorted.py M cmk/gui/plugins/wato/check_parameters/utils.py M cmk/gui/plugins/wato/check_parameters/varnish_backend.py M cmk/gui/plugins/wato/check_parameters/varnish_backend_success_ratio.py M cmk/gui/plugins/wato/check_parameters/varnish_cache.py M cmk/gui/plugins/wato/check_parameters/varnish_cache_hit_ratio.py M cmk/gui/plugins/wato/check_parameters/varnish_client.py M cmk/gui/plugins/wato/check_parameters/varnish_esi.py M cmk/gui/plugins/wato/check_parameters/varnish_fetch.py M cmk/gui/plugins/wato/check_parameters/varnish_objects.py M cmk/gui/plugins/wato/check_parameters/varnish_worker.py M cmk/gui/plugins/wato/check_parameters/varnish_worker_thread_ratio.py M cmk/gui/plugins/wato/check_parameters/volume_groups.py M cmk/gui/plugins/wato/datasource_programs.py M cmk/gui/plugins/wato/notifications.py M cmk/gui/plugins/wato/utils/__init__.py M cmk/gui/views.py M cmk/gui/wato/mkeventd.py M cmk/gui/wato/pages/audit_log.py M cmk/gui/wato/pages/host_diagnose.py M cmk/gui/wato/pages/tags.py M cmk/gui/wato/pages/timeperiods.py Log Message: ----------- Fix buggy valuespec calls Change-Id: I4429471381386080120820577f8453ffef267f88 Commit: 84d14b4f31fdd6d20fcc6f954d9b74185701f844 https://github.com/tribe29/checkmk/commit/84d14b4f31fdd6d20fcc6f954d9b74185… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-10-01 (Tue, 01 Oct 2019) Changed paths: M cmk/gui/plugins/wato/check_mk_configuration.py M cmk/gui/plugins/wato/check_parameters/utils.py M cmk/gui/plugins/wato/utils/__init__.py M cmk/gui/userdb.py M cmk/gui/valuespec.py M cmk/gui/watolib/rulespecs.py Log Message: ----------- Replacing kwargs in valuespecs with explicit + typed arguments * This makes usage of the valuespecs easier, since editors can help completing the constructor arguments * Using valuespecs is safer, since pylint and mypy can help about using the correct arguments and types The change to this small number of classes already uncovered a lot of wrong valuespec calls. Change-Id: If9c43dde1685684efde536d46c36fd0d702b82ef Commit: 9f62e09459f733f560c4ec357f9061db553378ff https://github.com/tribe29/checkmk/commit/9f62e09459f733f560c4ec357f9061db5… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-10-01 (Tue, 01 Oct 2019) Changed paths: M cmk/gui/valuespec.py Log Message: ----------- IP address factories Change-Id: I104da3326999499fd62b7a292e86a6b18d0a5bd1 Commit: eeff2a452c901036e179e8e656fa49a201446d76 https://github.com/tribe29/checkmk/commit/eeff2a452c901036e179e8e656fa49a20… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-10-01 (Tue, 01 Oct 2019) Changed paths: M cmk/gui/valuespec.py Log Message: ----------- Several cleanups + add TODO comments * Change some valuespec classes to factories * Move helper functions around * Updated some TODO comments Change-Id: Ic988289c20e2f22e4268f567aa214210a716c6a1 Compare: https://github.com/tribe29/checkmk/compare/0f1192e9a3d9...eeff2a452c90