[checkmk-commits] [tribe29/checkmk] 199ce8: REST API: fix WSGI environment leading to wrong URLs

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 199ce8e5c02d914e97f2d74ac2f65f0d13436c46 https://github.com/tribe29/checkmk/commit/199ce8e5c02d914e97f2d74ac2f65f0d1… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-06-22 (Wed, 22 Jun 2022) Changed paths: M cmk/gui/utils/script_helpers.py M cmk/gui/wsgi/__init__.py M cmk/gui/wsgi/middleware.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_activate_changes.py M tests/unit/cmk/gui/test_http.py Log Message: ----------- REST API: fix WSGI environment leading to wrong URLs Apache's mod_wsgi sends a SCRIPT_NAME and PATH_INFO at the same time, which Werkzeug concatenates. SCRIPT_NAME corresponds to the "root_path" (i.e. the location where the application is mounted under) and PATH_INFO the path relative to that. In our case PATH_INFO already contains all the information, so having something in SCRIPT_NAME is redundant. This change introduces a middleware which recreates the environment of Apache, so that we can write unit-tests against that behavior. Change-Id: I321eac741fa79b88b37ebf77d383b5ab8274decc Commit: c1b505f6857ca65a6d5f5e5413bf99df21cfbe06 https://github.com/tribe29/checkmk/commit/c1b505f6857ca65a6d5f5e5413bf99df2… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-06-22 (Wed, 22 Jun 2022) Changed paths: A .werks/13926 M cmk/gui/fields/base.py M cmk/gui/plugins/openapi/restful_objects/decorators.py M cmk/gui/plugins/openapi/restful_objects/response_schemas.py M cmk/gui/plugins/openapi/utils.py A tests/unit/cmk/gui/plugins/openapi/test_error.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_host_config.py Log Message: ----------- 13926 FIX validation of error responses of the REST API This werk changes the default error schema to be in line with the until now returned responses. The schema and responses did not fit and it was not found because the responses were not checked automatically. This is now the case. To ensure that dynamic scripts will not break only the schema has been changed. Users of dynamic languages (Python, Bash, etc.) will not have to change anything. If you use a statically generated API client, you may need to re-compile the client after this werk. Change-Id: Icf9ac8d8bf694ff3b834712c9e1a7943149a3b33 Commit: f6e252d3ab71adaee6f1f43878500843e5dfd50b https://github.com/tribe29/checkmk/commit/f6e252d3ab71adaee6f1f43878500843e… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-06-22 (Wed, 22 Jun 2022) Changed paths: A .werks/13931 M cmk/gui/fields/base.py Log Message: ----------- 13931 FIX wrong labels not raising errors in the REST API Previously when trying to set an invalid "labels" value when creating or updating a host through the REST API, the error did not occur and a 200 OK response would be returned. The value would not be set though. This werk fixes this problem. Change-Id: I9292ddf65e4821634cf8270b467f479bef7a5c86 Compare: https://github.com/tribe29/checkmk/compare/d12056d1d4fe...f6e252d3ab71