[checkmk-commits] [tribe29/checkmk] 3a6cfa: Remove assertion in TCP core helper

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 3a6cfa91cdab8cfdf974a71c5399a03d58778c29 https://github.com/tribe29/checkmk/commit/3a6cfa91cdab8cfdf974a71c5399a03d5… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2021-01-04 (Mon, 04 Jan 2021) Changed paths: M cmk/fetchers/tcp.py Log Message: ----------- Remove assertion in TCP core helper It is possible to configure a host where the address is None. This triggers the assertion and fails with an empty error message. This patch lets the code fail later with the more helpful 'MKIPAddressLookupError'. Change-Id: I96e507761bff8c021085d1011d6643def3b069b7 Commit: 6638b81e51227b4b8cd2c6151867764464b72c36 https://github.com/tribe29/checkmk/commit/6638b81e51227b4b8cd2c615186776446… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2021-01-04 (Mon, 04 Jan 2021) Changed paths: M livestatus/src/Poller.h Log Message: ----------- Unify setUpPoller and setUpErrorPoller Both functions were taking the same argument and using a single function simplifies the API. Moreover, setUpErrorPoller was noop in most cases. We only found three classes where setUpErrorPoller was implemented and where stderr was different from stdout: AlertHelper, CheckHelper, and ICMPReceiver. This frees the caller from handling the error fd and therefore prevents the case where the same fd would be registered multiple times. Multiple registrations of the same fd now raises an asssertion. CMK-6859 Change-Id: I31066880125014dae379b7a4428285feb1816a41 Compare: https://github.com/tribe29/checkmk/compare/75b86b24350d...6638b81e5122