[checkmk-commits] [Checkmk/checkmk] d25b6c: rules: implement validation layer

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: d25b6c3c8264cfc665bf237f329d8f7dd8b3d9e9 https://github.com/Checkmk/checkmk/commit/d25b6c3c8264cfc665bf237f329d8f7dd… Author: Lukas Lengler <lukas.lengler(a)checkmk.com> Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M cmk/gui/watolib/rulesets.py A cmk/utils/config_validation_layer/rules.py Log Message: ----------- rules: implement validation layer CMK-16968 Change-Id: I2542d3c7dbf06552922b027ea4101ae6015343fb Commit: 21fe7bd351e2d6a2c4280e3b74f85cc85bb88606 https://github.com/Checkmk/checkmk/commit/21fe7bd351e2d6a2c4280e3b74f85cc85… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M cmk/gui/views/perfometer/legacy_perfometers/check_mk.py Log Message: ----------- ipmi_sensors: Remove legacy perfometer Note that this actually removes a perfometer in the UI in one special case: * Summary mode is activated in discovery parameters. * There are sensors with a valid reading which have "amb" or "Ambient" in their name. In this case, the ipmi_sensors plugin produces a metric named "ambient_temp" (see `def _average_ambient_temperature`), which triggers the legacy performeter removed by this commit. However, this metric is not actually registered, so the perfometer has no units and it is very unlikely that any customer actually knows what this perfometer displays (since the plugin produces the metric only without any textual output). Therefore, it should be ok to drop the perfometer in this particular case. Note that in non-summary mode, the ipmi_sensors plugin only produces metrics for temperature sensors. These sensors are covered by the standard temperature perfometer, so we don't change anything in this case. CMK-17098 Change-Id: I90eb0f07ed6ba3b1e8dd752fa1f40b926c2e0bee Commit: 78346a3cb4a40e2a4d6ac880e814b9e1d99e2d65 https://github.com/Checkmk/checkmk/commit/78346a3cb4a40e2a4d6ac880e814b9e1d… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M cmk/base/plugins/agent_based/hp_proliant_power.py M cmk/gui/plugins/metrics/translation.py M tests/unit/cmk/base/plugins/agent_based/test_hp_proliant_power.py Log Message: ----------- hp_proliant_power: Use correct metric This triggers the standard power perfometer for this plugin. CMK-17098 Change-Id: I6adf90df5008f299ada2ae3c077f4595f65f9f8b Commit: 5a8b60dd1efb9179b4f03509b8ae0709874b513d https://github.com/Checkmk/checkmk/commit/5a8b60dd1efb9179b4f03509b8ae07098… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M cmk/gui/views/perfometer/legacy_perfometers/check_mk.py Log Message: ----------- Remove some unused legacy perfometers I explicitly checked the corresponding plugins. To the best of my knowledge and belief, they shouldn't be relevant anymore because either a definition from `perfometer_info` or from the brand-new API applies. CMK-17098 Change-Id: I81df9d151171bfa33878904316e8d4f6e2d319f1 Compare: https://github.com/Checkmk/checkmk/compare/a88a7f50f812...5a8b60dd1efb To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications