[checkmk-commits] Check_MK Git: check_mk: #1717 Split up LDAP configuration dialog into four boxes

Module: check_mk Branch: master Commit: cf8ef2b6cd67d80fca37f9cc738dfbb95182a78d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=cf8ef2b6cd67d8… Author: Mathias Kettner &lt;mk(a)mathias-kettner.de&gt; Date: Mon Dec 8 21:25:50 2014 +0100 #1717 Split up LDAP configuration dialog into four boxes This allows folding part of the configuration and easier access to the <i>Save & Test</i> button. --- .werks/1717 | 9 +++++++++ ChangeLog | 1 + web/htdocs/wato.py | 10 ++++++++-- 3 files changed, 18 insertions(+), 2 deletions(-) diff --git a/.werks/1717 b/.werks/1717 new file mode 100644 index 0000000..236c0fb --- /dev/null +++ b/.werks/1717 @@ -0,0 +1,9 @@ +Title: Split up LDAP configuration dialog into four boxes +Level: 1 +Component: wato +Compatible: compat +Version: 1.2.5i7 +Date: 1418070310 +Class: feature + +This allows folding part of the configuration and easier access to the <i>Save & Test</i> button. diff --git a/ChangeLog b/ChangeLog index 9fd9228..9286c23 100644 --- a/ChangeLog +++ b/ChangeLog @@ -210,6 +210,7 @@ * 1689 Creating WATO backends for each configured site now... * 1690 Pending changes can now be discarded... * 1693 Added search form to global settings page... + * 1717 Split up LDAP configuration dialog into four boxes... * 1165 FIX: Fixed exception in service discovery of logwatch event console forwarding checks... * 1490 FIX: Timperiod excludes can now even be configured when creating a timeperiod... * 1491 FIX: Fixed bug in dynamic lists where removing an item was not always possible... diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index 7b88e45..63c9974 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -7208,10 +7208,16 @@ def mode_ldap_config(phase): html.write('<div id=ldap>') html.write('<table><tr><td>') html.begin_form('ldap_config', method = "POST", action = 'wato.py?mode=ldap_config') - forms.header(_('LDAP Settings')) + need_header = True for (var, valuespec) in vs: value = current_settings.get(var, valuespec.default_value()) - forms.section(valuespec.title()) + if isinstance(valuespec, Dictionary): + valuespec._render = "form" + else: + if need_header: + forms.header(_('Other Settings')) + need_header = False + forms.section(valuespec.title()) valuespec.render_input(var, value) html.help(valuespec.help()) forms.end()