[checkmk-commits] [Checkmk/checkmk] 90c205: Rewrite one disco test without monkeypatch

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 90c205d2d120945b001c74da2504a8f5e99b11fd https://github.com/Checkmk/checkmk/commit/90c205d2d120945b001c74da2504a8f5e… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2023-06-22 (Thu, 22 Jun 2023) Changed paths: M cmk/base/agent_based/discovery/autodiscovery.py M tests/unit/cmk/base/agent_based/discovery/test_discovery.py Log Message: ----------- Rewrite one disco test without monkeypatch Test was neither understandable nor maintainable, and it was slightly tautological. CMK-12298 Change-Id: I4edf538c10340a963bde8f18d31609829b194c79 Commit: dc45960029f4258cb789ccbd7aede2816787585f https://github.com/Checkmk/checkmk/commit/dc45960029f4258cb789ccbd7aede2816… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2023-06-22 (Thu, 22 Jun 2023) Changed paths: M cmk/base/agent_based/discovery/_discovered_services.py M cmk/base/agent_based/discovery/autodiscovery.py M cmk/base/agent_based/discovery/commandline.py M tests/unit/cmk/base/agent_based/discovery/test_discovered_services.py M tests/unit/cmk/base/agent_based/discovery/test_discovery.py Log Message: ----------- Clarify discovery / analysis Discovery and analysis of the result are on the same abstraction level so call them one ofter the other, in the same function. This incidently clarifies and localizes the usage of the `AutochecksStore` in the `autodiscovery` module and makes testing the functionality easier. CMK-12298 Change-Id: Ibb751499e368b2669370406723c4dd801d857311 Commit: d922443bbc4dd2b9a9218bc9fefc91dd0214df50 https://github.com/Checkmk/checkmk/commit/d922443bbc4dd2b9a9218bc9fefc91dd0… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2023-06-22 (Thu, 22 Jun 2023) Changed paths: M cmk/base/agent_based/discovery/_discovered_services.py M cmk/base/agent_based/discovery/autodiscovery.py M cmk/base/agent_based/discovery/commandline.py M cmk/checkengine/discovery/__init__.py A cmk/checkengine/discovery/_services.py M tests/unit/cmk/base/agent_based/discovery/test_discovered_services.py Log Message: ----------- Move discovered analysis of services to check engine No deps on base CMK-12298 Change-Id: I098631434f8e4031f55ff860738e0b8a387f39e8 Compare: https://github.com/Checkmk/checkmk/compare/88b3d24c414c...d922443bbc4d