16 Jun
2023
16 Jun
'23
11:43 a.m.
Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: 5824df9defb6e998b6d0013d6663865babf2864a
https://github.com/Checkmk/checkmk/commit/5824df9defb6e998b6d0013d6663865ba…
Author: Mathias Laurin <mathias.laurin(a)checkmk.com>
Date: 2023-06-16 (Fri, 16 Jun 2023)
Changed paths:
M cmk/base/config.py
M cmk/ec/config.py
M cmk/ec/core_queries.py
M cmk/ec/host_config.py
M cmk/ec/main.py
M cmk/gui/painter/v0/base.py
M cmk/gui/painter/v0/painters.py
M cmk/gui/painter/v1/painter_lib.py
M cmk/gui/painter_options.py
M cmk/gui/plugins/metrics/artwork.py
M cmk/gui/plugins/metrics/graph_images.py
M cmk/gui/plugins/metrics/graph_pdf.py
M cmk/gui/plugins/metrics/html_render.py
M cmk/gui/plugins/metrics/utils.py
M cmk/gui/plugins/wato/check_parameters/db_jobs.py
M cmk/gui/valuespec.py
M cmk/utils/prediction.py
M cmk/utils/render.py
M cmk/utils/type_defs.py
M tests/unit/cmk/gui/plugins/metrics/test_artwork.py
Log Message:
-----------
Move time-related aliases to utils.predictions
These types are often used together with other parts of
`cmk.utils.predictions`. This change therefore improves
the cohesion. And when they're *not* used with other
types or functions of `predictions`, then it's most likely
the wrong kind of coupling and it should be fixed.
These types are just aliases to int anyway so they are
not really useful.
CMK-13768
Change-Id: I2829fd70306f68b6d8cb0022300e7502f3e70af8
Commit: 787accc22c10afab67c6f1561434e370e87e6fcb
https://github.com/Checkmk/checkmk/commit/787accc22c10afab67c6f1561434e370e…
Author: Mathias Laurin <mathias.laurin(a)checkmk.com>
Date: 2023-06-16 (Fri, 16 Jun 2023)
Changed paths:
M cmk/automations/results.py
M cmk/base/agent_based/checking/_checking.py
M cmk/base/agent_based/discovery/_discovery.py
M cmk/base/automations/check_mk.py
M cmk/base/checkers.py
M cmk/base/sources/_sources.py
M cmk/checkengine/_api.py
M cmk/checkengine/_parseragent.py
M cmk/checkengine/crash_reporting.py
M cmk/fetchers/_ipmi.py
M cmk/fetchers/_nofetcher.py
M cmk/fetchers/_piggyback.py
M cmk/fetchers/_program.py
M cmk/fetchers/_tcp.py
M cmk/fetchers/filecache/_agent.py
M cmk/fetchers/snmp_backend/stored_walk.py
M cmk/snmplib/type_defs.py
M cmk/utils/agent_simulator.py
M cmk/utils/piggyback.py
M cmk/utils/type_defs.py
M tests/unit/cmk/base/agent_based/test_base_inventory.py
M tests/unit/cmk/checkers/test_fetchers.py
M tests/unit/cmk/checkers/test_parsers.py
Log Message:
-----------
Move `AgentRawData` to snmplib
This is obviously wrong (agent data != snmp). The type should
most likely go the check engine, where we already have, for
example, `AgentRawDataSection`. However, to achieve this, we
will have to clarify the layering between fetchers and
check engine otherwise, the change results in cyclic dependencies.
This is nevertheless and improvement in that snmplib and whereever
`AgentRawData` ends up are at the same level of abstraction level.
Also, we already had related types in `snmplib`.
CMK-13768
Change-Id: I935f97833c167702907830671a818a80536be314
Compare: https://github.com/Checkmk/checkmk/compare/af99eb9a5763...787accc22c10