[checkmk-commits] #2437 FIX joloka_metrics.perm_gen: fixed broken check

Module: check_mk Branch: master Commit: 40e3d9d0a23bf6a8faebf16d4c9362399a5ff34b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=40e3d9d0a23bf6… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Tue Oct 20 11:32:57 2015 +0200 #2437 FIX joloka_metrics.perm_gen: fixed broken check This check never worked. It has been fixed. --- .werks/2437 | 9 +++++++++ ChangeLog | 1 + checks/jolokia_metrics | 4 +--- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/.werks/2437 b/.werks/2437 new file mode 100644 index 0000000..ca5b206 --- /dev/null +++ b/.werks/2437 @@ -0,0 +1,9 @@ +Title: joloka_metrics.perm_gen: fixed broken check +Level: 1 +Component: checks +Compatible: compat +Version: 1.2.7i4 +Date: 1445333509 +Class: fix + +This check never worked. It has been fixed. diff --git a/ChangeLog b/ChangeLog index e3bf0ab..c90c820 100644 --- a/ChangeLog +++ b/ChangeLog @@ -12,6 +12,7 @@ * 2664 FIX: ps: Speedup in situation with many matching processes... * 2661 FIX: windows agent: fixed incomplete process list... * 2665 FIX: ps: fix crash in case of quota violation on Windows + * 2437 FIX: joloka_metrics.perm_gen: fixed broken check... Multisite: * 2680 FIX: LDAP: Fixed exception when syncing groups using configurations from previous versions... diff --git a/checks/jolokia_metrics b/checks/jolokia_metrics index 0c5b38d..52708d0 100644 --- a/checks/jolokia_metrics +++ b/checks/jolokia_metrics @@ -826,15 +826,13 @@ jolokia_metrics_perm_gen_default_levels = { "perm" : ( 80.0, 100.0 ) } def inventory_jolokia_metrics_perm_gen(info): parsed = jolokia_metrics_parse(info) - if parsed.get(inst, "") == None: - raise MKCounterWrapped("No information from Jolokia agent") for instance, values in parsed.items(): if "PermGenUsage" in values: yield instance, "jolokia_metrics_perm_gen_default_levels" def check_jolokia_metrics_perm_gen(item, params, info): parsed = jolokia_metrics_parse(info) - if parsed.get(inst, "") == None: + if parsed.get(item, "") == None: raise MKCounterWrapped("No information from Jolokia agent") values = parsed.get(item) if values: