[checkmk-commits] 6908 FIX jolokia_metrics.tp: Fix percentage of tomcat threadpool info

Module: check_mk Branch: master Commit: 95e4ba21d3ac10b6b8bfa158d27f558dd4e83918 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=95e4ba21d3ac10… Author: Moritz Kiemer <mo(a)mathias-kettner.de> Date: Mon Nov 19 09:34:34 2018 +0100 6908 FIX jolokia_metrics.tp: Fix percentage of tomcat threadpool info Previously the value shown as percentage was too small by a factor of 100 and rounded to 1 decimal digit. Change-Id: Ia7c8b7d33e6b69cc51bb9435c74a0b89ccd72cfb --- .werks/6908 | 11 +++++++++++ checks/jolokia_metrics | 11 ++++++----- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/.werks/6908 b/.werks/6908 new file mode 100644 index 0000000..8d66461 --- /dev/null +++ b/.werks/6908 @@ -0,0 +1,11 @@ +Title: jolokia_metrics.tp: Fix percentage of tomcat threadpool info +Level: 1 +Component: checks +Compatible: compat +Edition: cre +Version: 1.6.0i1 +Date: 1542615887 +Class: fix + +Previously the value shown as percentage was too small by a factor of 100 +and rounded to 1 decimal digit. diff --git a/checks/jolokia_metrics b/checks/jolokia_metrics index ce0fc69..b0e1a8e 100644 --- a/checks/jolokia_metrics +++ b/checks/jolokia_metrics @@ -473,18 +473,19 @@ def check_jolokia_metrics_tp(item, params, info): def check_thread_levels(what): threads_abs = int(threadpool_info[what]) - threads_rel = threads_abs / max_threads - infotext = "%s: %d (%.1f%%)" % (what, threads_abs, threads_rel) + threads_perc = threads_abs * 100. / max_threads + infotext = "%s: %d (%s)" % (what, threads_abs, get_percent_human_readable(threads_perc)) status = 0 _params = params.get(what) if _params and _params[0] != None and _params[1] != None: warn, crit = params[what] - levelstext = " (warn/crit at %d/%d%%)" % (warn, crit) - if threads_rel >= crit: + levelstext = " (warn/crit at %s/%s)" % (get_percent_human_readable(warn), + get_percent_human_readable(crit)) + if threads_perc >= crit: status = 2 infotext += levelstext - elif threads_rel >= warn: + elif threads_perc >= warn: status = 1 infotext += levelstext else: