[checkmk-commits] [tribe29/checkmk] 1d2ad0: Refactor urlencode_vars

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 1d2ad010304767d78861a64693ed32d343573a46 https://github.com/tribe29/checkmk/commit/1d2ad010304767d78861a64693ed32d34… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2021-08-11 (Wed, 11 Aug 2021) Changed paths: M cmk/gui/utils/url_encoder.py Log Message: ----------- Refactor urlencode_vars It also makes it a little bit more performant (~10-15%). It's not much but since we use it quite often (e.g. in the rule overview) it pays off. CMK-8035 Change-Id: Ife1e7c5abcb954a3a5f79416b91c632176ed78fb Commit: 30be6c5a7292d7a2cf0b15c4fc2d0c3727e6abd2 https://github.com/tribe29/checkmk/commit/30be6c5a7292d7a2cf0b15c4fc2d0c372… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2021-08-11 (Wed, 11 Aug 2021) Changed paths: M cmk/gui/escaping.py Log Message: ----------- Fix conditionals in escape_attribute Since type(value) was used in isinstance checks they always evaluated to False. I.e. for the common case str all conditionals were always evaluated. Now, isinstance is used on the value and the str and HTML cases are moved to the top. In tests this resulted in a 25 - 30% performance improvement. CMK-8035 Change-Id: I7adc9577f2ecdcbb2d3854c179ac6675d3dcbee7 Commit: 4c542a303597a3a9144ddc7d5867cb894ad72605 https://github.com/tribe29/checkmk/commit/4c542a303597a3a9144ddc7d5867cb894… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2021-08-11 (Wed, 11 Aug 2021) Changed paths: M cmk/gui/wato/pages/rulesets.py Log Message: ----------- Use omit_update_header in the ruleset overview It generated one unnecessary javascript tag for every folder in the ruleset overview. CMK-8035 Change-Id: I0b7868a7f2ae9644445842efd2fba658b2f60d2b Commit: 966a84e7fae45f25cc63150a256dc4df3907c9b0 https://github.com/tribe29/checkmk/commit/966a84e7fae45f25cc63150a256dc4df3… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2021-08-11 (Wed, 11 Aug 2021) Changed paths: M cmk/gui/utils/url_encoder.py Log Message: ----------- Add stripped-down versions of quote_plus and quote They fit exactly our needs and are 40-50% faster. CMK-8035 Change-Id: I0dc9f40f79deb7b1029e937a66eb5fa7e9c884f2 Compare: https://github.com/tribe29/checkmk/compare/67ab0ed9d446...966a84e7fae4