[checkmk-commits] Check_MK Git: check_mk: #1241 FIX hp_prolaint: Unkown state is not longer handled as OK

Module: check_mk Branch: master Commit: cfeef86f87b996911a5bcc035ca7cd0f75db0e9a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=cfeef86f87b996… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Fri Mar 27 15:35:04 2015 +0100 #1241 FIX hp_prolaint: Unkown state is not longer handled as OK Due to a bug in the HP Firmware there was a need to handle a reported uknown state as {OK}. Since HP provided an Firmware update (http://h20566.www2.hp.com/hpsc/doc/public/display?docId=c03939085&jump) we can handle this state now like expected. --- .werks/1241 | 12 ++++++++++++ ChangeLog | 1 + checkman/hp_proliant | 5 +++-- checks/hp_proliant | 2 +- 4 files changed, 17 insertions(+), 3 deletions(-) diff --git a/.werks/1241 b/.werks/1241 new file mode 100644 index 0000000..de06c96 --- /dev/null +++ b/.werks/1241 @@ -0,0 +1,12 @@ +Title: hp_prolaint: Unkown state is not longer handled as OK +Level: 1 +Component: checks +Compatible: compat +Version: 1.2.7i1 +Date: 1427466792 +Class: fix + +Due to a bug in the HP Firmware there was a need to handle a reported uknown state as {OK}. +Since HP provided an Firmware update (http://h20566.www2.hp.com/hpsc/doc/public/display?docId=c03939085&jump) we can +handle this state now like expected. + diff --git a/ChangeLog b/ChangeLog index f8b31f2..6f9ecc3 100644 --- a/ChangeLog +++ b/ChangeLog @@ -290,6 +290,7 @@ * 2169 FIX: jolokia_metrics.threads: Fixed graph template... * 2170 FIX: jolokia_metrics_gc: Fixed exception when GC time not reported by server * 2109 FIX: netapp_api_volumes: now using the defined levels when using the Nagios core + * 1241 FIX: hp_prolaint: Unkown state is not longer handled as OK... Multisite: * 1758 Improved exception hander: Shows details without additional debug request, added mailto link for error report... diff --git a/checkman/hp_proliant b/checkman/hp_proliant index 9bc094e..0140f57 100644 --- a/checkman/hp_proliant +++ b/checkman/hp_proliant @@ -8,8 +8,9 @@ description: on a HP Proliant server and reads the general status information. In addition it also returns the serial number and firmware version. - The status is {OK} if the agent signals {Unknown} or {Ok}, {WARN} on - {Degraded} and {CRIT} on {Failed}. + The status is {OK} only if the agent signals {Ok}, {WARN} on + {Degraded} and {CRIT} on {Failed}. If you get an {UKNOWN} state you may need a Fireware Update: + http://h20566.www2.hp.com/hpsc/doc/public/display?docId=c03939085&jum inventory: One check is automatically created for each supported server. diff --git a/checks/hp_proliant b/checks/hp_proliant index 10d089d..d8ec3e6 100644 --- a/checks/hp_proliant +++ b/checks/hp_proliant @@ -30,7 +30,7 @@ # '.1.3.6.1.4.1.232.11.1.3.0' => cpqHoMibCondition hp_proliant_general_status_map = { 1: 'Unknown', 2: 'Ok', 3: 'Degraded', 4: 'Failed' } -hp_proliant_general_status2nagios_map = { 'Unknown': 0, 'Ok': 0, 'Degraded': 1, 'Failed': 2, } +hp_proliant_general_status2nagios_map = { 'Unknown': 3, 'Ok': 0, 'Degraded': 1, 'Failed': 2, } def inventory_proliant_general(info): if len(info) > 0 and len(info[0]) > 1: