[checkmk-commits] [tribe29/checkmk] ea1cf9: Timespecific parameters: introduce proper classes

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: ea1cf949c5b7eace183b4a0621867bfda2ede754 https://github.com/tribe29/checkmk/commit/ea1cf949c5b7eace183b4a0621867bfda… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-11-05 (Fri, 05 Nov 2021) Changed paths: M cmk/base/agent_based/checking/__init__.py M cmk/base/agent_based/discovery/__init__.py M cmk/base/autochecks/__init__.py M cmk/base/automations/check_mk.py M cmk/base/check_table.py M cmk/base/check_utils.py M cmk/base/config.py M cmk/base/core_config.py M cmk/base/dump_host.py M cmk/utils/parameters.py M tests/unit/cmk/base/agent_based/checking/test_checking.py M tests/unit/cmk/base/agent_based/discovery/test_discovery.py M tests/unit/cmk/base/api/agent_based/test_utils_check_levels_predictive.py M tests/unit/cmk/base/plugins/agent_based/test_diskstat.py M tests/unit/cmk/base/test_check_table.py M tests/unit/cmk/base/test_config.py M tests/unit/cmk/base/test_core_config.py Log Message: ----------- Timespecific parameters: introduce proper classes Unfortunately the TimespecificParmsList class inherited from "list", such that it was a subclass of "LegacyCheckParameters". All the elements of a TimespecificParmsList instance were LegacyCheckParameters instances themselves. They might or might not have been a truely timespecific parameter or just your regular "LegacyCheckParameter". Now the "TimespecficParameters" class no longer is a subclass of LegacyCheckParameters, forcing us to use an explicit Union (for now, cleanups will follow). Every element is a "TimespecificParameterSet", for constant parameters we simply use ones where we only have default parameters, without any time periods. Change-Id: I4651413b1d94bfc8e561eb55f0d44c3724294d64 Commit: 8b7b6c6d6095acb2ed3dc0ab58a882741d996dfb https://github.com/tribe29/checkmk/commit/8b7b6c6d6095acb2ed3dc0ab58a882741… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-11-05 (Fri, 05 Nov 2021) Changed paths: M cmk/base/agent_based/checking/__init__.py M cmk/base/agent_based/discovery/__init__.py M cmk/base/automations/check_mk.py M cmk/base/dump_host.py M cmk/utils/parameters.py M tests/unit/cmk/base/agent_based/checking/test_checking.py M tests/unit/cmk/utils/test_parameters.py Log Message: ----------- move evaluation of timespecific parameters Change-Id: I69a82d8636d7119070415b2bd9fc3e9298dc056c Commit: 65515b9c23200b964b712f1c629f01a4665bb9bb https://github.com/tribe29/checkmk/commit/65515b9c23200b964b712f1c629f01a46… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-11-05 (Fri, 05 Nov 2021) Changed paths: M cmk/base/config.py M cmk/utils/parameters.py M tests/unit/cmk/base/test_check_table.py Log Message: ----------- config: always return TimespecificParameters Since we have to deal with them anyway, there's no benefit in handling with the 'simpler' case seperately. Change-Id: Ie9561697669f62a7c271fe325c33caa74db2ed06 Commit: fefd45d69a395ccb25b9d06736fad36be76790ba https://github.com/tribe29/checkmk/commit/fefd45d69a395ccb25b9d06736fad36be… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-11-05 (Fri, 05 Nov 2021) Changed paths: M cmk/base/agent_based/discovery/__init__.py M cmk/base/automations/check_mk.py M cmk/utils/parameters.py Log Message: ----------- move preview of timespecific parameters Change-Id: I7c5abda6309f20985e891ef1ef11b096e421ee61 Compare: https://github.com/tribe29/checkmk/compare/b901a1fc4c28...fefd45d69a39