[checkmk-commits] Check_MK Git: check_mk: docsis-checks: converted WATO rules to floats for dBmV

Module: check_mk Branch: master Commit: 26b9452fd4019b899d86f65b2603550c6221da1e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=26b9452fd4019b… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Aug 29 12:16:10 2014 +0200 docsis-checks: converted WATO rules to floats for dBmV --- checks/docsis_signal_quality | 2 +- web/plugins/wato/check_parameters.py | 26 +++++++++++++------------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/checks/docsis_signal_quality b/checks/docsis_signal_quality index cafbd52..0d4d4df 100644 --- a/checks/docsis_signal_quality +++ b/checks/docsis_signal_quality @@ -49,7 +49,7 @@ def check_docsis_signal_quality( item, params, info): if entry == item: # Signal Noise noise_db = float(signal_noise) / 10 - infotext = "Signal/Noise-rate: %.2f dB" % noise_db + infotext = "Signal/Noise ratio: %.2f dB" % noise_db warn, crit = params['signal_noise'] levels = " (warn/crit at %.1f/%.1f dB)" % ( warn, crit ) state = 0 diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py index ac0e385..7c87f42 100644 --- a/web/plugins/wato/check_parameters.py +++ b/web/plugins/wato/check_parameters.py @@ -1383,28 +1383,28 @@ register_check_parameters( register_check_parameters( subgroup_networking, 'docsis_signal_quality', - _("Docsis Singal Quality"), + _("Docsis Signal Quality"), Dictionary( elements = [ ( 'signal_noise', Tuple( - title = _("Levels for Signal Noise"), + title = _("Levels for signal/noise ratio"), elements = [ - Integer( title = _("Warning at"), unit = "dB", default_value = 50), - Integer( title = _("Critical at"), unit = "dB", default_value = 60 ), + Float(title = _("Warning at or below"), unit = "dB", default_value = 50.0), + Float(title = _("Critical at"), unit = "dB", default_value = 60.0 ), ] )), ( 'corrected', Tuple( title = _("Levels for corrected Packages"), elements = [ Percentage( title = _("Warning at"), default_value = 25.0), - Percentage( title = _("Critical at"), default_value = 30.0 ), + Percentage( title = _("Critical at"), default_value = 30.0), ] )), ( 'uncorrected', Tuple( title = _("Levels for uncorrected Packages"), elements = [ - Percentage( title = _("Warning at"), default_value = 25.0 ), - Percentage( title = _("Critical at"), default_value = 30.0 ), + Percentage( title = _("Warning at"), default_value = 25.0), + Percentage( title = _("Critical at"), default_value = 30.0), ] )), ] @@ -1423,15 +1423,15 @@ register_check_parameters( title = _("Power"), help = _(" The operational transmit power"), elements = [ - Integer(title = _("warning at"), unit = "dBmV", default_value = 250 ), - Integer(title = _("critical at"), unit = "dBmV", default_value = 260 ), + Float(title = _("warning at or below"), unit = "dBmV", default_value = 5.0 ), + Float(title = _("critical at or below"), unit = "dBmV", default_value = 1.0 ), ])), ( "frequency", Tuple( title = _("Frequency"), help = _("The current tuner frequency"), elements = [ - Integer(title = _("warning at"), unit = "Mhz", default_value = 155 ), - Integer(title = _("critical at"), unit = "Mhz", default_value = 163 ), + Integer(title = _("warning at"), unit = "MHz", default_value = 155 ), + Integer(title = _("critical at"), unit = "MHz", default_value = 163 ), ])), ] ), @@ -1469,8 +1469,8 @@ register_check_parameters( title = _("Power"), help = _(" The operational transmit power"), elements = [ - Integer(title = _("warning at"), unit = "dBmV", default_value = 250 ), - Integer(title = _("critical at"), unit = "dBmV", default_value = 260 ), + Float(title = _("warning at"), unit = "dBmV", default_value = 20.0 ), + Float(title = _("critical at"), unit = "dBmV", default_value = 10.0 ), ])), ] ),