[checkmk-commits] [Checkmk/checkmk] 042ffb: Rules: service/host_label group operator now has a...

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 042ffb04d423ea07543b5dc7096299e1dc2a3843 https://github.com/Checkmk/checkmk/commit/042ffb04d423ea07543b5dc7096299e1d… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M cmk/gui/openapi/endpoints/rule/fields.py M tests/testlib/rest_api_client.py M tests/unit/cmk/gui/openapi/test_openapi_rules.py Log Message: ----------- Rules: service/host_label group operator now has a default operator key of 'and' The operator field on the LabelGroupCondition was not set a required field, nor did it have a load_default value. This would cause an internal server error if it was not provided. Also, this Condition an item in a list and the first item in this list does not require the operator key. To fix this, I've made added a load_default value. CMK-16383 Change-Id: Ieb37ecb4049fe402b301791f83d5152cbb7a0122 Commit: 6dae06eefaefeb9d45cb6e2844f9272c0b3c94c0 https://github.com/Checkmk/checkmk/commit/6dae06eefaefeb9d45cb6e2844f9272c0… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: A .werks/16781.md Log Message: ----------- 16781 FIX Bi: service/host_label group operator now has a default operator key "and" When creating Bi rules via the REST-API, the host_label_groups and the service_label_groups fields both accepted a list of conditions. These conditions previously required an operator field. However, we realized that the operator field for the first item in these lists really wasn't needed and had no affect. So that the user doesn't have to provide this value, we have now added a default value for all conditions in this list of "and". Change-Id: Ic44b603c4f920262db4a3caa9b695fd98bde1265 Commit: 9ec50607e83ce4b7a12ab140412b7e4346a3b378 https://github.com/Checkmk/checkmk/commit/9ec50607e83ce4b7a12ab140412b7e434… Author: Christopher Krause <christopher.krause(a)checkmk.com> Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M cmk/utils/config_validation_layer/dcd/dcd.py M cmk/utils/config_validation_layer/dcd/piggyback.py M cmk/utils/config_validation_layer/notification_rules.py M cmk/utils/config_validation_layer/passwords.py M cmk/utils/config_validation_layer/rules.py M cmk/utils/config_validation_layer/site_management.py M cmk/utils/config_validation_layer/tags.py M cmk/utils/config_validation_layer/type_defs.py M cmk/utils/config_validation_layer/user_connections.py M cmk/utils/config_validation_layer/users/contacts.py M cmk/utils/config_validation_layer/users/users.py Log Message: ----------- improve config validation layer typing Change-Id: I37e54490942898cdec2f768e50afac7dd5a03826 JIRA-Ref: CMK-17124 Compare: https://github.com/Checkmk/checkmk/compare/37ef5098bb02...9ec50607e83c To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications