[checkmk-commits] Check_MK Git: check_mk: removed emc_storage.raidgroup_status,

check is no longer wanted by customer, everything he needs ( detecting failed/removed disks) is now included in the disks plugin Message-ID: &lt;52ce9866.X7avPcSlGF6r+SfJ%bs(a)mathias-kettner.de&gt; User-Agent: Heirloom mailx 12.4 7/29/08 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Module: check_mk Branch: master Commit: 185f52be20767a7770640fb74d183eb440dc2715 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=185f52be20767a… Author: Bernd Stroessenreuther &lt;bs(a)mathias-kettner.de&gt; Date: Thu Aug 1 14:55:41 2013 +0200 removed emc_storage.raidgroup_status, check is no longer wanted by customer, everything he needs (detecting failed/removed disks) is now included in the disks plugin --- checkman/emc_storage.disks | 5 +++-- checkman/emc_storage.raidgroup_status | 28 ---------------------------- checkman/emcvnx_hwstatus | 2 +- checks/emcvnx_hwstatus | 2 +- 4 files changed, 5 insertions(+), 32 deletions(-) diff --git a/checkman/emc_storage.disks b/checkman/emc_storage.disks index 8e3041d..68704c3 100644 --- a/checkman/emc_storage.disks +++ b/checkman/emc_storage.disks @@ -6,11 +6,12 @@ distribution: check_mk description: Reports the status and the I/O rate of a disk in an EMC storage system. - Returns {OK} if the number of Hard Read Errors is 0 and the number + Returns {OK} if the state of a disk is "Unbound" or "Hot Spare Ready" or "Enabled", + the number of Hard Read Errors is 0 and the number of Hard Write Errors is 0. {CRIT} is returned otherwise. Hint for implementation: Look for "Hard Read Errors:" and "Hard Write Errors:" - lines in section "Bus x Enclosure y Disk z" lines found under + and "State:" lines in section "Bus x Enclosure y Disk z" lines found under "All Disks Information" I/O rates (in Bytes/sec) are just informational and do not trigger any state diff --git a/checkman/emc_storage.raidgroup_status b/checkman/emc_storage.raidgroup_status deleted file mode 100644 index a4595a1..0000000 --- a/checkman/emc_storage.raidgroup_status +++ /dev/null @@ -1,28 +0,0 @@ -title: EMC Storage: Status of RAID groups -agents: emc -catalog: hw/storage -license: GPL -distribution: check_mk -description: - Reports the status of RAID groups in EMC storage systems. - - Returns {OK} if ... and {CRIT} on ... - (to be defined) - - Hint for implementation: Look for "RaidGroup State:" line and following - in section "RaidGroup ID: <my ID>" under "All RAID Groups Information" - Which states are good states and which are bad states is to be defined - -item: - The RAID group ID as returned by the special agent. - E. g. "4" - - Hint for implementation: Look for "RaidGroup ID:" line in section - "All RAID Groups Information" - -perfdata: - None - -inventory: - Automatically configures one check for every RAID group listed - in the agent output. diff --git a/checkman/emcvnx_hwstatus b/checkman/emcvnx_hwstatus index 8cd77e7..4f71531 100644 --- a/checkman/emcvnx_hwstatus +++ b/checkman/emcvnx_hwstatus @@ -4,7 +4,7 @@ catalog: hw/storage license: GPL distribution: check_mk description: - Reports the status of Power Supplies, SPS, SPS Cabeling, LCC, CPU Modules, + Reports the status of Power Supplies, SPS, SPS Cabeling, LCC, SP, CPU Modules, SP I/O Modules and DIMM Modules on EMC storage systems. Returns {OK} if the agent reports "Present" or "Valid" status and {CRIT} diff --git a/checks/emcvnx_hwstatus b/checks/emcvnx_hwstatus index 0234e2f..7a14337 100644 --- a/checks/emcvnx_hwstatus +++ b/checks/emcvnx_hwstatus @@ -86,7 +86,7 @@ def parse_emcvnx_hwstatus(info): encid = line[2] + "/" + line[4] enc = {} parsed[encid] = enc - elif line[-2] == "State:": + elif len(line) > 2 and line[-2] == "State:": if line[0] == "SP": device = line[0] + " " + line[1] else: