[checkmk-commits] [tribe29/checkmk] 852d83: Prepare for contact group check fix

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 852d837704aecf74b147cafb5bd22b4ff0f05299 https://github.com/tribe29/checkmk/commit/852d837704aecf74b147cafb5bd22b4ff… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-08-09 (Mon, 09 Aug 2021) Changed paths: M cmk/gui/watolib/hosts_and_folders.py M cmk/gui/watolib/utils.py Log Message: ----------- Prepare for contact group check fix * Add type hints to better understand the involved data * Extract _get_cgconf_from_attributes helper. This is needed for the following fix. Change-Id: I0df4cbab0bb764d4f3defd4049351d6c24965698 Commit: 6d365cc6f418cae13f85ee79425d81bf71a68a6c https://github.com/tribe29/checkmk/commit/6d365cc6f418cae13f85ee79425d81bf7… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-08-09 (Mon, 09 Aug 2021) Changed paths: M cmk/gui/watolib/hosts_and_folders.py Log Message: ----------- Cleanup must_be_in_contactgroups * Mark helper function to be module local * Extract the tuple > dict conversion * Add type hints and only hand over the contact groups Change-Id: If7849fbcba7e9c4d79e5b53737f8f43d2ef59cee Commit: 7e8c16ee5a05146cdf769f363947852282501c09 https://github.com/tribe29/checkmk/commit/7e8c16ee5a05146cdf769f36394785228… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-08-09 (Mon, 09 Aug 2021) Changed paths: A .werks/12851 M cmk/gui/watolib/hosts_and_folders.py Log Message: ----------- 12851 FIX Folder/Host permissions: Users could add groups but not remove them afterwards Users with the "User" role which are able to manage a folder in "Hosts & folders" can add and remove permissions of contact groups on a folder. These users should only be able to add / remove contact groups they are a member of. However, in previous releases it was possible to add one group to the permitted groups of a folder he is not a member of. But when trying to remove the group, this was denied because the user is not a member of this group. The logic has now been changed to provide the user a consistent behaviour: In the moment a user tries to add OR remove a contact group, it is verified that the user is a member of that group. The user can now really only add OR remove groups he is a member of. Groups which are permitted on this folder and are not modified by the user are not relevant in this situation. SUP-4915 Change-Id: I9ffde74cad3d21067bd5e44cc2d6cd62da3e2832 Compare: https://github.com/tribe29/checkmk/compare/d131846ba08e...7e8c16ee5a05