[checkmk-commits] [tribe29/checkmk] dd7fa6: check_mail_loop: split off common functionality

Branch: refs/heads/test_weblate2 Home: https://github.com/tribe29/checkmk Commit: dd7fa663243fb2d9cccbcac422cb425c2e9a27fa https://github.com/tribe29/checkmk/commit/dd7fa663243fb2d9cccbcac422cb425c2… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2020-10-16 (Fri, 16 Oct 2020) Changed paths: M active_checks/check_mail_loop A cmk/utils/mailbox.py M tests/unit/active_checks/test_ac_check_mail_loop.py Log Message: ----------- check_mail_loop: split off common functionality check_mail and check_mailboxes also use mailing capabilities and share common logic for active checks. Those common elements have been extracted to a separate module in order to refactor check_mail and check_mailboxes. Change-Id: I299c50844b341ef2c4ed2680a77ba17b37e35a06 Commit: 8fb8f51a1438e8ffd9310864f0cb0d97fb1c8954 https://github.com/tribe29/checkmk/commit/8fb8f51a1438e8ffd9310864f0cb0d97f… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2020-10-16 (Fri, 16 Oct 2020) Changed paths: M active_checks/check_mail M checks/check_mail M tests/unit/active_checks/test_ac_check_mail.py M tests/unit/checks/test_check_mail.py Log Message: ----------- check_mail: adapt refactoring elements from check_mail_loop Switch to argparse in order to have much less code and make use of common functionality exctracted from check_mail_loop Change-Id: I2e11a8f11a85ecbe8900e54100d111bdf4cbed7f Commit: 8c2af6a31b2a06009cc4cdff3478833d5bb99cae https://github.com/tribe29/checkmk/commit/8c2af6a31b2a06009cc4cdff3478833d5… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2020-10-16 (Fri, 16 Oct 2020) Changed paths: M active_checks/check_mailboxes M checks/check_mailboxes M tests/unit/checks/test_check_mailboxes.py Log Message: ----------- check_mailboxes: adapt refactoring elements from check_mail_loop Switch to argparse in order to have much less code and make use of common functionality exctracted from check_mail_loop Change-Id: Id83e3549dcfafdfbbfa7b196696288d71da10883 Commit: a25290a19b2c2bfe40bac81f5ef93fe582a2eff6 https://github.com/tribe29/checkmk/commit/a25290a19b2c2bfe40bac81f5ef93fe58… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-10-16 (Fri, 16 Oct 2020) Changed paths: A .werks/11117 M cmk/base/api/agent_based/register/check_plugins_legacy.py M cmk/base/api/agent_based/register/section_plugins_legacy/__init__.py M cmk/base/check_api.py M cmk/base/check_api_utils.py M cmk/base/inventory.py M tests/unit/cmk/base/api/agent_based/register/test_check_plugins_legacy.py M tests/unit/cmk/base/api/agent_based/register/test_section_plugins_legacy.py Log Message: ----------- 11117 Drop support for creation of HostLabels via discovery function This werk only affect users who implemented their own plugins *and* where creating HostLabels using the discovery function or inventory plugins. The afore mentioned features are no longer supported. Creation of host labels can now only be implemented using the new check API. It is done by passing a `host_label_function` to the `register.agent_section` function. For details please refer to the dokumentation. Change-Id: I3c49669b7a1afc4e746a32379a6630bca5673e0e Commit: 9df1d43de5571ab0d95de2cd50288e5a30cfab5e https://github.com/tribe29/checkmk/commit/9df1d43de5571ab0d95de2cd50288e5a3… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-16 (Fri, 16 Oct 2020) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/modes/check_mk.py M cmk/gui/watolib/automations.py Log Message: ----------- Improve background job / automation debugging The GUI log level now affects the verbosity of the output produced by automation commands. To get more diagnostic information on e.g. the service discovery page, you you can now increase the log level for automations in the GUI logging configuration which will a) give you more output of the GUI mechanic and b) of the actual communication with the target device. Previously the automations always used either "normal" output or "verbose" output in case of the service discovery automation. Change-Id: I198e017581962a8ab980f34fc5b015b49d95a9ff Commit: ef634c8cbbee22f666726a86bdb98f979578bf9d https://github.com/tribe29/checkmk/commit/ef634c8cbbee22f666726a86bdb98f979… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-16 (Fri, 16 Oct 2020) Changed paths: M cmk/fetchers/_base.py M cmk/fetchers/snmp.py Log Message: ----------- Add some more debug logging to SNMP fetcher Change-Id: Iba5cb6dd0015705fb450afebcac057edf6461d88 Commit: 13c34c5a8895d3b51f5bdcb5ccd53e89198c5d36 https://github.com/tribe29/checkmk/commit/13c34c5a8895d3b51f5bdcb5ccd53e891… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2020-10-16 (Fri, 16 Oct 2020) Changed paths: M cmk/base/checkers/_abstract.py M cmk/base/checking.py R cmk/base/cpu_tracking.py M cmk/fetchers/controller.py A cmk/utils/cpu_tracking.py R tests/unit/cmk/base/test_cpu_tracking.py A tests/unit/cmk/utils/test_cpu_tracking.py Log Message: ----------- [CMK-5399] - add CPU tracking to fetcher - track cpu usage for all fetchers - deliver results of tracking as a log message(to be fixed in next CL) to Microcore - add context manager API to cpu_tracking module - unit test - move cpu_tracking to cmk.utils to avoid layer violation warning - introduce cpu_tracking.reset This is first part of the ticket: gathering data. Some details of implementation Unfortunately current codebase requires that we have some kind of global data(decorator cpu_tracking.track) to track cpu usage. This approach makes impossible the transfer of the context of cpu tracking outside the module(like in cmk...profile). We have chosen to use 'reset' together with starting of the gathering cpu info. This API(pair reset/start) may be changed in the future to be more elegant. Change-Id: Ia0c3f3ac34372a2910f5b009efc54f8081c67dbe Commit: f60db62914bf6398c59ad9d79943c76a06025f3d https://github.com/tribe29/checkmk/commit/f60db62914bf6398c59ad9d79943c76a0… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2020-10-16 (Fri, 16 Oct 2020) Changed paths: M cmk/gui/wato/pages/services.py Log Message: ----------- Minor adaptions to the service discovery * Make "Update host labels" suggested * Shorten some titles Change-Id: Icb85e25f03abab000979dd3f60946d22da8ea799 Commit: 196971daa29a9a19bbe060da971653266cbf8b28 https://github.com/tribe29/checkmk/commit/196971daa29a9a19bbe060da971653266… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2020-10-16 (Fri, 16 Oct 2020) Changed paths: M cmk/gui/valuespec.py Log Message: ----------- Rename assets to icons Change-Id: Id50766f3e77cc53f126f03364d97340ce427cbbe Commit: 1e425f60c00cb18e376bfb1286bdad6b56321e53 https://github.com/tribe29/checkmk/commit/1e425f60c00cb18e376bfb1286bdad6b5… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-10-16 (Fri, 16 Oct 2020) Changed paths: M cmk/gui/htmllib.py M cmk/gui/main.py Log Message: ----------- Move redirection from index.py to mobile.py to page handler of index This is a preparation for factoring out makeuri_contextless from cmk.gui.htmllib.html. CMK-5885 Change-Id: I0a713606e097636918ce540bce6be274022c9864 Commit: e1d2f0776031547a6c8f0900ea7a836fa4832377 https://github.com/tribe29/checkmk/commit/e1d2f0776031547a6c8f0900ea7a836fa… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-10-16 (Fri, 16 Oct 2020) Changed paths: M cmk/gui/htmllib.py M cmk/gui/utils/url_encoder.py A cmk/gui/utils/urls.py Log Message: ----------- Make method makeuri_contextless of cmk.gui.htmllib.html a function The method cmk.gui.htmllib.html.makeuri_contextless is, among others, used for retrieving the URLs of hosts and folders. This is also done when updating the search index for the Setup menu after a change. The REST API can make changes and thus trigger this step, however, it has no access to the global html object in cmk.gui.globals. Hence, the current implementation of the search index breaks the REST API. To resolve this, we make makeuri_contextless a function that can be accessessed by the API. CMK-5885 Change-Id: Ibc2e8ec86271e418ddd8d4552f3f672e8ffd5f80 Commit: b0d87006fa2eac9aeaa2bcfb329c2fc53112a1b8 https://github.com/tribe29/checkmk/commit/b0d87006fa2eac9aeaa2bcfb329c2fc53… Author: Lukas Lengler <lukas.lengler(a)tribe29.com> Date: 2020-10-16 (Fri, 16 Oct 2020) Changed paths: M cmk/base/checking.py M cmk/base/config.py M cmk/gui/plugins/wato/check_mk_configuration.py M cmk/gui/watolib/rulesets.py M cmk/update_config.py Log Message: ----------- Yapf backslash continuation Yapf - cmk/base/config.py - cmk/gui/plugins/wato/checK_mk_configuration.py - cmk/update_config.py - cmk/base/checking.py Change-Id: I0b4450e78f8ff73832fe36e774123be554484c7f Commit: f2c0ef9f99a2b58519d7a5d1a4eb2f7bc5db7038 https://github.com/tribe29/checkmk/commit/f2c0ef9f99a2b58519d7a5d1a4eb2f7bc… Author: Ronny Bruska <ronny.bruska(a)tribe29.com> Date: 2020-10-16 (Fri, 16 Oct 2020) Changed paths: M cmk/gui/table.py M cmk/gui/wato/pages/services.py Log Message: ----------- Set table limit message on top, remove it from service discovery page CMK-5784 Change-Id: I293a8e68fcfe489adb094609015c91100bc9402e Commit: 2ea4a99a45445ab6aedffd6ac336b44713190b52 https://github.com/tribe29/checkmk/commit/2ea4a99a45445ab6aedffd6ac336b4471… Author: Lukas Lengler <lukas.lengler(a)tribe29.com> Date: 2020-10-16 (Fri, 16 Oct 2020) Changed paths: M agents/plugins/asmcmd.sh M agents/plugins/db2_mem M agents/plugins/dnsclient M agents/plugins/hpux_lunstats M agents/plugins/hpux_statgrab M agents/plugins/ibm_mq M agents/plugins/jar_signature M agents/plugins/kaspersky_av M agents/plugins/lnx_quota M agents/plugins/lvm M agents/plugins/mk_apt M agents/plugins/mk_ceph M agents/plugins/mk_cups_queues M agents/plugins/mk_db2.aix M agents/plugins/mk_db2.linux M agents/plugins/mk_errpt.aix M agents/plugins/mk_filehandler M agents/plugins/mk_haproxy.freebsd M agents/plugins/mk_informix M agents/plugins/mk_inventory.aix M agents/plugins/mk_inventory.linux M agents/plugins/mk_inventory.solaris M agents/plugins/mk_iptables M agents/plugins/mk_logins M agents/plugins/mk_mysql M agents/plugins/mk_nfsiostat M agents/plugins/mk_omreport M agents/plugins/mk_oracle M agents/plugins/mk_oracle_crs M agents/plugins/mk_postgres M agents/plugins/mk_redis M agents/plugins/mk_sap.aix M agents/plugins/mk_sap_hana M agents/plugins/mk_saprouter M agents/plugins/mk_scaleio M agents/plugins/mk_site_object_counts M agents/plugins/mk_sshd_config M agents/plugins/mk_suseconnect M agents/plugins/mk_tsm M agents/plugins/mk_zypper M agents/plugins/netstat.aix M agents/plugins/netstat.linux M agents/plugins/netstat.solaris M agents/plugins/nfsexports M agents/plugins/nfsexports.solaris M agents/plugins/runas M agents/plugins/smart M agents/plugins/symantec_av M agents/plugins/vxvm M agents/plugins/websphere_mq M agents/plugins/zorp Log Message: ----------- Added Version to all agent plugins #3 All shell script files in agent/plugins Change-Id: I0727181311c12a753c36d2ca8821b0e317679a8b Commit: 37cd6a2f99b2c4e32c48f02d490ae2c75618807d https://github.com/tribe29/checkmk/commit/37cd6a2f99b2c4e32c48f02d490ae2c75… Author: Lukas Lengler <lukas.lengler(a)tribe29.com> Date: 2020-10-16 (Fri, 16 Oct 2020) Changed paths: M agents/plugins/asmcmd.sh M agents/plugins/db2_mem M agents/plugins/dnsclient M agents/plugins/hpux_lunstats M agents/plugins/hpux_statgrab M agents/plugins/ibm_mq M agents/plugins/jar_signature M agents/plugins/kaspersky_av M agents/plugins/lnx_quota M agents/plugins/lvm M agents/plugins/mk_apt M agents/plugins/mk_ceph M agents/plugins/mk_cups_queues M agents/plugins/mk_db2.aix M agents/plugins/mk_db2.linux M agents/plugins/mk_errpt.aix M agents/plugins/mk_filehandler M agents/plugins/mk_haproxy.freebsd M agents/plugins/mk_informix M agents/plugins/mk_inventory.aix M agents/plugins/mk_inventory.linux M agents/plugins/mk_inventory.solaris M agents/plugins/mk_iptables M agents/plugins/mk_logins M agents/plugins/mk_mysql M agents/plugins/mk_nfsiostat M agents/plugins/mk_omreport M agents/plugins/mk_oracle M agents/plugins/mk_oracle_crs M agents/plugins/mk_postgres M agents/plugins/mk_redis M agents/plugins/mk_sap.aix M agents/plugins/mk_sap_hana M agents/plugins/mk_saprouter M agents/plugins/mk_scaleio M agents/plugins/mk_site_object_counts M agents/plugins/mk_sshd_config M agents/plugins/mk_suseconnect M agents/plugins/mk_tsm M agents/plugins/mk_zypper M agents/plugins/netstat.aix M agents/plugins/netstat.linux M agents/plugins/netstat.solaris M agents/plugins/nfsexports M agents/plugins/nfsexports.solaris M agents/plugins/runas M agents/plugins/smart M agents/plugins/symantec_av M agents/plugins/vxvm M agents/plugins/websphere_mq M agents/plugins/zorp Log Message: ----------- Revert "Added Version to all agent plugins #3" Breaks Shell Check and Agent Plugin Units Tests This reverts commit 2ea4a99a45445ab6aedffd6ac336b44713190b52. Commit: 89917d6c98b246e4e382dea3fb99410a7f906d0d https://github.com/tribe29/checkmk/commit/89917d6c98b246e4e382dea3fb99410a7… Author: Simon Jess <simon.jess(a)tribe29.com> Date: 2020-10-16 (Fri, 16 Oct 2020) Changed paths: M cmk/base/discovery.py Log Message: ----------- Add comment Change-Id: I0d1a00f8162a6827ac077cff81c4db223a566da6 Commit: f9632d844b41be38449e0ab31c7318c7ff524c5b https://github.com/tribe29/checkmk/commit/f9632d844b41be38449e0ab31c7318c7f… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2020-10-16 (Fri, 16 Oct 2020) Changed paths: M .prettierrc M .sass-lint.yml M web/htdocs/themes/facelift/scss/_bi.scss M web/htdocs/themes/facelift/scss/_cmk_figures.scss M web/htdocs/themes/facelift/scss/_dashboard.scss M web/htdocs/themes/facelift/scss/_login.scss M web/htdocs/themes/facelift/scss/_logwatch.scss M web/htdocs/themes/facelift/scss/_main.scss M web/htdocs/themes/facelift/scss/_mega_menu.scss M web/htdocs/themes/facelift/scss/_mobile.scss M web/htdocs/themes/facelift/scss/_more.scss M web/htdocs/themes/facelift/scss/_node_visualization.scss M web/htdocs/themes/facelift/scss/_page_menu.scss M web/htdocs/themes/facelift/scss/_pages.scss M web/htdocs/themes/facelift/scss/_sidebar.scss M web/htdocs/themes/facelift/scss/_snapins.scss M web/htdocs/themes/facelift/scss/_status.scss M web/htdocs/themes/facelift/scss/_tables.scss M web/htdocs/themes/facelift/scss/_variables.scss M web/htdocs/themes/facelift/scss/_views.scss M web/htdocs/themes/facelift/scss/_wato.scss M web/htdocs/themes/modern-dark/scss/_variables.scss Log Message: ----------- Format scss files with prettier Adapt indentation and printWidth to be more consistent with our present style. Remove an indentation rule in .sass-lint.yml that gives false positives. Change-Id: Ifd517dfa811079afe0a3d875ea931835a4c23cdb Commit: 8dcc15759be3b5003d59daf56c0b2bdee1182cb4 https://github.com/tribe29/checkmk/commit/8dcc15759be3b5003d59daf56c0b2bdee… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-10-16 (Fri, 16 Oct 2020) Changed paths: M cmk/base/api/agent_based/register/inventory_plugins_legacy.py M cmk/base/config.py M cmk/base/inventory.py M cmk/base/inventory_plugins.py M tests/unit/conftest.py Log Message: ----------- Inventory: stop using global tree The global tree is only needed as a way to "intercept" the results of legacy inventory plugins. When legacy plugins are called, the global inventory tree will be replaced by a new tree for each plugin. Change-Id: Iebb32fb6bc1d5b70baba06e0c4ce20257367dbe1 Commit: 828699ba50e6530163b80d04b93a7af1e6864102 https://github.com/tribe29/checkmk/commit/828699ba50e6530163b80d04b93a7af1e… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-10-16 (Fri, 16 Oct 2020) Changed paths: M cmk/base/checkers/_checkers.py M cmk/base/inventory.py Log Message: ----------- inventory: refactor to make cluster case more explicit * reorganize cluster vs. real hos cases * fix "_all_sources_fail": In fact, we must not write the inventory tree to disk if any sources failed. Incompete data may lead to a flapping inventory tree and susequently to a huge inventory history. Change-Id: I5f498b1bc16adccf741d546e86daf8d85905a7bb Commit: c921b09fe87320d68e78bbdfd152c865ab82145a https://github.com/tribe29/checkmk/commit/c921b09fe87320d68e78bbdfd152c865a… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-10-16 (Fri, 16 Oct 2020) Changed paths: M .prettierrc M .sass-lint.yml A .werks/11117 M active_checks/check_mail M active_checks/check_mail_loop M active_checks/check_mailboxes M checks/check_mail M checks/check_mailboxes M cmk/base/api/agent_based/register/check_plugins_legacy.py M cmk/base/api/agent_based/register/inventory_plugins_legacy.py M cmk/base/api/agent_based/register/section_plugins_legacy/__init__.py M cmk/base/automations/check_mk.py M cmk/base/check_api.py M cmk/base/check_api_utils.py M cmk/base/checkers/_abstract.py M cmk/base/checkers/_checkers.py M cmk/base/checking.py M cmk/base/config.py R cmk/base/cpu_tracking.py M cmk/base/discovery.py M cmk/base/inventory.py M cmk/base/inventory_plugins.py M cmk/base/modes/check_mk.py M cmk/fetchers/_base.py M cmk/fetchers/controller.py M cmk/fetchers/snmp.py M cmk/gui/htmllib.py M cmk/gui/main.py M cmk/gui/plugins/wato/check_mk_configuration.py M cmk/gui/table.py M cmk/gui/utils/url_encoder.py A cmk/gui/utils/urls.py M cmk/gui/valuespec.py M cmk/gui/wato/pages/services.py M cmk/gui/watolib/automations.py M cmk/gui/watolib/rulesets.py M cmk/update_config.py A cmk/utils/cpu_tracking.py A cmk/utils/mailbox.py M tests/unit/active_checks/test_ac_check_mail.py M tests/unit/active_checks/test_ac_check_mail_loop.py M tests/unit/checks/test_check_mail.py M tests/unit/checks/test_check_mailboxes.py M tests/unit/cmk/base/api/agent_based/register/test_check_plugins_legacy.py M tests/unit/cmk/base/api/agent_based/register/test_section_plugins_legacy.py R tests/unit/cmk/base/test_cpu_tracking.py A tests/unit/cmk/utils/test_cpu_tracking.py M tests/unit/conftest.py M web/htdocs/themes/facelift/scss/_bi.scss M web/htdocs/themes/facelift/scss/_cmk_figures.scss M web/htdocs/themes/facelift/scss/_dashboard.scss M web/htdocs/themes/facelift/scss/_login.scss M web/htdocs/themes/facelift/scss/_logwatch.scss M web/htdocs/themes/facelift/scss/_main.scss M web/htdocs/themes/facelift/scss/_mega_menu.scss M web/htdocs/themes/facelift/scss/_mobile.scss M web/htdocs/themes/facelift/scss/_more.scss M web/htdocs/themes/facelift/scss/_node_visualization.scss M web/htdocs/themes/facelift/scss/_page_menu.scss M web/htdocs/themes/facelift/scss/_pages.scss M web/htdocs/themes/facelift/scss/_sidebar.scss M web/htdocs/themes/facelift/scss/_snapins.scss M web/htdocs/themes/facelift/scss/_status.scss M web/htdocs/themes/facelift/scss/_tables.scss M web/htdocs/themes/facelift/scss/_variables.scss M web/htdocs/themes/facelift/scss/_views.scss M web/htdocs/themes/facelift/scss/_wato.scss M web/htdocs/themes/modern-dark/scss/_variables.scss Log Message: ----------- Merge branch 'master' into test_weblate2 Change-Id: If24bc67da1013048ec6ae1028fa4e5129877d562 Compare: https://github.com/tribe29/checkmk/compare/38c72d28a8c7...c921b09fe873