[checkmk-commits] Reduce duplicated work for pylint.

Module: check_mk Branch: master Commit: 18d5f84f4b64cd1eb3ed4acaa6f9857b01b4addb URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=18d5f84f4b64cd… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Tue Jul 24 09:34:19 2018 +0200 Reduce duplicated work for pylint. pylint automatically recurses into packages, so repeating subpackages just creates additional useless work. In addition, the output was sometimes confusing because different parallel jobs reported the same warning multiple times. This shaves off roughly 1 min of the pylint runs. Still some cleanup to do, the overlay mechanism and symlinks are highly confusing... Change-Id: I25609eabcef63410de9db64f5385b2b362f408a6 --- tests/pylint/test_pylint_misc.py | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/tests/pylint/test_pylint_misc.py b/tests/pylint/test_pylint_misc.py index c06f0e9..41bcd09 100755 --- a/tests/pylint/test_pylint_misc.py +++ b/tests/pylint/test_pylint_misc.py @@ -12,25 +12,23 @@ def test_pylint_misc(): modules_or_packages = [ # Check_MK base "cmk_base", - "cmk_base/modes", - "cmk_base/automations", - "cmk_base/default_config", - "cmk_base/data_sources", - "enterprise/cmk_base/cee", - "enterprise/cmk_base/modes/cee.py", + # TODO: Check if this kind of "overlay" really works. + # TODO: Why do we have e.g. a symlink cmk_base/cee -> enterprise/cmk_base/cee? "enterprise/cmk_base/automations/cee.py", + "enterprise/cmk_base/cee", "enterprise/cmk_base/default_config/cee.py", + "enterprise/cmk_base/modes/cee.py", "managed/cmk_base/default_config/cme.py", # cmk module level + # TODO: This checks the whole cmk hierarchy, including things like + # cmk.gui.plugins.cron etc. Do we really want that here? + # TODO: Funny links there, see above. "cmk", - "cmk/ec", "enterprise/cmk/cee", - "enterprise/cmk/cee/liveproxy", # GUI specific "web/app/index.wsgi", - "cmk/gui", "enterprise/cmk/gui/cee", "managed/cmk/gui/cme", ]