[checkmk-commits] 5706 FIX Windows agent: fix endianness of IP addresses

Module: check_mk Branch: master Commit: 7dabf8bfc9ecb78b85ab28fa9a83355c85816886 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=7dabf8bfc9ecb7… Author: Jukka Aro <ja(a)mathias-kettner.de> Date: Mon Mar 5 17:37:01 2018 +0100 5706 FIX Windows agent: fix endianness of IP addresses The string conversion of IP addresses was falsely done manually in network byte order, resulting in incorrect ouput for IPv6 addresses. Now the conversion is done correctly. This fix will shortly break the compatibility of logwatch state files stored by the mk_logwatch plugin of previous versions of the Windows agent as they use the remote IP address(es) of the monitoring host(s). When upgrading to the new agent, those log entries that are created exactly after stopping the old agent but before starting the new agent will be lost in monitoring. After starting the new agent, monitoring should work as before. --- .werks/5706 | 22 ++++ agents/windows/ListenSocket.cc | 25 ----- agents/windows/ListenSocket.h | 3 - agents/windows/WinApi.cc | 8 ++ agents/windows/WinApi.h | 4 + agents/windows/WinApiAdaptor.h | 7 ++ agents/windows/build_version | 2 +- agents/windows/check_mk_agent.cc | 19 +--- agents/windows/stringutil.cc | 133 ++++++++++++++++++++++- agents/windows/stringutil.h | 27 +++++ agents/windows/test/MockWinApi.h | 5 + agents/windows/test/stringutilTest.cc | 192 ++++++++++++++++++++++++++++++++++ 12 files changed, 403 insertions(+), 44 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=7dabf8bfc9…