[checkmk-commits] [tribe29/checkmk] 48de0a: Refactor tolerance_check to allow checking differe...

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: 48de0ab84dd7678e82229d1c18ebda44e166867f https://github.com/tribe29/checkmk/commit/48de0ab84dd7678e82229d1c18ebda44e… Author: Rebekka Seltmann &lt;rebekka.seltmann(a)tribe29.com&gt; Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: M cmk/base/plugins/agent_based/ntp.py M cmk/base/plugins/agent_based/timesyncd.py M cmk/base/plugins/agent_based/utils/timesync.py M tests/unit/cmk/base/plugins/agent_based/test_ntp.py M tests/unit/cmk/base/plugins/agent_based/utils/test_timesync.py Log Message: ----------- Refactor tolerance_check to allow checking different metrics CMK-11089 Change-Id: I8c99c41d720b3ae3f526c2de41d897bc1cc79738 Commit: e558eca99bf11a43f24ac9d4d40e20226ba34c7b https://github.com/tribe29/checkmk/commit/e558eca99bf11a43f24ac9d4d40e20226… Author: Rebekka Seltmann &lt;rebekka.seltmann(a)tribe29.com&gt; Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: M cmk/base/plugins/agent_based/timesyncd.py M tests/unit/cmk/base/plugins/agent_based/test_timesyncd.py Log Message: ----------- Let timesyncd service become CRIT if NTP server not reachable to synchronize CMK-11089 Change-Id: Ia045d81b9cd5bd859719def7affc991642515ef4 Commit: dcde7e59e0ef8dce0bb023d7947cb2f57c290ba1 https://github.com/tribe29/checkmk/commit/dcde7e59e0ef8dce0bb023d7947cb2f57… Author: Rebekka Seltmann &lt;rebekka.seltmann(a)tribe29.com&gt; Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: M agents/check_mk_agent.linux M cmk/base/plugins/agent_based/timesyncd.py M cmk/gui/plugins/metrics/network.py M cmk/gui/plugins/wato/check_parameters/timesyncd.py M tests/unit/cmk/base/plugins/agent_based/test_timesyncd.py Log Message: ----------- Add NTPMessage from timedatectl to linux agent and monitor time since last NTPMessage CMK-11089 Change-Id: I2de33943ffcdff63f69b5c868baa3873a1ba4db2 Commit: b790a7be625485eea120242ecd1aa7b03e9f4c24 https://github.com/tribe29/checkmk/commit/b790a7be625485eea120242ecd1aa7b03… Author: Rebekka Seltmann &lt;rebekka.seltmann(a)tribe29.com&gt; Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: M agents/check_mk_agent.linux Log Message: ----------- Use /run/systemd/timesync/synchronized to get last sync time if available instead of /var/lib/systemd/timesync/clock which will not be available in newer systemd versions CMK-11089 Change-Id: I7287f95e77617d6c7934a90203ed0fb9430bef1f Commit: e4bd9472d5e456c72bfe1218f21ac74f2d1750cd https://github.com/tribe29/checkmk/commit/e4bd9472d5e456c72bfe1218f21ac74f2… Author: Rebekka Seltmann &lt;rebekka.seltmann(a)tribe29.com&gt; Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: M cmk/base/plugins/agent_based/timesyncd.py M tests/unit/cmk/base/plugins/agent_based/test_timesyncd.py Log Message: ----------- Do not set check limits for time since last sync per default Since the time can not reliably be used to check if sync occurred (limited error messages when adjusting system clock depending on systemd version). Main focus should be on monitoring time offset CMK-11089 Change-Id: I5d860a51eb5df32058f89c4fda583261698a22cc Commit: 4d2bc335d81e3dcc8e664ee6d63b41864fc7f028 https://github.com/tribe29/checkmk/commit/4d2bc335d81e3dcc8e664ee6d63b41864… Author: Rebekka Seltmann &lt;rebekka.seltmann(a)tribe29.com&gt; Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: A .werks/14967 Log Message: ----------- 14967 Timesyncd check plugin: Include metrics for sync times, change check behavior when NTP server not reachable and future-proofing Since at least systemd v250 <tt>/var/lib/systemd/timesync/clock</tt> should no longer be used to determine the time since the last synchronisation, instead the modification time of <tt>/run/systemd/timesync/synchronized</tt> is now used. To monitor the reliability of this time, this werk also introduces two new metrics: LI: Time since last synchronisation: The modification time of <tt>/run/systemd/timesync/synchronized</tt> if available, otherwise <tt>/var/lib/systemd/timesync/clock</tt>. LI: Time since last NTPMessage: When the last message from the NTP server was received. To have these metrics available, the Checkmk linux agent needs to be updated, otherwise only the time since last synchronisation based on <tt>/var/lib/systemd/timesync/clock</tt> will be shown. Since the modification time of /var/lib/systemd/timesync/clock can at times be unsuitable to monitor when synchronization occurred (due to limited error handling in earlier systemd version), the default threshold for the allowed duration since last synchronisation has been removed. If you want to apply thresholds to the time since last synchronisation you now have to enable the rule manually. The default thresholds for the allowed duration since last NTPMessage have been set to 1h (WARN) and 2h (CRIT). Additionally, the behavior of the check was changed to go to CRIT when the NTP server could not be reached for synchronisation. In the course of the werk the rendering of the jitter was also corrected to show a time span instead of a date. CMK-11089 Change-Id: Iffa13ab0851e557e785905b09739ef421b73538a Compare: https://github.com/tribe29/checkmk/compare/431dde1c9e4d...4d2bc335d81e