[checkmk-commits] [tribe29/checkmk] b4f70e: KUBE: fix false naming due copy-pasta in kube_name...

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: b4f70ea3e3aba50e3612a20ba711490f5de5c877 https://github.com/tribe29/checkmk/commit/b4f70ea3e3aba50e3612a20ba711490f5… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-05-04 (Wed, 04 May 2022) Changed paths: M cmk/base/plugins/agent_based/kube_namespace_info.py M tests/unit/cmk/base/plugins/agent_based/test_kube_namespace_info.py Log Message: ----------- KUBE: fix false naming due copy-pasta in kube_namespace_info Change-Id: I07569d66299040862bfc31f3b6ca2496670ea333 Commit: 6b79bae7f1296320ec231a954a5641ac6979fa6e https://github.com/tribe29/checkmk/commit/6b79bae7f1296320ec231a954a5641ac6… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-05-04 (Wed, 04 May 2022) Changed paths: M cmk/base/plugins/agent_based/utils/kube.py M cmk/special_agents/utils_kubernetes/schemata/api.py Log Message: ----------- transform: fix incorrect schemata docstrings for Labels Fix consists of two parts: - validation_value was incorrect, because it excluded empty values. - Changes in cmk/special_agents/utils_kubernetes/schemata/api.py should match those in cmk/base/agent_based/plugins/utils/kube.py They now match. CMK-9882 Change-Id: Ie965f0d6ea776fc2553eff6343c10800cc351a40 Commit: fa96f8ecad032ab6736ee2225fe014b3cbea162a https://github.com/tribe29/checkmk/commit/fa96f8ecad032ab6736ee2225fe014b3c… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-05-04 (Wed, 04 May 2022) Changed paths: M tests/unit/cmk/special_agents/agent_kubernetes/test_agent_kube_deployments.py A tests/unit/cmk/special_agents/agent_kubernetes/test_agent_kube_namespace.py M tests/unit/cmk/special_agents/agent_kubernetes/test_agent_kubernetes_api_nodes.py M tests/unit/cmk/special_agents/agent_kubernetes/test_agent_kubernetes_api_pods.py Log Message: ----------- KUBE: add test parse_metadata parse_metadata is now tested for Deployments and Pods. CMK-9882 Change-Id: I01aacf6485682422b7708a07595142f028899c5d Commit: 330c2d44953c0e3e96db6ad8c6e97826cfa114e9 https://github.com/tribe29/checkmk/commit/330c2d44953c0e3e96db6ad8c6e97826c… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-05-04 (Wed, 04 May 2022) Changed paths: M tests/unit/cmk/special_agents/agent_kube/conftest.py M tests/unit/cmk/special_agents/agent_kube/factory.py M tests/unit/cmk/special_agents/agent_kube/test_node.py Log Message: ----------- KUBE: move api_to_agent_pod out of conftest.py Change-Id: I07c29364ccec12a7aa5f5961a9988e1c57845224 Commit: 9a08581ac1cc5a995601a8c4edae6c4e75397430 https://github.com/tribe29/checkmk/commit/9a08581ac1cc5a995601a8c4edae6c4e7… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-05-04 (Wed, 04 May 2022) Changed paths: M tests/unit/cmk/special_agents/agent_kubernetes/test_agent_kube.py Log Message: ----------- KUBE: use Pydantic factories instead of default_pod Using factories improves maintainability. This is because new fields no longer affect the test (they are automatically populated). We also introduce the AAA pattern. Change-Id: I05a93978bfc039c52a1f023ce2219a96a29f6bb7 Commit: 9e7b006b3c0ead981c37d1e121b5ac2a6ea4643b https://github.com/tribe29/checkmk/commit/9e7b006b3c0ead981c37d1e121b5ac2a6… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-05-04 (Wed, 04 May 2022) Changed paths: M tests/unit/cmk/special_agents/agent_kube/test_agent_kube_api.py R tests/unit/cmk/special_agents/agent_kubernetes/test_agent_kube.py A tests/unit/cmk/special_agents/agent_kubernetes/test_agent_kube_filter_from_namespace.py Log Message: ----------- KUBE: refactor _collect_cpu_resources test We use Pydantic factories instead of a handrolled function. Moreover, we now test in a more uniform fashion and test _collect_memory_resources alongside. Moreover, the test is moved to the same locations as test_collect_workload_resources_from_api_pods and renamed accordingly. Finally, the original test file is renamed to reflect the tests is now contains. CMK-9525 Change-Id: If1c0d2527b5532ba072226044f3a50eb83395dc6 Commit: c7fc1b30c91a13ef9fe788c9424cb0053d80881f https://github.com/tribe29/checkmk/commit/c7fc1b30c91a13ef9fe788c9424cb0053… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-05-04 (Wed, 04 May 2022) Changed paths: M cmk/special_agents/utils_kubernetes/schemata/api.py M cmk/special_agents/utils_kubernetes/transform.py Log Message: ----------- KUBE api: addition of priority_class_name to pod spec Change-Id: I6b5d0c6033706fa7a97e3a951733553413d77eb4 Commit: affff126d9141a92c99e030625924f6d22892c67 https://github.com/tribe29/checkmk/commit/affff126d9141a92c99e030625924f6d2… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-05-04 (Wed, 04 May 2022) Changed paths: M cmk/special_agents/utils_kubernetes/schemata/api.py M cmk/special_agents/utils_kubernetes/transform.py Log Message: ----------- KUBE api: addition of active_deadline_seconds to pod spec Change-Id: Ibcb960ed758c7cc8259d12218cdedf3c5dee7c15 Commit: d61596d9349d72f7dfa26e7aedf841a865b4544a https://github.com/tribe29/checkmk/commit/d61596d9349d72f7dfa26e7aedf841a86… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-05-04 (Wed, 04 May 2022) Changed paths: M cmk/special_agents/agent_kube.py Log Message: ----------- agent_kube: change PerformancePod from NamedTuple to BaseModel Change-Id: Ia8286e91a0c071dd0c5ed74d2e6f9b7401f3d7af Commit: 59af9a3534817b4e4d4339734ddcbfdcc713520d https://github.com/tribe29/checkmk/commit/59af9a3534817b4e4d4339734ddcbfdcc… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-05-04 (Wed, 04 May 2022) Changed paths: M cmk/special_agents/agent_kube.py M tests/unit/cmk/special_agents/agent_kube/factory.py M tests/unit/cmk/special_agents/agent_kube/test_agent_kube_performance.py Log Message: ----------- agent_kube: refactor write performance sections related functions Change-Id: I6f6e98ecc007e9149333cec95dc76e382f5ccc8b Commit: 86a42a7c4cd31f271827b6504ea41c9ad3f5156f https://github.com/tribe29/checkmk/commit/86a42a7c4cd31f271827b6504ea41c9ad… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-05-04 (Wed, 04 May 2022) Changed paths: M cmk/special_agents/agent_kube.py Log Message: ----------- agent_kube: modify _write_sections to only output sections if content is not None Change-Id: Icd475af96081742eb0eab579c0940e8b30d60bbf Commit: cd49f7e53c396cd81284e07f91c1df2c42446767 https://github.com/tribe29/checkmk/commit/cd49f7e53c396cd81284e07f91c1df2c4… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-05-04 (Wed, 04 May 2022) Changed paths: M cmk/special_agents/agent_kube.py M cmk/special_agents/utils_kubernetes/api_server.py M cmk/special_agents/utils_kubernetes/schemata/api.py M cmk/special_agents/utils_kubernetes/transform.py Log Message: ----------- agent_kube: addition of resource quotas related sections Change-Id: I05f211cb39ea152e96b9029628de26b4d042d17e Commit: ffc17ad14b6352ed0df29818b4d373918061772c https://github.com/tribe29/checkmk/commit/ffc17ad14b6352ed0df29818b4d373918… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-05-04 (Wed, 04 May 2022) Changed paths: M tests/unit/cmk/special_agents/agent_kube/factory.py A tests/unit/cmk/special_agents/agent_kube/test_namespace.py Log Message: ----------- test_namespace: addition of tests for resource_quota related functions Change-Id: I8037071f970e31d25248687d3a2f7d56c39fe337 Commit: a601eba8eb070e50221dcdde95c1ef437545d257 https://github.com/tribe29/checkmk/commit/a601eba8eb070e50221dcdde95c1ef437… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-05-04 (Wed, 04 May 2022) Changed paths: M cmk/special_agents/agent_kube.py M cmk/special_agents/utils_kubernetes/schemata/api.py M cmk/special_agents/utils_kubernetes/transform.py M tests/unit/cmk/special_agents/agent_kubernetes/test_agent_kube_daemon_sets.py M tests/unit/cmk/special_agents/agent_kubernetes/test_agent_kube_deployments.py M tests/unit/cmk/special_agents/agent_kubernetes/test_agent_kube_namespace.py M tests/unit/cmk/special_agents/agent_kubernetes/test_agent_kube_statefulsets.py M tests/unit/cmk/special_agents/agent_kubernetes/test_agent_kubernetes_api_nodes.py M tests/unit/cmk/special_agents/agent_kubernetes/test_agent_kubernetes_api_pods.py Log Message: ----------- transform: parse annotations CMK-9882 Change-Id: Ie0c86ecd9e93ee637502b3bc35f679dd01c9cebe Commit: 6a4aca8ba2cc5034b7d1a52189e7141a973868c2 https://github.com/tribe29/checkmk/commit/6a4aca8ba2cc5034b7d1a52189e7141a9… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-05-04 (Wed, 04 May 2022) Changed paths: M cmk/base/plugins/agent_based/kube_daemonset_info.py M cmk/base/plugins/agent_based/kube_deployment_info.py M cmk/base/plugins/agent_based/kube_statefulset_info.py M cmk/base/plugins/agent_based/utils/kube.py M cmk/base/plugins/agent_based/utils/kube_info.py M cmk/special_agents/agent_kube.py M cmk/special_agents/utils_kubernetes/schemata/section.py M tests/unit/cmk/base/plugins/agent_based/test_inventory_kube_daemonset.py M tests/unit/cmk/base/plugins/agent_based/test_inventory_kube_deployment.py M tests/unit/cmk/base/plugins/agent_based/test_inventory_kube_statefulset.py M tests/unit/cmk/base/plugins/agent_based/test_kube_daemonset_info.py M tests/unit/cmk/base/plugins/agent_based/test_kube_deployment_info.py M tests/unit/cmk/base/plugins/agent_based/test_kube_statefulset_info.py M tests/unit/cmk/base/plugins/agent_based/test_section_host_label_doc.py Log Message: ----------- KUBE: add host label cmk/kubernetes/annotation to controllers CMK-9882 Change-Id: I24c01d815dc4c2732de42fbb6fc2bcd5ba406c8d Commit: 5ff7fe28552ac5f144da34e9ed04daa80e238e94 https://github.com/tribe29/checkmk/commit/5ff7fe28552ac5f144da34e9ed04daa80… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-05-04 (Wed, 04 May 2022) Changed paths: M cmk/base/plugins/agent_based/kube_namespace_info.py M cmk/base/plugins/agent_based/utils/kube.py M cmk/special_agents/agent_kube.py M cmk/special_agents/utils_kubernetes/schemata/section.py M tests/unit/cmk/base/plugins/agent_based/test_inventory_kube_namespace.py M tests/unit/cmk/base/plugins/agent_based/test_kube_namespace_info.py Log Message: ----------- KUBE: add host label cmk/kubernetes/annotation to Namespace CMK-9882 Change-Id: Iea64438d63e9641d7619bf64ac2f68c7eb68c455 Commit: 6b4a6787bc78f4a8c4e4de30ebb9ea5142d80371 https://github.com/tribe29/checkmk/commit/6b4a6787bc78f4a8c4e4de30ebb9ea514… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-05-04 (Wed, 04 May 2022) Changed paths: M cmk/base/plugins/agent_based/kube_node_info.py M cmk/base/plugins/agent_based/utils/kube.py M cmk/special_agents/agent_kube.py M cmk/special_agents/utils_kubernetes/schemata/section.py M tests/unit/cmk/base/plugins/agent_based/kube_node_info.py M tests/unit/cmk/base/plugins/agent_based/test_inventory_kube_node.py Log Message: ----------- KUBE: add host label cmk/kubernetes/annotation to Node CMK-9882 Change-Id: Ic1b50a289f941184c2e45d731f0f8c86b28c3d80 Commit: 98cf54c6290216c682fafbb6362e4ee46aa620c5 https://github.com/tribe29/checkmk/commit/98cf54c6290216c682fafbb6362e4ee46… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-05-04 (Wed, 04 May 2022) Changed paths: M cmk/base/plugins/agent_based/kube_pod_info.py M cmk/base/plugins/agent_based/utils/kube.py M cmk/special_agents/agent_kube.py M cmk/special_agents/utils_kubernetes/schemata/section.py M tests/unit/cmk/base/plugins/agent_based/test_inventory_kube_pod.py M tests/unit/cmk/base/plugins/agent_based/test_kube_pod_info.py Log Message: ----------- KUBE: add host label cmk/kubernetes/annotation to Pod CMK-9882 Change-Id: I86ab96a3a9eb2f68e8c90d7a3cebe50850a87b46 Commit: 8d648c5916c931a84640e1a0b37d7d2c633ab731 https://github.com/tribe29/checkmk/commit/8d648c5916c931a84640e1a0b37d7d2c6… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-05-04 (Wed, 04 May 2022) Changed paths: A .werks/14121 M checks/agent_kube M cmk/base/plugins/agent_based/kube_namespace_info.py M cmk/base/plugins/agent_based/kube_node_info.py M cmk/base/plugins/agent_based/kube_pod_info.py M cmk/base/plugins/agent_based/utils/kube.py M cmk/base/plugins/agent_based/utils/kube_info.py M cmk/gui/plugins/wato/datasource_programs.py M cmk/special_agents/agent_kube.py M cmk/special_agents/utils_kubernetes/schemata/section.py M tests/unit/checks/test_agent_kube.py M tests/unit/cmk/special_agents/agent_kube/test_daemon_set.py M tests/unit/cmk/special_agents/agent_kube/test_deployment.py M tests/unit/cmk/special_agents/agent_kube/test_node.py M tests/unit/cmk/special_agents/agent_kube/test_statefulset.py Log Message: ----------- 14121 KUBE: Import annotations as host labels By default, Checkmk does not import Kubernetes annotations. With this werk, this bevaviour can be configured via the option `Import annotations as host labels` in the rule `Kubernetes`. The option allows importing any Kubernetes annotation that is a valid Kubernetes label. These imported annotations are added as host labels to their respective piggyback host using the syntax `cmk/kubernetes/annotation/{key}:{value}`. You can further restrict the imported annotations by specifying a pattern which Checkmk searches for in the key of the annotation. Werk was implemented via the following Change-Ids: I9530f13a1a4c4ead3ea214762fbdc3e4c5e5bdd4 I86ab96a3a9eb2f68e8c90d7a3cebe50850a87b46 Ic1b50a289f941184c2e45d731f0f8c86b28c3d80 Iea64438d63e9641d7619bf64ac2f68c7eb68c455 I24c01d815dc4c2732de42fbb6fc2bcd5ba406c8d Ie0c86ecd9e93ee637502b3bc35f679dd01c9cebe The change in this commit allows users to selectively import annotations. CMK-9882 Change-Id: I9530f13a1a4c4ead3ea214762fbdc3e4c5e5bdd4 Commit: ab56b2e3f4775890d4eb8542739f04c5dd7aa792 https://github.com/tribe29/checkmk/commit/ab56b2e3f4775890d4eb8542739f04c5d… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-05-04 (Wed, 04 May 2022) Changed paths: R tests/unit/cmk/base/plugins/agent_based/kube_node_info.py A tests/unit/cmk/base/plugins/agent_based/test_kube_node_info.py Log Message: ----------- KUBE: fix incorrectly named test file Some non-essential scripts assume that test files start with test. Change-Id: Icb19c9370db4c482f45f2430bcbcc022ae11a025 Commit: 4f2ff81ff8f176717c0877edb34b1181a9652438 https://github.com/tribe29/checkmk/commit/4f2ff81ff8f176717c0877edb34b1181a… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-05-04 (Wed, 04 May 2022) Changed paths: M cmk/special_agents/agent_kube.py Log Message: ----------- KUBE: improved typing for monitored_objects Accessing arguments.monitored_objects would sometimes lead to bugs. For example, writing `"node" in arguments.monitored_objects` instead of `"nodes" in arguments.monitored_objects` With this change, typos become impossible, when using the enum. Moreover, the agent now throws an error, if an unknown monitored object is provided. Change-Id: Id788afdc8cc1848bc68aa55134174e3c0cd6e92f Compare: https://github.com/tribe29/checkmk/compare/f8d652eeac36...4f2ff81ff8f1