[checkmk-commits] Prevent password form completion on host search page

Module: check_mk Branch: master Commit: 8b9dbd0a3ecda222d3e25ad4c25f7df0de72a729 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8b9dbd0a3ecda2… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jan 27 08:25:05 2016 +0100 Prevent password form completion on host search page --- .bugs/2358 | 8 +++++--- .bugs/627 | 8 ++++++-- .bugs/787 | 7 +++++-- .bugs/879 | 7 +++++-- .bugs/888 | 7 +++++-- .bugs/957 | 7 +++++-- web/htdocs/wato.py | 1 + 7 files changed, 32 insertions(+), 13 deletions(-) diff --git a/.bugs/2358 b/.bugs/2358 index 68b85c3..9d2c1a3 100644 --- a/.bugs/2358 +++ b/.bugs/2358 @@ -1,8 +1,10 @@ Title: "Invalid check parameter" error in "Check Parameters" column in wato Component: wato -State: open +Class: bug +State: works4me Date: 2015-08-31 16:05:11 Targetversion: 1.2.7 -Class: bug -In the service list of a host in wato, if the "Show check parameters" button is pressed, many checks (i.e. cpu.loads, mounts) only show an error message in the new column: "Invalid check parameter: ..." \ No newline at end of file +In the service list of a host in wato, if the "Show check parameters" button is pressed, many checks (i.e. cpu.loads, mounts) only show an error message in the new column: "Invalid check parameter: ..." +2016-01-26 15:04:17: changed state open -> works4me +Has already been fixed. diff --git a/.bugs/627 b/.bugs/627 index ac19cdf..be3606a 100644 --- a/.bugs/627 +++ b/.bugs/627 @@ -1,10 +1,14 @@ Title: Use language name from .mo or .po? Component: multisite -State: open +Class: cleanup +State: wontfix Date: 2012-01-25 18:58:02 Targetversion: future -Class: cleanup The .po files contains meta-Data to the translation. There is a file "Language: ". Isn't it possible to extract the language alias name from that instead of keeping this in a separate non-standard file? + +2016-01-26 15:07:14: changed state open -> wontfix +It seems to be ok like it is for a long time now. I don't see a huge +benefit to change this. diff --git a/.bugs/787 b/.bugs/787 index 1621269..4d63389 100644 --- a/.bugs/787 +++ b/.bugs/787 @@ -1,9 +1,9 @@ Title: Perfdata varname of df should be fixed to 'size' Component: checks -State: open +Class: cleanup +State: wontfix Date: 2012-07-28 20:07:03 Targetversion: 1.2.3i1 -Class: cleanup Currently the fs check uses the name of the mount point as the variable name for the filesystem performance data. In the case of Windows mount points @@ -12,3 +12,6 @@ there is a backslash included which makes everything problematic. There is just one drawback: People with multiple RRDs will loose their filesystem history once again... :-( For some time we could offer an option that switches to the old format. + +2016-01-26 15:08:30: changed state open -> wontfix +This problem is not really problematic anymore. Won't change anything here. diff --git a/.bugs/879 b/.bugs/879 index 96a3c4a..20ea633 100644 --- a/.bugs/879 +++ b/.bugs/879 @@ -1,11 +1,14 @@ Title: jolokia agent: introduce timeouts Component: checks -State: open +Class: nastiness +State: done Date: 2012-11-20 17:03:46 Targetversion: future -Class: nastiness If one instance is e.g. out of memory then it does not answer timely on the jolokia URL. The agent plugin needs to introduce a (short) timeout and proceed then with the further instances. Otherwise the complete agent will hang and the remaining checks missing. + +2016-01-26 15:09:39: changed state open -> done +Has already been fixed. diff --git a/.bugs/888 b/.bugs/888 index 983b80a..cbe9f18 100644 --- a/.bugs/888 +++ b/.bugs/888 @@ -1,9 +1,9 @@ Title: EC Forwarding: Nagios fails if contactgroup is empty Component: wato -State: open +Class: nastiness +State: wontfix Date: 2013-02-14 10:12:11 Targetversion: 1.2.3 -Class: nastiness The problem is that Check_MK does not create a contact group if no hosts and services are assigned to it. We could check @@ -14,3 +14,6 @@ that and make Check_MK behave like that in OMD context. For WATO it is not easily possible to savely know wether a contact group will be empty, since many aspects are involved (only_hosts, D-WATO, manual confiugration out of WATO, etc.) + +2016-01-26 15:10:36: changed state open -> wontfix +Is not a problem anymore. diff --git a/.bugs/957 b/.bugs/957 index 52ed9a7..822606b 100644 --- a/.bugs/957 +++ b/.bugs/957 @@ -1,12 +1,15 @@ Title: field author in check manpages is mandatory Component: checks -State: open +Class: cleanup +State: done Date: 2013-07-05 12:33:13 Targetversion: 1.2.3 -Class: cleanup author field should no longer be used but cmk -M declares it as mandatory cmk -M mysql.connections Invalid check manpage /omd/sites/bs1st/share/check_mk/checkman/mysql.connections: missing 'author' + +2016-01-26 15:14:27: changed state open -> done +Already fixed. diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index 504aa60..10a7745 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -2934,6 +2934,7 @@ def mode_search(phase): ## # Show search form html.begin_form("edit_host", method="GET") + html.prevent_password_auto_completion() forms.header(_("General Properties")) forms.section(_("Hostname")) html.text_input("host_search_host")