11 Oct
2021
11 Oct
'21
4:42 a.m.
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: afd6ad15a874e92063fa7f6c3af1541d5012ac86
https://github.com/tribe29/checkmk/commit/afd6ad15a874e92063fa7f6c3af1541d5…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2021-10-11 (Mon, 11 Oct 2021)
Changed paths:
M livestatus/src/AttributeListAsIntColumn.cc
M livestatus/src/AttributeListAsIntColumn.h
A livestatus/src/AttributeListColumnUtils.cc
A livestatus/src/AttributeListColumnUtils.h
M livestatus/src/AttributeListLambdaColumn.h
M livestatus/src/Makefile.am
Log Message:
-----------
Move useful function to their own file
Currently, the `AttributeListAsIntColumn::createFilter()` implementation
is shared with `AttributeBitmaskLambdaColumn` over inheritance.
This patch moves this implementation out of `AttributeListAsIntColumn`
to break the dependency and remove the artificial coupling and complexity.
The severance of the inheritance relationship is done elsewhere.
Also note that `AttributeListColumn` also uses the filter from
`AttributeListAsIntColumn`.
CMK-7076
Change-Id: I374a9809b977e6d407dfcca309a66c76c7619c05
Commit: ebcebdda658532d869662f6c5625cda63fc2929d
https://github.com/tribe29/checkmk/commit/ebcebdda658532d869662f6c5625cda63…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2021-10-11 (Mon, 11 Oct 2021)
Changed paths:
M livestatus/src/AttributeListLambdaColumn.h
Log Message:
-----------
Let AttributeBitmaskLambdaColumn inherit IntColumn
`AttributeBitmaskLambdaColumn` was inheriting another column:
`AttributeListAsIntColumn` but the only code they shared was
`createFilter()`. This patch removes the coupling between
these two columns. This is the first step before porting
`AttributeBitmaskLambdaColumn` to the new API.
CMK-7076
Change-Id: Iedace4f079f2d2eb1b6e7552f526e2409eec5442
Commit: 0508d9c46d829855f4b3c02971f846723c722fc0
https://github.com/tribe29/checkmk/commit/0508d9c46d829855f4b3c02971f846723…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2021-10-11 (Mon, 11 Oct 2021)
Changed paths:
M livestatus/src/AttributeListLambdaColumn.h
M livestatus/src/TableContacts.cc
Log Message:
-----------
Port AttributeBitmaskLambdaColumn to new column API
CMK-7076
Change-Id: I8530ce16a46d78bae859fefd51645cd647178e7b
Commit: 3379e15ac9ed7086944d72e3e5b085f548df2b62
https://github.com/tribe29/checkmk/commit/3379e15ac9ed7086944d72e3e5b085f54…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2021-10-11 (Mon, 11 Oct 2021)
Changed paths:
R livestatus/src/AttributeListColumn.cc
M livestatus/src/AttributeListColumn.h
M livestatus/src/Makefile.am
Log Message:
-----------
Inline trivial delegation
This underlines the similarities between `AttributeListColumn` and
`AttributeListColumn2`. Also, there is practically no advantage
in hiding such a simple delegation.
CMK-7076
Change-Id: I7e01ab13336901009831634c396f9c1f0a94c35d
Commit: b99a82cff777d5c5a2796f4fe7d7e308feacbba2
https://github.com/tribe29/checkmk/commit/b99a82cff777d5c5a2796f4fe7d7e308f…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2021-10-11 (Mon, 11 Oct 2021)
Changed paths:
M livestatus/src/AttributeListAsIntColumn.cc
M livestatus/src/AttributeListAsIntColumn.h
M livestatus/src/AttributeListColumn.h
Log Message:
-----------
Remove AttributeListAsIntColumn::getAttributes
The method was used in another column and this makes the implementation
of `AttributeListColumn` and `AttributeListColumn2` clearly identical.
CMK-7076
Change-Id: I71dfdca1fed0c4290d352eff0ed1e7603c735bc7
Commit: f6ac293bcd2142c63812fa476305f08301a362ef
https://github.com/tribe29/checkmk/commit/f6ac293bcd2142c63812fa476305f0830…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2021-10-11 (Mon, 11 Oct 2021)
Changed paths:
M livestatus/src/TableContacts.cc
Log Message:
-----------
Clarify mapping relationship for Attributes
CMK-7076
Change-Id: Iae864e2da0882189a48c6a3295e087c7bac6314c
Commit: 1648fe360d035ac371ccd787203878ff8e707161
https://github.com/tribe29/checkmk/commit/1648fe360d035ac371ccd787203878ff8…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2021-10-11 (Mon, 11 Oct 2021)
Changed paths:
M livestatus/src/TableHosts.cc
M livestatus/src/TableServices.cc
Log Message:
-----------
Remove AttributeListAsIntColumn callers
They are replaced with an equivalent `AttributeBitmaskLambdaColumn` that
inherits `IntColumn::Callback<T, Default>`.
CMK-7076
Change-Id: I79b07800a4163b07014ddcd93f2ef1bb4de9a718
Commit: 05a045e3534794ccf16630a16887444fa53b3d7e
https://github.com/tribe29/checkmk/commit/05a045e3534794ccf16630a16887444fa…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2021-10-11 (Mon, 11 Oct 2021)
Changed paths:
M livestatus/src/AttributeListLambdaColumn.h
M livestatus/src/IntLambdaColumn.h
M livestatus/src/TableContacts.cc
M livestatus/src/TableHosts.cc
M livestatus/src/TableServices.cc
Log Message:
-----------
Remove AttributeListColumn callers
They are replaced with an equivalent `AttributeListColumn2`
CMK-7076
Change-Id: I0b30fcd510d6fcc8cb04f0e4ecc7bfc23cee1adb
Commit: 89ef2fdec8dd473fd4785ff87fd545b147892ec8
https://github.com/tribe29/checkmk/commit/89ef2fdec8dd473fd4785ff87fd545b14…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2021-10-11 (Mon, 11 Oct 2021)
Changed paths:
R livestatus/src/AttributeListAsIntColumn.cc
R livestatus/src/AttributeListAsIntColumn.h
R livestatus/src/AttributeListColumn.h
M livestatus/src/AttributeListLambdaColumn.h
M livestatus/src/Makefile.am
Log Message:
-----------
Remove definitions for obsolete columns
CMK-7076
Change-Id: Ie6fbf50eb2a806ca3da538b466824f50b436b0ce
Commit: d0ee2d97dd6cdf28aba95d3872b648d0c9f8dae9
https://github.com/tribe29/checkmk/commit/d0ee2d97dd6cdf28aba95d3872b648d0c…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2021-10-11 (Mon, 11 Oct 2021)
Changed paths:
M livestatus/src/AttributeListLambdaColumn.h
R livestatus/src/IntColumn.cc
M livestatus/src/IntColumn.h
R livestatus/src/IntLambdaColumn.h
M livestatus/src/Makefile.am
M livestatus/src/TableComments.cc
M livestatus/src/TableContacts.cc
M livestatus/src/TableDowntimes.cc
M livestatus/src/TableEventConsole.h
M livestatus/src/TableEventConsoleEvents.cc
M livestatus/src/TableEventConsoleHistory.cc
M livestatus/src/TableEventConsoleRules.cc
M livestatus/src/TableEventConsoleStatus.cc
M livestatus/src/TableHostGroups.cc
M livestatus/src/TableHosts.cc
M livestatus/src/TableLog.cc
M livestatus/src/TableServiceGroups.cc
M livestatus/src/TableServices.cc
M livestatus/src/TableStateHistory.cc
M livestatus/src/TableStatus.cc
M livestatus/src/test/test_IntColumn.cc
Log Message:
-----------
Remove obsolete IntColumn
CMK-7076
Change-Id: Id2a7bd97e75c84332d6816dc47d406473fc7fadb
Commit: 56c2e2bc21f57a31f7304732c08dd350d54e1f73
https://github.com/tribe29/checkmk/commit/56c2e2bc21f57a31f7304732c08dd350d…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2021-10-11 (Mon, 11 Oct 2021)
Changed paths:
R livestatus/src/AttributeListColumnUtils.cc
R livestatus/src/AttributeListColumnUtils.h
A livestatus/src/AttributeListLambdaColumn.cc
M livestatus/src/AttributeListLambdaColumn.h
M livestatus/src/Makefile.am
Log Message:
-----------
Merge Attribute*Utils into Attribute*Column
There no remains but one user -> cohesion.
CMK-7076
Change-Id: Id80e4620e61061d4bc0f805724ff8feb92453f58
Compare: https://github.com/tribe29/checkmk/compare/d8338c19cdb4...56c2e2bc21f5