[checkmk-commits] [Checkmk/checkmk] bd3ac2: plugins test: Unskipped checks

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: bd3ac2dad2659d88afb8995218250a8d54b0c084 https://github.com/Checkmk/checkmk/commit/bd3ac2dad2659d88afb8995218250a8d5… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2023-12-15 (Fri, 15 Dec 2023) Changed paths: M tests/plugins_integration/checks.py Log Message: ----------- plugins test: Unskipped checks Change-Id: I6ac4173931a76405be2a86e2bad71d28946d9c7d Commit: 44489c8044f27eb3b53ff12108cbc6a165cc326f https://github.com/Checkmk/checkmk/commit/44489c8044f27eb3b53ff12108cbc6a16… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2023-12-15 (Fri, 15 Dec 2023) Changed paths: M tests/plugins_integration/checks.py Log Message: ----------- plugins test: abort check if canon is not found If a canon is not found in the static references, the test displayed an explicit error message about this and then also returned diff for an empty file vs. the returned result. This is pointless, so we bail out immediately when the canon is not found. Change-Id: Id9769d63d7357a268ed10b88dda2da322361200b Commit: bc47fd7ba5e5c913e814dabd4d70cd0f9fbc48f7 https://github.com/Checkmk/checkmk/commit/bc47fd7ba5e5c913e814dabd4d70cd0f9… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2023-12-15 (Fri, 15 Dec 2023) Changed paths: M tests/plugins_integration/checks.py Log Message: ----------- plugins test: Show diffs with --add-checks passed The test did not display diffs in existing canons when --add-checks was passed. This could be misleading and is also inconvenient because it may require additional runs when maintaining the tests. This change fixes that. Change-Id: I81f49605d42f6682f7941b3af881a2a33268c51f Commit: 94047cdb1d8a08b213520be0260313b96799b86e https://github.com/Checkmk/checkmk/commit/94047cdb1d8a08b213520be0260313b96… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2023-12-15 (Fri, 15 Dec 2023) Changed paths: M tests/plugins_integration/checks.py M tests/plugins_integration/test_plugin.py Log Message: ----------- plugins test: assert on list of failed check names So far, the test was asserting on a boolean result of the function process_check_result(), which made the AssertionFailed exception output pretty meaningless. Although that is not an issue for a local CLI execution, it is needlessly hiding the failure for CI runs. The process_check_result() function will now return a list of failed checks, which is expected to be empty and will be returned as part of the AssertionFailed exception otherwise. NOTE: The detailed diff will still be logged as before. Change-Id: I8f5ebdd28dba2727544b5d50ced86a38b9e700ba Commit: 79514ef4ebd512de036d58976350e5e99ac50ac6 https://github.com/Checkmk/checkmk/commit/79514ef4ebd512de036d58976350e5e99… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2023-12-15 (Fri, 15 Dec 2023) Changed paths: M tests/plugins_integration/test_plugin.py Log Message: ----------- plugins test: Removed outdated test docstring Change-Id: I592cdb5e4c8aae275b3bce7d916702779bb70e22 Compare: https://github.com/Checkmk/checkmk/compare/f20b1eaddcb5...79514ef4ebd5