[checkmk-commits] [tribe29/checkmk] 5abf1e: Make ValueSpec.canonical_value() abstract.

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 5abf1eeb3ab8d53823b1827b81b500f8d43b4dae https://github.com/tribe29/checkmk/commit/5abf1eeb3ab8d53823b1827b81b500f8d… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2022-03-02 (Wed, 02 Mar 2022) Changed paths: M cmk/gui/plugins/wato/bi_config.py M cmk/gui/valuespec.py Log Message: ----------- Make ValueSpec.canonical_value() abstract. This is a step towards improving its type: Currently, the Optional is forced upon the return value although this is often not the right thing. Furthermore, default_value() gets a forced Optional because of this, too. Change-Id: If6ae6bd19df2e5d0a15295c5aa597ac0cff0b43c Commit: aec792d1ebc0d4c823d07139d337180f5db1279e https://github.com/tribe29/checkmk/commit/aec792d1ebc0d4c823d07139d337180f5… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2022-03-02 (Wed, 02 Mar 2022) Changed paths: M cmk/gui/valuespec.py Log Message: ----------- Various tiny typing tweaks. Change-Id: I43a163e0b215789bf8d214b4da4ef30f4d70575e Commit: 03c648f171a3e7b06b042a4ddae419617edc97b5 https://github.com/tribe29/checkmk/commit/03c648f171a3e7b06b042a4ddae419617… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2022-03-02 (Wed, 02 Mar 2022) Changed paths: M cmk/gui/valuespec.py Log Message: ----------- Remove Optional from ValueSpec.canonical_value() and default_value(). If really needed, the Optional should be in the type of the underlying ValueSpec model, not in the base class. Change-Id: Ic786415c8ebef5edc339fb1d77faeb259f7f0f96 Compare: https://github.com/tribe29/checkmk/compare/366787dd2bd9...03c648f171a3