28 Mar
2019
28 Mar
'19
2:56 p.m.
Module: check_mk
Branch: master
Commit: e05f0d9ee0ca46be65df5ad795f86edcbe0569a1
URL:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e05f0d9ee0ca46…
Author: Óscar Nájera <on(a)mathias-kettner.de>
Date: Mon Mar 18 18:42:32 2019 +0100
Integration tests for rrdtool
- Test python binding for direct memory access
- Test CLI export tool for matching representation of memory
- Update core RRDcolumn comments and behavior
CMK-1837
Change-Id: I3e7e4cca64e64a193c37d62dc68d7a41b68102ff
---
tests/integration/omd/test_rrdtool.py | 170 ++++++++++++++++++++++++++++++++++
1 file changed, 170 insertions(+)
diff --git a/tests/integration/omd/test_rrdtool.py
b/tests/integration/omd/test_rrdtool.py
new file mode 100644
index 0000000..59bedfe
--- /dev/null
+++ b/tests/integration/omd/test_rrdtool.py
@@ -0,0 +1,170 @@
+"""
+Test the rrdtool python binding and CLI
+
+This tests works on the rrdtool itself and is not related to our
+livestatus. It is just a simpler test to keep things working the way we
+understand them today. This same message is on RRDColumn.cc
+
+
+XPORT takes a closed timewindow in its query and returns the timestamped
+values that represent an intersection with the query window. The returned
+interval description is right closed.
+
+The timestamps associated with a value in RRDtool ALWAYS represent the time
+the sample was taken. Since any value you sample will represent some sort
+of past state your sampling apparatus has gathered, the timestamp will
+always be at the end of the sampling period.
+
+LEGEND
+O timestamps of measurements
+| query values, _start_time and _end_time
+x returned start, no data contained
+v returned data rows, includes end y
+
+--O---O---O---O---O---O---O---O
+ |---------------|
+ x---v---v---v---v---y
+"""
+import subprocess
+import pytest
+
+import rrdtool
+
+
+(a)pytest.fixture(scope="session")
+def rrd_database(tmp_path_factory):
+ "Create rrd database for integration test"
+ database = tmp_path_factory.mktemp("databases") / "test.rrd"
+
+ # Choosing a time that is easy on the eyes on the terminal
+ # Fri Jul 14 04:40:00 CEST 2017
+ start = 1500000000
+
+ rrdtool.create([
+ str(database),
+ "--start",
+ str(start - 60),
+ "--step",
+ "10s",
+ "DS:one:GAUGE:100:0:100000000",
+ "RRA:AVERAGE:0.5:1:10",
+ "RRA:AVERAGE:0.5:4:10",
+ ])
+
+ for i in range(0, 401, 10):
+ rrdtool.update([str(database), "-t", "one", "%i:%i"
% (start + i, i)])
+ return database
+
+
+(a)pytest.mark.parametrize("boundsounds, result", [
+ pytest.param(
+ (1500000343, 1500000401), {
+ "data": [(350.0,), (360.0,), (370.0,), (380.0,), (390.0,),
(400.0,), (None,)],
+ "meta": {
+ "start": 1500000340,
+ "end": 1500000410,
+ "step": 10,
+ "rows": 7,
+ "columns": 1,
+ "legend": [""],
+ }
+ },
+ id="High res"),
+ pytest.param(
+ (1500000066, 1500000360), {
+ "data": [(65.0,), (105.0,), (145.0,), (185.0,), (225.0,), (265.0,),
(305.0,), (345.0,)],
+ "meta": {
+ "start": 1500000040,
+ "end": 1500000360,
+ "step": 40,
+ "rows": 8,
+ "columns": 1,
+ "legend": [""],
+ }
+ },
+ id="Low res, large span"),
+ pytest.param(
+ (1500000022, 1500000048), {
+ "data": [(25.0,), (65.0,)],
+ "meta": {
+ "start": 1500000000,
+ "end": 1500000080,
+ "step": 40,
+ "rows": 2,
+ "columns": 1,
+ "legend": [""],
+ }
+ },
+ id="Low res, old data"),
+])
+def test_xport(rrd_database, bounds, result):
+ "Test python binding and that direct memory access behaves correctly"
+ qstart, qend = bounds
+ assert (rrdtool.xport([
+ "DEF:fir=%s:one:AVERAGE" % rrd_database,
+ "XPORT:fir",
+ "-s",
+ str(qstart),
+ "-e",
+ str(qend),
+ ]) == result)
+
+
+(a)pytest.mark.parametrize("boundsounds, out_fmt, result", [
+ pytest.param((1500000322, 1500000378), ["-t", "--json"],
+ """{ "about": "RRDtool graph JSON
output",
+ "meta": {
+ "start": 1500000320,
+ "end": 1500000380,
+ "step": 10,
+ "legend": [
+ ""
+ ]
+ },
+ "data": [
+ [ "1500000330",3.3000000000e+02 ],
+ [ "1500000340",3.4000000000e+02 ],
+ [ "1500000350",3.5000000000e+02 ],
+ [ "1500000360",3.6000000000e+02 ],
+ [ "1500000370",3.7000000000e+02 ],
+ [ "1500000380",3.8000000000e+02 ]
+ ]
+}\n""",
+ id="JSON output"),
+ pytest.param((1500000126, 1500000158), ["-t"],
+ """<?xml version="1.0"
encoding="ISO-8859-1"?>\n
+<xport>
+ <meta>
+ <start>1500000120</start>
+ <end>1500000160</end>
+ <step>40</step>
+ <rows>1</rows>
+ <columns>1</columns>
+ <legend>
+ <entry></entry>
+ </legend>
+ </meta>
+ <data>
+
<row><t>1500000160</t><v>1.4500000000e+02</v></row>
+ </data>
+</xport>\n""",
+ id="XML output"),
+])
+def test_cli_xport(rrd_database, bounds, out_fmt, result):
+ """Test CLI so that when debugging output from tool it matches state
in memory
+
+ RRDTool composes the XML/JSON outputs explicitly and one may rely for
+ now that the order of elements be always the same."""
+ qstart, qend = bounds
+ stdout = subprocess.check_output([
+ 'rrdtool',
+ "xport",
+ "DEF:fir=%s:one:AVERAGE" % rrd_database,
+ "XPORT:fir",
+ "-s",
+ str(qstart),
+ "-e",
+ str(qend),
+ ] + out_fmt)
+
+ assert stdout == result